5879b96a64
Changes in a server-side tree can cause the need for clients to import different objects from packages. For example, turning on documentation. Another more subtle case is where an object might "move" from package A to B by being deleted from A - then the jigdo build process will pick the B version. We need a "cache validation key"; a way for the server to tell the client that the objects it should import from the package have changed. Initially I was thinking of using the libostree "content hash" but that would be awkward as we'd have to do an import on the server side too. After more consideration I realized a simple *count* of the number of objects actually works, because (as I note in a comment) changing a file in the tree will result in it ending up in the jigdoRPM (and count as a deletion). And obviously adding or removing objects changes the count too. In fact we could have done this *without* breaking the format by just having the client start recording the number of xattr entries, but this adds greater flexibility down the line since we can in theory change how we do cache invalidation if we *really* need to (but at the cost of triggering clients to redownload packages). Note the client logic got moved around as now we need to parse all the xattrs before we decide what packages to download. My test case here is turning on docs - I noticed this actually affects *every* package which was surprising to me; I expected at least some packages wouldn't have docs. I'll double check this. It'd be good to have a "moving object" case too which I may look at. Closes: https://github.com/projectatomic/rpm-ostree/issues/1197 Closes: #1256 Approved by: jlebon |
||
|---|---|---|
| .. | ||
| libbasic-test.sh | ||
| libcomposetest.sh | ||
| test-basic-unified.sh | ||
| test-basic.sh | ||
| test-boot-location-new.sh | ||
| test-compose2jigdo.sh | ||
| test-install-langs.sh | ||
| test-installroot.sh | ||
| test-jigdo-e2e.sh | ||
| test-misc-tweaks.sh | ||
| test-mutate-os-release.sh | ||
| test-write-commitid.sh | ||