36566e406e
So...at some point we somehow lost `-Wall` in our default compiler flags which means we were missing some potentially important warnings. And we used to have `-Werror` on in CI which combined with the above was strongly opinionated about not landing warnings in git master. Our default stance here remains the same; we have an opinionated set of `-Werror=` that applies in *all* configurations. However that set moves into Automake - I don't think we need to do compiler version detection anymore, we can assume a modern compiler. We also add back in `-Wall` by default now. Further in CI, add `-Werror`. The implementation here is in our buildsystem rather than `export CXXFLAGS=-Werror` because unfortunately we have to fix things in libdnf too, and I don't want to block entirely on that. |
||
---|---|---|
.. | ||
prow | ||
build-check.sh | ||
build.sh | ||
ci-commitmessage-submodules.sh | ||
clang-analyzer.sh | ||
clang-build-check.sh | ||
codestyle.sh | ||
commit-validation.sh | ||
coreosci-rpmbuild.sh | ||
cosa-build.sh | ||
install-extra-builddeps.sh | ||
installdeps.sh | ||
libbuild.sh | ||
unit.sh | ||
vmcheck-provision.sh |