rpm-ostree/tests/vmcheck/install.sh
Colin Walters 1c5c4a457e tests: Correctly error out if some part of install.sh fails
It took me way, way, way too long to debug that my dev container somehow missing
`ostree-grub2` caused the script to fail early, but we'd still continue trying
to sync, leading to us not actually changing the installed `rpm-ostree` binary,
leading to test suite failures.

Also add the chmod hammer at the top so we can delete even if we fail after
doing an rsync.

Closes: #1115
Approved by: jlebon
2017-11-29 14:42:25 +00:00

38 lines
1.2 KiB
Bash
Executable File

#!/bin/bash
set -euo pipefail
# This is just a small wrapper for `make install`, but with the added logic to
# pull in ostree packages from the build container. We always assume development
# and testing is against git master ostree and that the build container is
# tracking e.g. CAHC or FAHC (see HACKING.md for more details).
DESTDIR=${topsrcdir}/insttree
# Chown everything to writable, due to
# https://bugzilla.redhat.com/show_bug.cgi?id=517575
if test -d ${DESTDIR}; then chmod -R u+w ${DESTDIR}/; fi
rm -rf ${DESTDIR}
mkdir -p ${DESTDIR}
ostree --version
for pkg in ostree{,-libs,-grub2}; do
rpm -q $pkg
# We do not have perms to read /etc/grub2 as non-root. In the prebuilt
# container case, manpages are missing. Ignore that.
rpm -ql $pkg | grep -vE "^/(etc|usr/share/(doc|man))/" > list.txt
# See above chown https://bugzilla.redhat.com/show_bug.cgi?id=517575
chmod -R u+w ${DESTDIR}/
# Note we cant use --ignore-missing-args here since it was added in
# rsync 3.1.0, but CentOS7 only has rsync 3.0.9. Anyway, we expect
# everything in list.txt to be present (otherwise, tweak grep above).
rsync -l --files-from=list.txt / ${DESTDIR}/
rm -f list.txt
done
make install DESTDIR=${DESTDIR}