rpm-ostree

History

Colin Walters a9c8b1fae1 ex-container: Make /etc/shadow 0400 on import, not post-checkout Switching to the `_CONSUME` flag revealed an "oh god how did I write that" bug in the previous patch in https://github.com/projectatomic/rpm-ostree/pull/1046 AKA commit: `334f0b89be` The way that actually fixed the bug before was because we were using hardlink checkouts, and we were operating outside an `rofiles-fuse` context, we simply directly changed the on-disk object mode. But with the `_CONSUME` flag we started deleting the files as we write, meaning that stopped working. I initially wrote a patch to do the same split "prepare/processing/commit" flow that treecompose and package layering do, but that can't really fix this bug - we need to do it on import. So do the chmod on import and drop the postprocessing bits. Closes: #1067 Approved by: jlebon	2017-10-18 17:07:54 +00:00
..
test-bash.sh	ex-container: Make /etc/shadow 0400 on import, not post-checkout	2017-10-18 17:07:54 +00:00

Colin Walters a9c8b1fae1 ex-container: Make /etc/shadow 0400 on import, not post-checkout

Switching to the `_CONSUME` flag revealed an "oh god how did I write that"
bug in the previous patch in https://github.com/projectatomic/rpm-ostree/pull/1046
AKA commit: 334f0b89be

The way that actually fixed the bug before was because we were using
hardlink checkouts, and we were operating outside an `rofiles-fuse`
context, we simply directly changed the on-disk object mode.

But with the `_CONSUME` flag we started deleting the files as we write,
meaning that stopped working.

I *initially* wrote a patch to do the same split "prepare/processing/commit"
flow that treecompose and package layering do, but that can't really fix this
bug - we need to do it on import.

So do the chmod on import and drop the postprocessing bits.

Closes: #1067
Approved by: jlebon

2017-10-18 17:07:54 +00:00

test-bash.sh ex-container: Make /etc/shadow 0400 on import, not post-checkout 2017-10-18 17:07:54 +00:00