4249dc8c63
When I initially added support for local RPM layering (#657), I was operating under the assumption that there is no reliable way to parse a NEVRA back to its constituent elements. So we worked around this by doing lookups in the pkgcache and comparing against branches converted back to their NEVRAs, which was pretty hacky. Later on, I learned that you *can* reliably parse a NEVRA back to its elements because RPM forbids all fields from having a colon `:` and all fields other than the package name to have a dash `-`. In fact, there is a helper from `libdnf` to do exactly this. This patch swaps out the old way of decomposing NEVRAs and converting NEVRAs to their cache branch notation with a simpler more direct approach using the helper function from `libdnf`. Closes: #1395 Approved by: cgwalters