6583a557ae
We've had multiple reports by now of folks using plain `ex livefs` and getting their bootloader wrecked: https://github.com/projectatomic/rpm-ostree/issues/1495 https://github.com/projectatomic/rpm-ostree/issues/1504 https://github.com/ostreedev/ostree/issues/1459 Let's require a scary switch for now to emphasize this. Closes: #1622 Approved by: cgwalters
200 lines
8.1 KiB
Bash
Executable File
200 lines
8.1 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Copyright (C) 2017 Red Hat Inc.
|
|
#
|
|
# This library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2 of the License, or (at your option) any later version.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with this library; if not, write to the
|
|
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
# Boston, MA 02111-1307, USA.
|
|
|
|
set -euo pipefail
|
|
|
|
. ${commondir}/libtest.sh
|
|
. ${commondir}/libvm.sh
|
|
|
|
set -x
|
|
|
|
# We do various assertions on deployment length, need a reliably
|
|
# clean slate.
|
|
vm_rpmostree cleanup -pr
|
|
|
|
vm_assert_layered_pkg foo absent
|
|
|
|
vm_build_rpm foo
|
|
vm_rpmostree install /var/tmp/vmcheck/yumrepo/packages/x86_64/foo-1.0-1.x86_64.rpm
|
|
vm_assert_status_jq '.deployments|length == 2'
|
|
echo "ok install foo locally"
|
|
|
|
if vm_cmd rpm -q foo; then
|
|
assert_not_reached "have foo?"
|
|
fi
|
|
assert_livefs_ok() {
|
|
vm_rpmostree ex livefs --i-like-danger -n > livefs-analysis.txt
|
|
assert_file_has_content livefs-analysis.txt 'livefs OK (dry run)'
|
|
}
|
|
assert_livefs_ok
|
|
|
|
vm_assert_status_jq '.deployments|length == 2' \
|
|
'.deployments[0]["live-replaced"]|not' \
|
|
'.deployments[1]["live-replaced"]|not'
|
|
vm_rpmostree ex livefs --i-like-danger
|
|
vm_cmd rpm -q foo > rpmq.txt
|
|
assert_file_has_content rpmq.txt foo-1.0-1
|
|
vm_assert_status_jq '.deployments|length == 3' '.deployments[0]["live-replaced"]|not' \
|
|
'.deployments[1]["live-replaced"]'
|
|
|
|
echo "ok livefs stage1"
|
|
|
|
vm_build_rpm test-livefs-with-etc \
|
|
build 'echo "A config file for %{name}" > %{name}.conf' \
|
|
install 'mkdir -p %{buildroot}/etc
|
|
install %{name}.conf %{buildroot}/etc
|
|
mkdir -p %{buildroot}/etc/%{name}/
|
|
echo subconfig-one > %{buildroot}/etc/%{name}/subconfig-one.conf
|
|
echo subconfig-two > %{buildroot}/etc/%{name}/subconfig-two.conf
|
|
mkdir -p %{buildroot}/etc/%{name}/subdir
|
|
echo subconfig-three > %{buildroot}/etc/%{name}/subdir/subconfig-three.conf
|
|
mkdir -p %{buildroot}/etc/opt
|
|
echo file-in-opt-subdir > %{buildroot}/etc/opt/%{name}-opt.conf' \
|
|
files "/etc/%{name}.conf
|
|
/etc/%{name}/*
|
|
/etc/opt/%{name}*"
|
|
|
|
# Simulate a service that adds a user and has data in tmpfiles.d
|
|
vm_build_rpm test-livefs-service \
|
|
build "echo test-livefs-service > test-livefs-service.txt" \
|
|
install "mkdir -p %{buildroot}/{usr/share,var/lib/%{name}}
|
|
install test-livefs-service.txt %{buildroot}/usr/share" \
|
|
pre "groupadd -r livefs-group
|
|
useradd -r livefs-user -g livefs-group -s /sbin/nologin" \
|
|
files "/usr/share/%{name}.txt
|
|
/var/lib/%{name}"
|
|
|
|
# make sure there are no config files already present
|
|
vm_cmd rm -rf /etc/test-livefs-with-etc \
|
|
/etc/test-livefs-with-etc.conf \
|
|
/etc/opt/test-livefs-with-etc-opt.conf
|
|
|
|
vm_rpmostree install /var/tmp/vmcheck/yumrepo/packages/x86_64/test-livefs-{with-etc,service}-1.0-1.x86_64.rpm
|
|
assert_livefs_ok
|
|
vm_rpmostree ex livefs --i-like-danger
|
|
vm_cmd rpm -q foo test-livefs-{with-etc,service} > rpmq.txt
|
|
assert_file_has_content rpmq.txt foo-1.0-1 test-livefs-{with-etc,service}-1.0-1
|
|
vm_cmd cat /etc/test-livefs-with-etc.conf > test-livefs-with-etc.conf
|
|
assert_file_has_content test-livefs-with-etc.conf "A config file for test-livefs-with-etc"
|
|
for v in subconfig-one subconfig-two subdir/subconfig-three; do
|
|
vm_cmd cat /etc/test-livefs-with-etc/${v}.conf > test-livefs-with-etc.conf
|
|
assert_file_has_content_literal test-livefs-with-etc.conf $(basename $v)
|
|
done
|
|
vm_cmd cat /etc/opt/test-livefs-with-etc-opt.conf > test-livefs-with-etc.conf
|
|
assert_file_has_content test-livefs-with-etc.conf "file-in-opt-subdir"
|
|
# Test /usr/lib/{passwd,group} bits
|
|
vm_cmd getent passwd livefs-user > test-livefs-user.txt
|
|
assert_file_has_content test-livefs-user.txt livefs-user
|
|
vm_cmd getent group livefs-group > test-livefs-group.txt
|
|
assert_file_has_content test-livefs-group.txt livefs-group
|
|
# Test systemd-tmpfiles
|
|
vm_cmd test -d /var/lib/test-livefs-service
|
|
|
|
echo "ok livefs stage2"
|
|
|
|
# Now, perform a further change in the pending
|
|
vm_rpmostree uninstall test-livefs-with-etc-1.0-1.x86_64
|
|
vm_assert_status_jq '.deployments|length == 3'
|
|
echo "ok livefs preserved rollback"
|
|
|
|
# Reset to rollback, undeploy pending
|
|
reset() {
|
|
vm_rpmostree ex reset
|
|
vm_reboot
|
|
vm_rpmostree cleanup -r
|
|
vm_assert_status_jq '.deployments|length == 1' '.deployments[0]["live-replaced"]|not'
|
|
}
|
|
reset
|
|
|
|
# If the admin created a config file before, we need to keep it
|
|
vm_rpmostree install /var/tmp/vmcheck/yumrepo/packages/x86_64/test-livefs-with-etc-1.0-1.x86_64.rpm
|
|
vm_cmd cat /etc/test-livefs-with-etc.conf || true
|
|
vm_cmd echo custom \> /etc/test-livefs-with-etc.conf
|
|
vm_cmd cat /etc/test-livefs-with-etc.conf
|
|
vm_rpmostree ex livefs --i-like-danger
|
|
vm_cmd cat /etc/test-livefs-with-etc.conf > test-livefs-with-etc.conf
|
|
assert_file_has_content test-livefs-with-etc.conf "custom"
|
|
echo "ok livefs preserved modified config"
|
|
|
|
vm_rpmostree cleanup -p
|
|
# make sure there's no layering going on somehow
|
|
vm_assert_status_jq '.deployments[0]["base-checksum"]|not'
|
|
vm_rpmostree deploy $(vm_get_booted_deployment_info checksum)
|
|
echo "ok livefs redeploy booted commit"
|
|
|
|
reset
|
|
vm_rpmostree install /var/tmp/vmcheck/yumrepo/packages/x86_64/foo-1.0-1.x86_64.rpm
|
|
vm_rpmostree ex livefs --i-like-danger
|
|
# Picked a file that should be around, but harmless to change for testing. The
|
|
# first is available on Fedora, the second on CentOS (and newer too).
|
|
dummy_file_to_modify=usr/share/licenses/ostree/COPYING
|
|
if ! vm_cmd test -f /${dummy_file_to_modify}; then
|
|
dummy_file_to_modify=usr/share/ostree/trusted.gpg.d/README-gpg
|
|
fi
|
|
vm_cmd test -f /${dummy_file_to_modify}
|
|
generate_upgrade() {
|
|
# Create a modified vmcheck commit
|
|
vm_ansible_inline <<EOF
|
|
- shell: |
|
|
set -xeuo pipefail
|
|
cd /ostree/repo/tmp
|
|
rm vmcheck -rf
|
|
ostree checkout vmcheck vmcheck --fsync=0
|
|
(date; echo "JUST KIDDING DO WHATEVER") >vmcheck/${dummy_file_to_modify}.new && mv vmcheck/${dummy_file_to_modify}{.new,}
|
|
$@
|
|
ostree commit -b vmcheck --tree=dir=vmcheck --link-checkout-speedup
|
|
rm vmcheck -rf
|
|
EOF
|
|
}
|
|
generate_upgrade
|
|
# And remove the pending deployment so that our origin is now the booted
|
|
vm_rpmostree cleanup -p
|
|
vm_rpmostree upgrade
|
|
vm_assert_status_jq '.deployments|length == 3' '.deployments[0]["live-replaced"]|not' \
|
|
'.deployments[1]["live-replaced"]'
|
|
|
|
echo "ok livefs not carried over across upgrades"
|
|
|
|
reset
|
|
generate_upgrade "mkdir -p vmcheck/usr/newsubdir && date > vmcheck/usr/newsubdir/date.txt"
|
|
vm_rpmostree upgrade
|
|
vm_assert_status_jq '.deployments|length == 2' '.deployments[0]["live-replaced"]|not' \
|
|
'.deployments[1]["live-replaced"]|not'
|
|
if vm_rpmostree ex livefs --i-like-danger -n &> livefs-analysis.txt; then
|
|
assert_not_reached "livefs succeeded?"
|
|
fi
|
|
vm_assert_status_jq '.deployments|length == 2' '.deployments[0]["live-replaced"]|not' \
|
|
'.deployments[1]["live-replaced"]|not'
|
|
assert_file_has_content livefs-analysis.txt 'No packages added'
|
|
echo "ok no modifications"
|
|
|
|
# And now replacement
|
|
vm_rpmostree ex livefs -n --i-like-danger --dangerous-do-not-use-replace &> livefs-analysis.txt
|
|
assert_file_has_content livefs-analysis.txt 'livefs OK (dry run)'
|
|
vm_assert_status_jq '.deployments|length == 2' '.deployments[0]["live-replaced"]|not' \
|
|
'.deployments[1]["live-replaced"]|not'
|
|
vm_rpmostree ex livefs --i-like-danger --dangerous-do-not-use-replace
|
|
vm_cmd cat /${dummy_file_to_modify} > dummyfile.txt
|
|
assert_file_has_content dummyfile.txt "JUST KIDDING DO WHATEVER"
|
|
vm_cmd test -f /usr/newsubdir/date.txt
|
|
vm_assert_status_jq '.deployments|length == 3' '.deployments[0]["live-replaced"]|not' \
|
|
'.deployments[1]["live-replaced"]' '.deployments[1]["booted"]'
|
|
echo "ok modifications"
|
|
|