konevsa/fish
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
fish/tests/checks/invocation.fish

108 lines
3.7 KiB
Fish
Raw Permalink Normal View History

set error code on failed command substitution to 255 instead of -1 the exit status ought to be in 0-255, e.g. exit -1
2020-01-17 15:08:14 +01:00
#RUN: %fish -C 'set -l fish %fish' %s
$fish -c "echo 1.2.3.4."
Port most of the invocation tests to littlecheck This is a bit weird sometimes, e.g. to test the return status (that fish actually *returns $status*), we use a #RUN line with %fish invoking %fish, so we can use the substitution. Still much nicer. The missing scripts are those that rely on config.
2019-06-25 20:47:28 +02:00
# CHECK: 1.2.3.4.
set error code on failed command substitution to 255 instead of -1 the exit status ought to be in 0-255, e.g. exit -1
2020-01-17 15:08:14 +01:00
Rationalize $status and errors Prior to this fix, fish was rather inconsistent in when $status gets set in response to an error. For example, a failed expansion like "$foo[" would not modify $status. This makes the following inter-related changes: 1. String expansion now directly returns the value to set for $status on error. The value is always used. 2. parser_t::eval() now directly returns the proc_status_t, which cleans up a lot of call sites. 3. We expose a new function exec_subshell_for_expand() which ignores $status but returns errors specifically related to subshell expansion. 4. We reify the notion of "expansion breaking" errors. These include command-not-found, expand syntax errors, and others. The upshot is we are more consistent about always setting $status on errors.
2020-01-23 17:34:46 -08:00
PATH= $fish -c "command a" 2>/dev/null
echo $status
# CHECK: 127
set error code on failed command substitution to 255 instead of -1 the exit status ought to be in 0-255, e.g. exit -1
2020-01-17 15:08:14 +01:00
PATH= $fish -c "echo (command a)" 2>/dev/null
echo $status
Rationalize $status and errors Prior to this fix, fish was rather inconsistent in when $status gets set in response to an error. For example, a failed expansion like "$foo[" would not modify $status. This makes the following inter-related changes: 1. String expansion now directly returns the value to set for $status on error. The value is always used. 2. parser_t::eval() now directly returns the proc_status_t, which cleans up a lot of call sites. 3. We expose a new function exec_subshell_for_expand() which ignores $status but returns errors specifically related to subshell expansion. 4. We reify the notion of "expansion breaking" errors. These include command-not-found, expand syntax errors, and others. The upshot is we are more consistent about always setting $status on errors.
2020-01-23 17:34:46 -08:00
# CHECK: 127
Move the invocation checks to invocation.fish These where separate files so we could use the %s substitution to run that fish, but since discovering setting $fish that workaround isn't necessary.
2020-03-31 19:52:56 +02:00
if not set -q GITHUB_WORKFLOW
$fish -c 'if status --is-login ; echo login shell ; else ; echo not login shell ; end; if status --is-interactive ; echo interactive ; else ; echo not interactive ; end' -i
# CHECK: not login shell
# CHECK: interactive
$fish -c 'if status --is-login ; echo login shell ; else ; echo not login shell ; end; if status --is-interactive ; echo interactive ; else ; echo not interactive ; end' -l -i
# CHECK: login shell
# CHECK: interactive
else
Fix typo
2020-10-31 09:23:28 +08:00
# GitHub Action doesn't start this in a terminal, so fish would complain.
Move the invocation checks to invocation.fish These where separate files so we could use the %s substitution to run that fish, but since discovering setting $fish that workaround isn't necessary.
2020-03-31 19:52:56 +02:00
# Instead, we just fake the result, since we have no way to indicate a skipped test.
echo not login shell
echo interactive
echo login shell
echo interactive
end
$fish -c 'if status --is-login ; echo login shell ; else ; echo not login shell ; end; if status --is-interactive ; echo interactive ; else ; echo not interactive ; end' -l
# CHECK: login shell
# CHECK: not interactive
$fish -c 'if status --is-login ; echo login shell ; else ; echo not login shell ; end; if status --is-interactive ; echo interactive ; else ; echo not interactive ; end'
# CHECK: not login shell
# CHECK: not interactive
$fish -c 'if status --is-login ; echo login shell ; else ; echo not login shell ; end; if status --is-interactive ; echo interactive ; else ; echo not interactive ; end' -l
# CHECK: login shell
# CHECK: not interactive
Read arguments with `fish -c` This reads any additional positional arguments given to `fish -c` into $argv. We don't handle the first argument specially (as `$0`) as that's confusing and doesn't seem very useful. Fixes #2314.
2020-09-26 14:45:51 +02:00
Add more tests for -c arguments
2020-09-26 15:05:26 +02:00
# Arguments for -c
Read arguments with `fish -c` This reads any additional positional arguments given to `fish -c` into $argv. We don't handle the first argument specially (as `$0`) as that's confusing and doesn't seem very useful. Fixes #2314.
2020-09-26 14:45:51 +02:00
$fish -c 'string escape $argv' 1 2 3
# CHECK: 1
# CHECK: 2
# CHECK: 3
Add more tests for -c arguments
2020-09-26 15:05:26 +02:00
# Two -cs
$fish -c 'string escape y$argv' -c 'string escape x$argv' 1 2 3
# CHECK: y1
# CHECK: y2
# CHECK: y3
# CHECK: x1
# CHECK: x2
# CHECK: x3
Exit if --no-execute is enabled don't interactively read from the terminal Don't go into implicit interactive mode without ever executing anything - not even `exit` or reacting to ctrl-d. That just renders the shell useless and unquittable.
2021-01-01 21:15:09 +01:00
# Should just do nothing.
$fish --no-execute
Add a separate --profile-startup option to profile startup This goes to a separate file because that makes option parsing easier and allows profiling both at the same time. The "normal" profile now contains only the profile data of the actual run, which is much more useful - you can now profile a function by running fish -C 'source /path/to/thing' --profile /tmp/thefunction.prof -c 'thefunction' and won't need to filter out extraneous information.
2021-01-08 17:25:00 +01:00
set -l tmp (mktemp -d)
$fish --profile $tmp/normal.prof --profile-startup $tmp/startup.prof -ic exit
# This should be the full file - just the one command we gave explicitly!
cat $tmp/normal.prof
# CHECK: Time{{\s+}}Sum{{\s+}}Command
# CHECK: {{\d+\s+\d+\s+>}} exit
string match -rq "builtin source " < $tmp/startup.prof
and echo matched
# CHECK: matched
# See that sending both profiles to the same file works.
$fish --profile $tmp/full.prof --profile-startup $tmp/full.prof -c 'echo thisshouldneverbeintheconfig'
# CHECK: thisshouldneverbeintheconfig
string match -rq "builtin source " < $tmp/full.prof
and echo matched
# CHECK: matched
string match -rq "echo thisshouldneverbeintheconfig" < $tmp/full.prof
and echo matched
# CHECK: matched
Run parse_util_detect_errors on `-c` commands This didn't do all the syntax checks, so something like fish -c 'echo foo; and $status' complained of a missing command `0` (i.e. $status), and fish -c 'echo foo | exec grep' hit an assert! So we do what read_ni does, parse each command into an ast, run parse_util_detect_errors on it if it worked and then eval the ast. It is possible to do this neater by modifying parser::eval, but I can't find where.
2021-07-27 17:44:02 +02:00
$fish --no-config -c 'echo notprinted; echo foo | exec true; echo banana'
# CHECKERR: fish: The 'exec' command can not be used in a pipeline
# CHECKERR: echo notprinted; echo foo | exec true; echo banana
Add length to the parse_util syntax errors
2022-08-12 16:53:31 +02:00
# CHECKERR: ^~~~~~~~^
Run parse_util_detect_errors on `-c` commands This didn't do all the syntax checks, so something like fish -c 'echo foo; and $status' complained of a missing command `0` (i.e. $status), and fish -c 'echo foo | exec grep' hit an assert! So we do what read_ni does, parse each command into an ast, run parse_util_detect_errors on it if it worked and then eval the ast. It is possible to do this neater by modifying parser::eval, but I can't find where.
2021-07-27 17:44:02 +02:00
# Running multiple command lists continues even if one has a syntax error.
$fish --no-config -c 'echo $$ oh no syntax error' -c 'echo this works'
# CHECK: this works
# CHECKERR: fish: $$ is not the pid. In fish, please use $fish_pid.
# CHECKERR: echo $$ oh no syntax error
# CHECKERR: ^
Actually return when reading file failed Fixes #8258.
2021-08-29 08:34:57 +02:00
$fish --no-config .
# CHECKERR: error: Unable to read input file: Is a directory
# CHECKERR: warning: Error while reading file .
Don't skip caret for some errors This checked specifically for "| and" and "a=b" and then just gave the error without a caret at all. E.g. for a /tmp/broken.fish that contains ```fish echo foo echo foo | and cat ``` This would print: ``` /tmp/broken.fish (line 3): The 'and' command can not be used in a pipeline warning: Error while reading file /tmp/broken.fish ``` without any indication other than the line number as to the location of the error. Now we do ``` /tmp/broken.fish (line 3): The 'and' command can not be used in a pipeline echo foo | and cat ^~^ warning: Error while reading file /tmp/broken.fish ``` Another nice one: ``` fish --no-config -c 'echo notprinted; echo foo; a=b' ``` failed to give the error message! (Note: Is it really a "warning" if we failed to read the one file we wer told to?) We should check if we should either centralize these error messages completely, or always pass them and remove this "code" system, because it's only used in some cases.
2022-08-12 17:04:30 +02:00
$fish --no-config -c 'echo notprinted; echo foo; a=b'
# CHECKERR: fish: Unsupported use of '='. In fish, please use 'set a b'.
# CHECKERR: echo notprinted; echo foo; a=b
# CHECKERR: ^~^
$fish --no-config -c 'echo notprinted | and true'
# CHECKERR: fish: The 'and' command can not be used in a pipeline
# CHECKERR: echo notprinted | and true
# CHECKERR: ^~^
Reference in New Issue Copy Permalink