konevsa/fish
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Emit more specific error for incomplete escape sequences

Browse Source 
This replaces "Invalid token ..." with "Incomplete escape sequence ..." for
bare \c, \u, \U, \x, and \X escapes.
This commit is contained in:
Mahmoud Al-Qudsi 2022-09-16 15:28:55 -05:00
parent 47574de6b1
commit 351500e42d
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/parse_util.cpp
View File

@ -957,8 +957,15 @@ parser_test_error_bits_t parse_util_detect_errors_in_argument(const ast::argumen
wcstring unesc;
if (!unescape_string(arg_src.c_str() + begin, end - begin, &unesc, UNESCAPE_SPECIAL)) {
if (out_errors) {
const wchar_t *fmt = L"Invalid token '%ls'";
if (arg_src.length() == 2 && arg_src[0] == L'\\' &&
(arg_src[1] == L'c' || towlower(arg_src[1]) == L'u'
|| towlower(arg_src[1]) == L'x')) {
fmt = L"Incomplete escape sequence '%ls'";
}
append_syntax_error(out_errors, source_start + begin, end - begin,
L"Invalid token '%ls'", arg_src.c_str());
fmt, arg_src.c_str());
}
return 1;
}