From 3b9b84101adb5d38f3291fb6aa8b89875bc5fece Mon Sep 17 00:00:00 2001
From: Fabian Boehm <FHomborg@gmail.com>
Date: Sun, 31 Dec 2023 19:36:42 +0100
Subject: [PATCH] umask: Correctly handle empty symbolic value

Simple return/echo confusion.

Fixes #10177

(cherry picked from commit b895cf49ca91329d8903e0f9aa2b0f64437c2608)
---
 share/functions/umask.fish | 3 ++-
 tests/checks/umask.fish    | 7 +++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/share/functions/umask.fish b/share/functions/umask.fish
index 779dc436c..9a946480c 100644
--- a/share/functions/umask.fish
+++ b/share/functions/umask.fish
@@ -39,7 +39,8 @@ set __fish_umask_set_table 6 5 4 3 2 1 0
 function __fish_umask_set
     set -l to_set $argv[1]
     if test $to_set -eq 0
-        return 7
+        echo 7
+        return
     end
     echo $__fish_umask_set_table[$to_set]
 end
diff --git a/tests/checks/umask.fish b/tests/checks/umask.fish
index 39e833999..6bc3f895f 100644
--- a/tests/checks/umask.fish
+++ b/tests/checks/umask.fish
@@ -89,3 +89,10 @@ umask
 umask -S
 #CHECK: 0222
 #CHECK: u=rx,g=rx,o=rx
+
+umask u=rwx,g=rwx,o=
+umask
+#CHECK: 0007
+umask u=rwx,g=,o=rwx
+umask
+#CHECK: 0070