konevsa/fish
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove needless rank comparison

Browse Source 
We've already removed any ranks that aren't equal to `best_rank` at this
point, so why are we comparing them again?
This commit is contained in:
Mahmoud Al-Qudsi 2022-09-16 21:34:10 -05:00
parent 472fc3ec10
commit 3ef047f242
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/complete.cpp
View File

@ -303,9 +303,7 @@ void completions_sort_and_prioritize(completion_list_t *comps, completion_reques
// Sort, provided COMPLETE_DONT_SORT isn't set.
// Here we do not pass suppress_exact, so that exact matches appear first.
stable_sort(comps->begin(), comps->end(), [&](const completion_t &a, const completion_t &b) {
return a.rank() < b.rank() || natural_compare_completions(a, b);
});
stable_sort(comps->begin(), comps->end(), natural_compare_completions);
// Lastly, if this is for an autosuggestion, prefer to avoid completions that duplicate
// arguments, and penalize files that end in tilde - they're frequently autosave files from e.g.