konevsa/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: quic: Missing initializations for ducplicated frames.

Browse Source 
When duplication frames in qc_dup_pkt_frms(), ->pkt member was not correctly
initialized (copied from the original frame). This could not have any impact
because this member is initialized whe the frame is added to a packet.
This was also the case for ->flags.
Also replace the pool_zalloc() call by a call to pool_alloc().

Must be backported to 2.6.
This commit is contained in:
Frédéric Lécaille 2022-08-18 08:20:47 +02:00
parent 4b85a963be
commit 4173a39c1f
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/xprt_quic.c
View File

@ -2330,8 +2330,7 @@ static void qc_dup_pkt_frms(struct quic_conn *qc,
break;
}
// FIXME: zalloc
dup_frm = pool_zalloc(pool_head_quic_frame);
dup_frm = pool_alloc(pool_head_quic_frame);
if (!dup_frm) {
TRACE_ERROR("could not duplicate frame", QUIC_EV_CONN_PRSAFRM, qc, frm);
break;
@ -2342,11 +2341,13 @@ static void qc_dup_pkt_frms(struct quic_conn *qc,
*/
origin = frm->origin ? frm->origin : frm;
TRACE_DEVEL("built probing frame", QUIC_EV_CONN_PRSAFRM, qc, origin);
*dup_frm = *origin;
LIST_INIT(&dup_frm->reflist);
TRACE_DEVEL("duplicated from packet", QUIC_EV_CONN_PRSAFRM,
qc, NULL, &origin->pkt->pn_node.key);
*dup_frm = *origin;
dup_frm->pkt = NULL;
dup_frm->origin = origin;
dup_frm->flags = 0;
LIST_INIT(&dup_frm->reflist);
LIST_APPEND(&origin->reflist, &dup_frm->ref);
LIST_APPEND(&tmp, &dup_frm->list);
}