konevsa/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[BUG] cttproxy: socket fd leakage in check_cttproxy_version

Browse Source 
in cttproxy.c check_cttproxy_version socket is not closed before function
returned. Although it is called only once, I think it is better to close
the socket.
This commit is contained in:
Delta Yeh 2010-05-03 22:08:33 +08:00 committed by Willy Tarreau
parent d2c142c7ee
commit af01c7c2a6
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/cttproxy.c
View File

@ -33,7 +33,7 @@
*/ */
int check_cttproxy_version() { int check_cttproxy_version() {
struct in_tproxy itp1; struct in_tproxy itp1;
int fd; int fd, ret;
memset(&itp1, 0, sizeof(itp1)); memset(&itp1, 0, sizeof(itp1));
@ -43,14 +43,16 @@ int check_cttproxy_version() {
itp1.op = TPROXY_VERSION; itp1.op = TPROXY_VERSION;
itp1.v.version = 0x02000000; /* CTTPROXY version 2.0 expected */ itp1.v.version = 0x02000000; /* CTTPROXY version 2.0 expected */
ret = 0;
if (setsockopt(fd, SOL_IP, IP_TPROXY, &itp1, sizeof(itp1)) == -1) { if (setsockopt(fd, SOL_IP, IP_TPROXY, &itp1, sizeof(itp1)) == -1) {
if (errno == -EINVAL) if (errno == -EINVAL)
return -1; /* wrong version */ ret = -1; /* wrong version */
else else
return -2; /* not supported or other error */ ret = -2; /* not supported or other error */
} }
return 0; close(fd);
return ret;
} }