konevsa/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CONTRIB: halog: fix issue with array of type char

Browse Source 
I just noticed this in the windows build after moving the file to dev/:

   In file included from include/import/ist.h:32,
                   from include/haproxy/connection-t.h:32,
                   from dev/flags/flags.c:5:
  dev/flags/flags.c: In function `main':
  dev/flags/flags.c:442:20: error: array subscript has type `char' [-Werror=char-subscripts]
    442 |           (isalnum(*err) && toupper(*err) != 'U' && toupper(*err) != 'L'))
        |                    ^~~~
    LD      haproxy
  cc1: all warnings being treated as errors
  make: *** [Makefile:932: dev/flags/flags.o] Error 1
  make: *** Waiting for unfinished jobs....
  Error: Process completed with exit code 2.

Let's just cast it to uchar as is done everywhere else.
This commit is contained in:
Willy Tarreau 2021-04-02 17:47:21 +02:00
parent a1e832b867
commit b00c00e82c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/debug/flags.c
View File

@ -439,7 +439,7 @@ int main(int argc, char **argv)
/* stop at the end of the number and trim any C suffix like "UL" */
err = value;
while (*err == '-' || *err == '+' ||
(isalnum(*err) && toupper(*err) != 'U' && toupper(*err) != 'L'))
(isalnum((unsigned char)*err) && toupper((unsigned char)*err) != 'U' && toupper((unsigned char)*err) != 'L'))
err++;
if (err)
*err = 0;