konevsa/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CLEANUP: connection: Remove useless test for NULL before calling pool_free()

Browse Source 
`pool_free()` is a noop when the given pointer is NULL. No need to test.
This commit is contained in:
Tim Duesterhus 2021-03-06 20:06:48 +01:00 committed by Willy Tarreau
parent c44b8de995
commit e004c2beae
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/haproxy/connection.h
View File

@ -553,18 +553,14 @@ static inline void conn_free(struct connection *conn)
sockaddr_free(&conn->src); sockaddr_free(&conn->src);
sockaddr_free(&conn->dst); sockaddr_free(&conn->dst);
if (conn->proxy_authority != NULL) {
pool_free(pool_head_authority, conn->proxy_authority); pool_free(pool_head_authority, conn->proxy_authority);
conn->proxy_authority = NULL; conn->proxy_authority = NULL;
}
if (isttest(conn->proxy_unique_id)) {
pool_free(pool_head_uniqueid, conn->proxy_unique_id.ptr); pool_free(pool_head_uniqueid, conn->proxy_unique_id.ptr);
conn->proxy_unique_id = IST_NULL; conn->proxy_unique_id = IST_NULL;
}
if (conn->hash_node) {
pool_free(pool_head_conn_hash_node, conn->hash_node); pool_free(pool_head_conn_hash_node, conn->hash_node);
conn->hash_node = NULL; conn->hash_node = NULL;
}
/* By convention we always place a NULL where the ctx points to if the /* By convention we always place a NULL where the ctx points to if the
* mux is null. It may have been used to store the connection as a * mux is null. It may have been used to store the connection as a