konevsa/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: buffer: fix debugging condition in b_peek_varint()

Browse Source 
The BUG_ON_HOT() test condition added to b_peek_varint() by commit
8873b85bd ("DEBUG: buf: add BUG_ON_HOT() to most buffer management
functions") was wrong as <data> in this function is not b->data,
so that was triggering during live dumps of H2 traces on the CLI
when built with -DDEBUG_STRICT=2. No backport is needed.
This commit is contained in:
Willy Tarreau 2022-03-11 16:55:49 +01:00
parent 76e8b70e43
commit f1cb4ac745
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/haproxy/buf.h
View File

@ -913,7 +913,7 @@ static inline int b_peek_varint(struct buffer *b, size_t ofs, uint64_t *vptr)
uint64_t v = 0;
int bits = 0;
BUG_ON_HOT(ofs > data);
BUG_ON_HOT(ofs > b_data(b));
if (data != 0 && (*head >= 0xF0)) {
v = *head;