konevsa/proxmox-widget-toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

JournalView: avoid null dereference on quick tab switch

Browse Source 
the updateView method can be called through an XHR request callback,
which may get triggered once the user switched already over to
another panel and viewmodel isn't valid (or did not get valid at the
first place) anymore.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2020-05-26 10:13:04 +02:00
parent 8f9e331d8c
commit 865be88ed5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
panel/JournalView.js
View File

@ -62,7 +62,7 @@ Ext.define('Proxmox.panel.JournalView', {
var me = this;
var view = me.getView();
var viewmodel = me.getViewModel();
if (viewmodel.get('livemode') !== livemode) {
if (!viewmodel || viewmodel.get('livemode') !== livemode) {
return; // we switched mode, do not update the content
}
var contentEl = me.lookup('content');