From 9ae7fe04e260c40a6dba217ebc0031dd5261c83d Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Tue, 23 Mar 2021 17:24:09 +0100 Subject: [PATCH] panel/acme-domains: fix cyclic dependency in view model A view model forumla cannot depend on itself, as that is a dependency cycle. In this specific case we can just drop the `hasUsage` forumla entry completely, it is bogus as it was just returning its value, and that is actually taken care of by the `hasUsage` data binding. The debug build of ExtJS throws an exception on such cycles, the release build does not cares to much and seems to do the right thing already here. Signed-off-by: Thomas Lamprecht --- src/panel/ACMEDomains.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/panel/ACMEDomains.js b/src/panel/ACMEDomains.js index f66975f..2b6c204 100644 --- a/src/panel/ACMEDomains.js +++ b/src/panel/ACMEDomains.js @@ -47,7 +47,6 @@ Ext.define('Proxmox.panel.ACMEDomains', { editBtnIcon: (get) => 'fa black fa-' + (get('accountEditable') ? 'check' : 'pencil'), accountTextHidden: (get) => get('accountEditable') || !get('accountsAvailable'), accountValueHidden: (get) => !get('accountEditable') || !get('accountsAvailable'), - hasUsage: (get) => get('hasUsage'), }, },