From a4b57d6c3cc2eae4f54e8bf23656f6e6f1b4e1bc Mon Sep 17 00:00:00 2001 From: Maximiliano Sandoval Date: Wed, 26 Jun 2024 14:43:43 +0200 Subject: [PATCH] acme: derive Default for Status Fixes the clippy warning: warning: this `impl` can be derived --> proxmox-acme/src/order.rs:36:1 | 36 | / impl Default for Status { 37 | | fn default() -> Self { 38 | | Status::New 39 | | } 40 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it... | 12 + #[derive(Default)] 13 | pub enum Status { | help: ...and mark the default variant | 15 ~ #[default] 16 ~ New, | Signed-off-by: Maximiliano Sandoval --- proxmox-acme/src/order.rs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/proxmox-acme/src/order.rs b/proxmox-acme/src/order.rs index 404d4ae7..b6551004 100644 --- a/proxmox-acme/src/order.rs +++ b/proxmox-acme/src/order.rs @@ -9,9 +9,11 @@ use crate::Error; /// Status of an [`Order`]. #[derive(Clone, Copy, Debug, Eq, PartialEq, Deserialize, Serialize)] #[serde(rename_all = "lowercase")] +#[derive(Default)] pub enum Status { /// Invalid, used as a place holder for when sending objects as contrary to account creation, /// the Acme RFC does not require the server to ignore unknown parts of the `Order` object. + #[default] New, /// Authorization failed and it is now invalid. @@ -33,12 +35,6 @@ pub enum Status { Valid, } -impl Default for Status { - fn default() -> Self { - Status::New - } -} - impl Status { /// Serde helper fn is_new(&self) -> bool {