konevsa/proxmox
1
0
Fork 0
forked from Proxmox/proxmox
Code Pull Requests Activity

apt: clippy: don't clone types implementing Copy

Browse Source 
Fixes the clippy warnings:

warning: `proxmox-apt` (lib) generated 1 warning
warning: using `clone` on type `Option<[u8; 32]>` which implements the `Copy` trait
   --> proxmox-apt/tests/repositories.rs:117:22
    |
117 |     let old_digest = file.digest.clone().unwrap();
    |                      ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file.digest`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait
   --> proxmox-apt/tests/repositories.rs:135:24
    |
135 |     file.digest = Some(old_digest.clone());
    |                        ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `old_digest`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
This commit is contained in:
Maximiliano Sandoval 2024-08-07 09:43:48 +02:00 committed by Thomas Lamprecht
parent c3713cffe5
commit 7052972212
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
proxmox-apt/tests/repositories.rs
View File

@ -114,7 +114,7 @@ fn test_digest() -> Result<(), Error> {
let new_path = write_dir.join(path.file_name().unwrap()); let new_path = write_dir.join(path.file_name().unwrap());
file.path = Some(new_path.clone().into_os_string().into_string().unwrap()); file.path = Some(new_path.clone().into_os_string().into_string().unwrap());
let old_digest = file.digest.clone().unwrap(); let old_digest = file.digest.unwrap();
// file does not exist yet... // file does not exist yet...
assert!(file.read_with_digest().is_err()); assert!(file.read_with_digest().is_err());
@ -132,7 +132,7 @@ fn test_digest() -> Result<(), Error> {
repo.enabled = !repo.enabled; repo.enabled = !repo.enabled;
// ...then it should work // ...then it should work
file.digest = Some(old_digest.clone()); file.digest = Some(old_digest);
file.write()?; file.write()?;
// expect a different digest, because the repo was modified // expect a different digest, because the repo was modified