konevsa/pve-manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BackupEdit, cleanup: remove insideUpdate construct

Browse Source 
insideUpdate protects for a endless loop which gets caused if the sm
selection change callback updates vmidField which then triggers the
vmidField change callback which updates the selection model again,
and the circle starts again.

As this construct is rather confusing when looking first at the code
replace it with a temporary suspend of the change event during the
vmidField update.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2016-10-05 11:34:17 +02:00 committed by Fabian Grünbichler
parent da356293f7
commit 2ed889126e
1 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
www/manager6/dc/Backup.js
View File

@ -35,22 +35,20 @@ Ext.define('PVE.dc.BackupEdit', {
value: ''
});
var insideUpdate = false;
var sm = Ext.create('Ext.selection.CheckboxModel', {
mode: 'SIMPLE',
listeners: {
selectionchange: function(model, selected) {
if (!insideUpdate) { // avoid endless loop
var sel = [];
Ext.Array.each(selected, function(record) {
sel.push(record.data.vmid);
});
var sel = [];
Ext.Array.each(selected, function(record) {
sel.push(record.data.vmid);
});
insideUpdate = true;
vmidField.setValue(sel);
insideUpdate = false;
}
// to avoid endless recursion suspend the vmidField change
// event temporary as it calls us again
vmidField.suspendEvent('change');
vmidField.setValue(sel);
vmidField.resumeEvent('change');
}
}
});
@ -219,10 +217,6 @@ Ext.define('PVE.dc.BackupEdit', {
});
var update_vmid_selection = function(list, mode) {
if (insideUpdate) {
return; // should not happen - just to be sure
}
insideUpdate = true;
if (mode !== 'all') {
sm.deselectAll(true);
if (list) {
@ -234,7 +228,6 @@ Ext.define('PVE.dc.BackupEdit', {
});
}
}
insideUpdate = false;
};
vmidField.on('change', function(f, value) {