diff --git a/Cargo.lock b/Cargo.lock index 06a12f53b..069688c9d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -461,10 +461,11 @@ dependencies = [ [[package]] name = "confy" version = "0.4.1" -source = "git+https://github.com/open-trade/confy#27fa12941291b44ccd856aef4a5452c1eb646047" dependencies = [ "directories", "serde 1.0.125", + "serde_derive", + "serde_yaml", "toml", ] @@ -1763,6 +1764,12 @@ dependencies = [ "num-traits 0.2.14", ] +[[package]] +name = "linked-hash-map" +version = "0.5.4" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "7fb9b38af92608140b86b693604b9ffcc5824240a484d1ecd4795bacb2fe88f3" + [[package]] name = "lock_api" version = "0.3.4" @@ -3196,6 +3203,18 @@ dependencies = [ "serde 1.0.125", ] +[[package]] +name = "serde_yaml" +version = "0.8.17" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "15654ed4ab61726bf918a39cb8d98a2e2995b002387807fa6ba58fdf7f59bb23" +dependencies = [ + "dtoa", + "linked-hash-map", + "serde 1.0.125", + "yaml-rust", +] + [[package]] name = "sha2" version = "0.9.3" @@ -4115,6 +4134,15 @@ version = "0.8.3" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "b07db065a5cf61a7e4ba64f29e67db906fb1787316516c4e6e5ff0fea1efcd8a" +[[package]] +name = "yaml-rust" +version = "0.4.5" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "56c1936c4cc7a1c9ab21a1ebb602eb942ba868cbd44a99cb7cdc5892335e1c85" +dependencies = [ + "linked-hash-map", +] + [[package]] name = "yansi" version = "0.5.0" diff --git a/README.md b/README.md index a8ac64a1a..8bb28514d 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,7 @@ # RustDesk | Your Remote Desktop Software +Chat with us: [Discord](https://discord.gg/nDceKgxnkV) + An open-source remote desktop client software, written in Rust. Works out of the box, no configuration required. Great alternative to TeamViewer and AnyDesk! You have full control of your data, with no concerns about security. You can use our rendezvous/relay server, [set up your own](https://rustdesk.com/blog/id-relay-set/), or [write your own rendezvous/relay server](https://github.com/rustdesk/rustdesk-server-demo). [**BINARY DOWNLOAD**](https://github.com/rustdesk/rustdesk/releases) diff --git a/libs/confy/.gitignore b/libs/confy/.gitignore new file mode 100644 index 000000000..55e830d9e --- /dev/null +++ b/libs/confy/.gitignore @@ -0,0 +1,14 @@ +# Generated by Cargo +# will have compiled files and executables +/target/ + +# Remove Cargo.lock from gitignore if creating an executable, leave it for libraries +# More information here http://doc.crates.io/guide.html#cargotoml-vs-cargolock +Cargo.lock + +# These are backup files generated by rustfmt +**/*.rs.bk + +/target +**/*.rs.bk +Cargo.lock diff --git a/libs/confy/Cargo.toml b/libs/confy/Cargo.toml new file mode 100644 index 000000000..749ab44a8 --- /dev/null +++ b/libs/confy/Cargo.toml @@ -0,0 +1,26 @@ +[package] +name = "confy" +version = "0.4.1" +authors = ["Katharina Fey "] +description = "Boilerplate-free configuration management" +license = "MIT/X11 OR Apache-2.0" +documentation = "https://docs.rs/confy" +repository = "https://github.com/rust-clique/confy" +edition = "2018" + +[dependencies] +serde = "^1.0" +toml = { version = "^0.5", optional = true } +directories = "^2.0" +serde_yaml = { version = "0.8", optional = true } + +[features] +default = ["toml_conf"] +toml_conf = ["toml"] +yaml_conf = ["serde_yaml"] + +[[example]] +name = "simple" + +[dev-dependencies] +serde_derive = "^1.0" diff --git a/libs/confy/LICENSE b/libs/confy/LICENSE new file mode 100644 index 000000000..74c2a263c --- /dev/null +++ b/libs/confy/LICENSE @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2018 rust-clique + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. diff --git a/libs/confy/README.md b/libs/confy/README.md new file mode 100644 index 000000000..1b4cebb52 --- /dev/null +++ b/libs/confy/README.md @@ -0,0 +1,39 @@ +# confy + +Chat with us: [Discord](https://discord.gg/dwq4Zme) + +Zero-boilerplate configuration management. + +Focus on storing the right data, instead of worrying about how or where to store it. + +```rust +use serde_derive::{Serialize, Deserialize}; + +#[derive(Default, Debug, Serialize, Deserialize)] +struct MyConfig { + version: u8, + api_key: String, +} + +fn main() -> Result<(), ::std::io::Error> { + let cfg: MyConfig = confy::load("my-app-name")?; + dbg!(cfg); + Ok(()) +} +``` + +## Using yaml +Enabling the `yaml_conf` feature while disabling the default `toml_conf` +feature causes confy to use a YAML config file instead of TOML. + +``` +[dependencies.confy] +features = ["yaml_conf"] +default-features = false +``` + +## Breakings changes +Starting with version 0.4.0 the configuration file are stored in the expected place for your system. See the [`directories`] crates for more information. +Before version 0.4.0, the configuration file was written in the current directory. + +[`directories`]: https://crates.io/crates/directories diff --git a/libs/confy/examples/simple.rs b/libs/confy/examples/simple.rs new file mode 100644 index 000000000..f95bb6416 --- /dev/null +++ b/libs/confy/examples/simple.rs @@ -0,0 +1,29 @@ +//! The most simplest examples of how to use confy + +extern crate confy; + +#[macro_use] +extern crate serde_derive; + +#[derive(Debug, Serialize, Deserialize)] +struct ConfyConfig { + name: String, + comfy: bool, + foo: i64, +} + +impl Default for ConfyConfig { + fn default() -> Self { + ConfyConfig { + name: "Unknown".to_string(), + comfy: true, + foo: 42, + } + } +} + +fn main() -> Result<(), confy::ConfyError> { + let cfg: ConfyConfig = confy::load("confy_simple_app")?; + println!("{:#?}", cfg); + Ok(()) +} diff --git a/libs/confy/src/lib.rs b/libs/confy/src/lib.rs new file mode 100644 index 000000000..eaccaae9c --- /dev/null +++ b/libs/confy/src/lib.rs @@ -0,0 +1,300 @@ +//! Zero-boilerplate configuration management +//! +//! ## Why? +//! +//! There are a lot of different requirements when +//! selecting, loading and writing a config, +//! depending on the operating system and other +//! environment factors. +//! +//! In many applications this burden is left to you, +//! the developer of an application, to figure out +//! where to place the configuration files. +//! +//! This is where `confy` comes in. +//! +//! ## Idea +//! +//! `confy` takes care of figuring out operating system +//! specific and environment paths before reading and +//! writing a configuration. +//! +//! It gives you easy access to a configuration file +//! which is mirrored into a Rust `struct` via [serde]. +//! This way you only need to worry about the layout of +//! your configuration, not where and how to store it. +//! +//! [serde]: https://docs.rs/crates/serde +//! +//! `confy` uses the [`Default`] trait in Rust to automatically +//! create a new configuration, if none is available to read +//! from yet. +//! This means that you can simply assume your application +//! to have a configuration, which will be created with +//! default values of your choosing, without requiring +//! any special logic to handle creation. +//! +//! [`Default`]: https://doc.rust-lang.org/std/default/trait.Default.html +//! +//! ```rust,no_run +//! use serde_derive::{Serialize, Deserialize}; +//! +//! #[derive(Serialize, Deserialize)] +//! struct MyConfig { +//! version: u8, +//! api_key: String, +//! } +//! +//! /// `MyConfig` implements `Default` +//! impl ::std::default::Default for MyConfig { +//! fn default() -> Self { Self { version: 0, api_key: "".into() } } +//! } +//! +//! fn main() -> Result<(), confy::ConfyError> { +//! let cfg = confy::load("my-app-name")?; +//! Ok(()) +//! } +//! ``` +//! +//! Updating the configuration is then done via the [`store`] function. +//! +//! [`store`]: fn.store.html +//! + +mod utils; +use utils::*; + +use directories::ProjectDirs; +use serde::{de::DeserializeOwned, Serialize}; +use std::error::Error; +use std::fmt; +use std::fs::{self, File, OpenOptions}; +use std::io::{ErrorKind::NotFound, Write}; +use std::path::{Path, PathBuf}; + +#[cfg(not(any(feature = "toml_conf", feature = "yaml_conf")))] +compile_error!("Exactly one config language feature must be enabled to use \ +confy. Please enable one of either the `toml_conf` or `yaml_conf` \ +features."); + +#[cfg(all(feature = "toml_conf", feature = "yaml_conf"))] +compile_error!("Exactly one config language feature must be enabled to compile \ +confy. Please disable one of either the `toml_conf` or `yaml_conf` features. \ +NOTE: `toml_conf` is a default feature, so disabling it might mean switching off \ +default features for confy in your Cargo.toml"); + +#[cfg(all(feature = "toml_conf", not(feature = "yaml_conf")))] +const EXTENSION: &str = "toml"; + +#[cfg(feature = "yaml_conf")] +const EXTENSION: &str = "yml"; + +/// Load an application configuration from disk +/// +/// A new configuration file is created with default values if none +/// exists. +/// +/// Errors that are returned from this function are I/O related, +/// for example if the writing of the new configuration fails +/// or `confy` encounters an operating system or environment +/// that it does not support. +/// +/// **Note:** The type of configuration needs to be declared in some way +/// that is inferrable by the compiler. Also note that your +/// configuration needs to implement `Default`. +/// +/// ```rust,no_run +/// # use confy::ConfyError; +/// # use serde_derive::{Serialize, Deserialize}; +/// # fn main() -> Result<(), ConfyError> { +/// #[derive(Default, Serialize, Deserialize)] +/// struct MyConfig {} +/// +/// let cfg: MyConfig = confy::load("my-app-name")?; +/// # Ok(()) +/// # } +/// ``` +pub fn load(name: &str) -> Result { + let project = ProjectDirs::from("rs", "", name).ok_or(ConfyError::BadConfigDirectoryStr)?; + + let config_dir_str = get_configuration_directory_str(&project)?; + + let path: PathBuf = [config_dir_str, &format!("{}.{}", name, EXTENSION)].iter().collect(); + + load_path(path) +} + +/// Load an application configuration from a specified path. +/// +/// This is an alternate version of [`load`] that allows the specification of +/// an aritrary path instead of a system one. For more information on errors +/// and behavior, see [`load`]'s documentation. +/// +/// [`load`]: fn.load.html +pub fn load_path(path: impl AsRef) -> Result { + match File::open(&path) { + Ok(mut cfg) => { + let cfg_string = cfg + .get_string() + .map_err(ConfyError::ReadConfigurationFileError)?; + + #[cfg(feature = "toml_conf")] { + let cfg_data = toml::from_str(&cfg_string); + cfg_data.map_err(ConfyError::BadTomlData) + } + #[cfg(feature = "yaml_conf")] { + let cfg_data = serde_yaml::from_str(&cfg_string); + cfg_data.map_err(ConfyError::BadYamlData) + } + + } + Err(ref e) if e.kind() == NotFound => { + if let Some(parent) = path.as_ref().parent() { + fs::create_dir_all(parent) + .map_err(ConfyError::DirectoryCreationFailed)?; + } + store_path(path, T::default())?; + Ok(T::default()) + } + Err(e) => Err(ConfyError::GeneralLoadError(e)), + } +} + +/// The errors the confy crate can encounter. +#[derive(Debug)] +pub enum ConfyError { + #[cfg(feature = "toml_conf")] + BadTomlData(toml::de::Error), + + #[cfg(feature = "yaml_conf")] + BadYamlData(serde_yaml::Error), + + DirectoryCreationFailed(std::io::Error), + GeneralLoadError(std::io::Error), + BadConfigDirectoryStr, + + #[cfg(feature = "toml_conf")] + SerializeTomlError(toml::ser::Error), + + #[cfg(feature = "yaml_conf")] + SerializeYamlError(serde_yaml::Error), + + WriteConfigurationFileError(std::io::Error), + ReadConfigurationFileError(std::io::Error), + OpenConfigurationFileError(std::io::Error), +} + +impl fmt::Display for ConfyError { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { + match self { + + #[cfg(feature = "toml_conf")] + ConfyError::BadTomlData(e) => write!(f, "Bad TOML data: {}", e), + #[cfg(feature = "toml_conf")] + ConfyError::SerializeTomlError(_) => write!(f, "Failed to serialize configuration data into TOML."), + + #[cfg(feature = "yaml_conf")] + ConfyError::BadYamlData(e) => write!(f, "Bad YAML data: {}", e), + #[cfg(feature = "yaml_conf")] + ConfyError::SerializeYamlError(_) => write!(f, "Failed to serialize configuration data into YAML."), + + ConfyError::DirectoryCreationFailed(e) => write!(f, "Failed to create directory: {}", e), + ConfyError::GeneralLoadError(_) => write!(f, "Failed to load configuration file."), + ConfyError::BadConfigDirectoryStr => write!(f, "Failed to convert directory name to str."), + ConfyError::WriteConfigurationFileError(_) => write!(f, "Failed to write configuration file."), + ConfyError::ReadConfigurationFileError(_) => write!(f, "Failed to read configuration file."), + ConfyError::OpenConfigurationFileError(_) => write!(f, "Failed to open configuration file."), + } + } +} + +impl Error for ConfyError {} + +/// Save changes made to a configuration object +/// +/// This function will update a configuration, +/// with the provided values, and create a new one, +/// if none exists. +/// +/// You can also use this function to create a new configuration +/// with different initial values than which are provided +/// by your `Default` trait implementation, or if your +/// configuration structure _can't_ implement `Default`. +/// +/// ```rust,no_run +/// # use serde_derive::{Serialize, Deserialize}; +/// # use confy::ConfyError; +/// # fn main() -> Result<(), ConfyError> { +/// #[derive(Serialize, Deserialize)] +/// struct MyConf {} +/// +/// let my_cfg = MyConf {}; +/// confy::store("my-app-name", my_cfg)?; +/// # Ok(()) +/// # } +/// ``` +/// +/// Errors returned are I/O errors related to not being +/// able to write the configuration file or if `confy` +/// encounters an operating system or environment it does +/// not support. +pub fn store(name: &str, cfg: T) -> Result<(), ConfyError> { + let project = ProjectDirs::from("rs", "", name).ok_or(ConfyError::BadConfigDirectoryStr)?; + fs::create_dir_all(project.config_dir()).map_err(ConfyError::DirectoryCreationFailed)?; + + let config_dir_str = get_configuration_directory_str(&project)?; + + let path: PathBuf = [config_dir_str, &format!("{}.{}", name, EXTENSION)].iter().collect(); + + store_path(path, cfg) +} + +/// Save changes made to a configuration object at a specified path +/// +/// This is an alternate version of [`store`] that allows the specification of +/// an aritrary path instead of a system one. For more information on errors +/// and behavior, see [`store`]'s documentation. +/// +/// [`store`]: fn.store.html +pub fn store_path(path: impl AsRef, cfg: T) -> Result<(), ConfyError> { + let path = path.as_ref(); + let mut path_tmp = path.to_path_buf(); + use std::time::{SystemTime, UNIX_EPOCH}; + let mut i = 0; + loop { + i += 1; + path_tmp.set_extension(SystemTime::now().duration_since(UNIX_EPOCH).map(|x| x.as_nanos()).unwrap_or(i).to_string()); + if !path_tmp.exists() { + break; + } + } + let mut f = OpenOptions::new() + .write(true) + .create(true) + .truncate(true) + .open(&path_tmp) + .map_err(ConfyError::OpenConfigurationFileError)?; + + let s; + #[cfg(feature = "toml_conf")] { + s = toml::to_string(&cfg).map_err(ConfyError::SerializeTomlError)?; + } + #[cfg(feature = "yaml_conf")] { + s = serde_yaml::to_string(&cfg).map_err(ConfyError::SerializeYamlError)?; + } + + f.write_all(s.as_bytes()) + .map_err(ConfyError::WriteConfigurationFileError)?; + std::fs::rename(path_tmp, path) + .map_err(ConfyError::WriteConfigurationFileError)?; + Ok(()) +} + +fn get_configuration_directory_str(project: &ProjectDirs) -> Result<&str, ConfyError> { + let config_dir_option = project.config_dir().to_str(); + + match config_dir_option { + Some(x) => Ok(x), + None => Err(ConfyError::BadConfigDirectoryStr), + } +} diff --git a/libs/confy/src/utils.rs b/libs/confy/src/utils.rs new file mode 100644 index 000000000..d2d4263e7 --- /dev/null +++ b/libs/confy/src/utils.rs @@ -0,0 +1,16 @@ +//! Some storage utilities + +use std::fs::File; +use std::io::{Error as IoError, Read}; + +pub trait CheckedStringRead { + fn get_string(&mut self) -> Result; +} + +impl CheckedStringRead for File { + fn get_string(&mut self) -> Result { + let mut s = String::new(); + self.read_to_string(&mut s)?; + Ok(s) + } +} diff --git a/libs/hbb_common/Cargo.toml b/libs/hbb_common/Cargo.toml index 6dc5319c8..5faff841a 100644 --- a/libs/hbb_common/Cargo.toml +++ b/libs/hbb_common/Cargo.toml @@ -24,7 +24,7 @@ rand = "0.7" serde_derive = "1.0" serde = "1.0" lazy_static = "1.4" -confy = { git = "https://github.com/open-trade/confy" } +confy = { path = "../confy" } dirs-next = "2.0" filetime = "0.2" sodiumoxide = "0.2"