Fix test failure

Before we tested with an unavailable font, but the hyphens were still visible. But now the hyphens respect fallback too, so it's really hard to test it. I am removing the test for now.
This commit is contained in:
Laurenz 2023-10-03 16:20:24 +02:00
parent d709b0e247
commit 6b1233e127
3 changed files with 4 additions and 11 deletions

View File

@ -451,11 +451,10 @@ impl<'a> ShapedText<'a> {
.glyphs
.last()
.map(|g| g.range.end..g.range.end)
// In the unlikely chance that we hyphenate after an
// empty line, ensure that the glyph range still falls
// after self.base so that subtracting either of the
// endpoints by self.base doesnt underflow.
// See <https://github.com/typst/typst/issues/2283>.
// In the unlikely chance that we hyphenate after an empty line,
// ensure that the glyph range still falls after self.base so
// that subtracting either of the endpoints by self.base doesn't
// underflow. See <https://github.com/typst/typst/issues/2283>.
.unwrap_or_else(|| self.base..self.base);
self.width += x_advance.at(self.size);
self.glyphs.to_mut().push(ShapedGlyph {

Binary file not shown.

Before

Width:  |  Height:  |  Size: 3.9 KiB

After

Width:  |  Height:  |  Size: 3.9 KiB

View File

@ -26,9 +26,3 @@ ABCअपार्टमेंट
// doesn't exist in shaping output.
#set text(dir: rtl, font: "Noto Serif Hebrew")
\ ט
---
// Test that #2283 is fixed.
#set text(font: "test", lang: "de", hyphenate: true, fallback: false)
#set par(linebreaks: "simple")
- ensure