Don't display functions

This commit is contained in:
Laurenz 2022-11-21 16:49:26 +01:00
parent 1d7e082d1d
commit c28d2130dd
9 changed files with 22 additions and 27 deletions

View File

@ -179,7 +179,7 @@ impl Marginal {
Self::Content(content) => Some(content.clone()),
Self::Func(func, span) => {
let args = Args::new(*span, [Value::Int(page as i64)]);
Some(func.call_detached(world, args)?.display(world))
Some(func.call_detached(world, args)?.display())
}
})
}

View File

@ -252,7 +252,7 @@ impl Label {
Self::Content(content) => content.clone(),
Self::Func(func, span) => {
let args = Args::new(*span, [Value::Int(number as i64)]);
func.call_detached(world, args)?.display(world)
func.call_detached(world, args)?.display()
}
})
}

View File

@ -183,7 +183,7 @@ impl Eval for ast::MarkupNode {
Self::Desc(v) => v.eval(vm)?,
Self::Label(_) => unimplemented!("handled above"),
Self::Ref(v) => v.eval(vm)?,
Self::Expr(v) => v.eval(vm)?.display(vm.world),
Self::Expr(v) => v.eval(vm)?.display(),
}
.spanned(self.span()))
}
@ -474,7 +474,7 @@ fn eval_code(
break;
}
let tail = eval_code(vm, exprs)?.display(vm.world);
let tail = eval_code(vm, exprs)?.display();
Value::Content(tail.styled_with_map(styles))
}
ast::Expr::Show(show) => {
@ -483,7 +483,7 @@ fn eval_code(
break;
}
let tail = eval_code(vm, exprs)?.display(vm.world);
let tail = eval_code(vm, exprs)?.display();
Value::Content(tail.styled_with_recipe(vm.world, recipe)?)
}
_ => expr.eval(vm)?,

View File

@ -141,8 +141,8 @@ impl Func {
impl Debug for Func {
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
match self.name() {
Some(name) => f.write_str(name),
None => f.write_str("(..) => {..}"),
Some(name) => write!(f, "<function {name}>"),
None => f.write_str("<function>"),
}
}
}

View File

@ -510,7 +510,7 @@ impl Transform {
let point = || Tracepoint::Apply(content.name().into());
result = result.trace(world, point, span);
}
Ok(result?.display(world))
Ok(result?.display())
}
}
}

View File

@ -4,14 +4,12 @@ use std::fmt::{self, Debug, Formatter};
use std::hash::{Hash, Hasher};
use std::sync::Arc;
use comemo::Tracked;
use siphasher::sip128::{Hasher128, SipHasher};
use super::{format_str, ops, Args, Array, Cast, Content, Dict, Func, Str};
use crate::diag::StrResult;
use crate::geom::{Abs, Angle, Color, Em, Fr, Length, Ratio, Rel, RgbaColor};
use crate::util::{format_eco, EcoString};
use crate::World;
/// A computational value.
#[derive(Clone)]
@ -98,18 +96,15 @@ impl Value {
}
/// Return the display representation of the value.
pub fn display(self, world: Tracked<dyn World>) -> Content {
let items = &world.config().items;
pub fn display(self) -> Content {
match self {
Value::None => Content::empty(),
Value::Int(v) => (items.text)(format_eco!("{}", v)),
Value::Float(v) => (items.text)(format_eco!("{}", v)),
Value::Str(v) => (items.text)(v.into()),
Value::Content(v) => v,
// For values which can't be shown "naturally", we return the raw
// representation with typst code syntax highlighting.
v => (items.raw)(v.repr().into(), Some("typc".into()), false),
Self::None => Content::empty(),
Self::Int(v) => item!(text)(format_eco!("{}", v)),
Self::Float(v) => item!(text)(format_eco!("{}", v)),
Self::Str(v) => item!(text)(v.into()),
Self::Content(v) => v,
Self::Func(_) => Content::empty(),
_ => item!(raw)(self.repr().into(), Some("typc".into()), false),
}
}
}
@ -425,7 +420,7 @@ mod tests {
test(dict!["two" => false, "one" => 1], "(one: 1, two: false)");
// Functions, content and dynamics.
test(Func::from_fn("nil", |_, _| Ok(Value::None)), "nil");
test(Func::from_fn("nil", |_, _| Ok(Value::None)), "<function nil>");
test(Dynamic::new(1), "1");
}
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 2.6 KiB

After

Width:  |  Height:  |  Size: 2.3 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 30 KiB

After

Width:  |  Height:  |  Size: 29 KiB

View File

@ -40,9 +40,9 @@
#raw(repr[*{"H" + "i"} there*])
---
// Functions
// Functions are invisible.
Nothing
#let f(x) = x
{f} \
{rect} \
{() => none} \
{f}
{rect}
{() => none}