Fix package autocompletion deduplication (#3525)

This commit is contained in:
Laurenz 2024-02-28 17:29:44 +01:00 committed by GitHub
parent 8d63b0479c
commit e6fddd68e3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -1098,9 +1098,11 @@ impl<'a> CompletionContext<'a> {
/// Add completions for all available packages.
fn package_completions(&mut self, all_versions: bool) {
let mut packages: Vec<_> = self.world.packages().iter().collect();
packages.sort_by_key(|(spec, _)| (&spec.name, Reverse(spec.version)));
packages.sort_by_key(|(spec, _)| {
(&spec.namespace, &spec.name, Reverse(spec.version))
});
if !all_versions {
packages.dedup_by_key(|(spec, _)| &spec.name);
packages.dedup_by_key(|(spec, _)| (&spec.namespace, &spec.name));
}
for (package, description) in packages {
self.value_completion(