kozorizki/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUILD: quic: 32 bits compilation issue (QUIC_MIN() usage)

Browse Source 
This issue arrived with this commit:

	"MINOR: quic: HyStart++ implementation (RFC 9406)"

Thanks to @chipitsine for having reported this issue in GH #2513.

Should be backported where the previous commit will be backported.
This commit is contained in:
Frederic Lecaille 2024-04-03 11:05:28 +02:00
parent 6a2f09de1c
commit 0e14bac7bd
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/quic_cc_cubic.c
View File

@ -432,7 +432,7 @@ static void quic_cc_cubic_ss_cb(struct quic_cc *cc, struct quic_cc_event *ev)
case QUIC_CC_EVT_ACK: case QUIC_CC_EVT_ACK:
if (global.tune.options & GTUNE_QUIC_CC_HYSTART) { if (global.tune.options & GTUNE_QUIC_CC_HYSTART) {
struct quic_hystart *h = &c->hystart; struct quic_hystart *h = &c->hystart;
unsigned int acked = QUIC_MIN(ev->ack.acked, HYSTART_LIMIT * path->mtu); unsigned int acked = QUIC_MIN(ev->ack.acked, (uint64_t)HYSTART_LIMIT * path->mtu);
if (path->cwnd >= QUIC_CC_INFINITE_SSTHESH - acked) if (path->cwnd >= QUIC_CC_INFINITE_SSTHESH - acked)
goto out; goto out;
@ -508,7 +508,7 @@ static void quic_cc_cubic_cs_cb(struct quic_cc *cc, struct quic_cc_event *ev)
struct cubic *c = quic_cc_priv(cc); struct cubic *c = quic_cc_priv(cc);
struct quic_hystart *h = &c->hystart; struct quic_hystart *h = &c->hystart;
unsigned int acked = unsigned int acked =
QUIC_MIN(ev->ack.acked, HYSTART_LIMIT * path->mtu) / HYSTART_CSS_GROWTH_DIVISOR; QUIC_MIN(ev->ack.acked, (uint64_t)HYSTART_LIMIT * path->mtu) / HYSTART_CSS_GROWTH_DIVISOR;
if (path->cwnd >= QUIC_CC_INFINITE_SSTHESH - acked) if (path->cwnd >= QUIC_CC_INFINITE_SSTHESH - acked)
goto out; goto out;