kozorizki/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: http-ana: Report internal error if an action yields on a final eval

Browse Source 
This was already performed for tcp actions at content level, but not for
HTTP actions. It is always a bug, so it must be reported accordingly.

This patch may be backported to all stable versions.

(cherry picked from commit 65ea29dcf85c6553e6dd0613a9c6c506fe22b9ac)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
This commit is contained in:
Christopher Faulet 2024-10-29 18:09:51 +01:00
parent 127462ca1c
commit 14abd1881d
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/http_ana.c
View File

@ -2704,6 +2704,13 @@ static enum rule_result http_req_get_intercept_rule(struct proxy *px, struct lis
goto end;
case ACT_RET_YIELD:
s->current_rule = rule;
if (act_opts & ACT_OPT_FINAL) {
send_log(s->be, LOG_WARNING,
"Internal error: action yields while it is no long allowed "
"for the http-request actions.");
rule_ret = HTTP_RULE_RES_ERROR;
goto end;
}
rule_ret = HTTP_RULE_RES_YIELD;
goto end;
case ACT_RET_ERR:
@ -2869,6 +2876,13 @@ resume_execution:
goto end;
case ACT_RET_YIELD:
s->current_rule = rule;
if (act_opts & ACT_OPT_FINAL) {
send_log(s->be, LOG_WARNING,
"Internal error: action yields while it is no long allowed "
"for the http-response/http-after-response actions.");
rule_ret = HTTP_RULE_RES_ERROR;
goto end;
}
rule_ret = HTTP_RULE_RES_YIELD;
goto end;
case ACT_RET_ERR: