From 617e646ec0140b58353fed5420ad1ef264448899 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 11 Apr 2024 15:03:12 +0200 Subject: [PATCH] BUILD: makefile: make the ERR variable also support 0 It's among the options that change a lot on the developer's side and it's tempting to change from ERR=1 to ERR=0 on the make command line by reusing the history, except it doesn't work. Let's explictily permit ERR=0 to disable -Werror like ERR= does. --- INSTALL | 8 ++++---- Makefile | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/INSTALL b/INSTALL index 2e15c8398..e10822d23 100644 --- a/INSTALL +++ b/INSTALL @@ -662,10 +662,10 @@ It is not wise to disable it on uncommon systems, because it's often the only way to get a usable core when you need one. Otherwise, you can set DEBUG to '-s' to strip the binary. -If the ERR variable is set to any non-empty value, then -Werror will be added -to the compiler so that any build warning will trigger an error. This is the -recommended way to build when developing, and it is expected that contributed -patches were tested with ERR=1. +If the ERR variable is set to any non-empty value other than "0", then -Werror +will be added to the compiler so that any build warning will trigger an error. +This is the recommended way to build when developing, and it is expected that +contributed patches were tested with ERR=1. The DEBUG variable is used to extend the CFLAGS and is preset to a list of build-time options that are known for providing significant reliability diff --git a/Makefile b/Makefile index af4a04a49..8fe5c8e1b 100644 --- a/Makefile +++ b/Makefile @@ -219,7 +219,7 @@ SPEC_CFLAGS += $(call cc-nowarn,cast-function-type) SPEC_CFLAGS += $(call cc-nowarn,string-plus-int) SPEC_CFLAGS += $(call cc-nowarn,atomic-alignment) -ifneq ($(ERR),) +ifneq ($(ERR:0=),) SPEC_CFLAGS += -Werror endif