From a33d39a1b15459ac34b4228b2510eba97a4f0c85 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 25 Mar 2019 18:10:53 +0100 Subject: [PATCH] CLEANUP: task: only perform a LIST_DEL() when the list is not empty In tasklet_free() we unconditionally perform a LIST_DEL() even when the list is empty, let's move the LIST_DEL() inside the matching block. --- include/proto/task.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/proto/task.h b/include/proto/task.h index c876e7320..1f4b52e97 100644 --- a/include/proto/task.h +++ b/include/proto/task.h @@ -380,10 +380,10 @@ static inline void task_free(struct task *t) static inline void tasklet_free(struct tasklet *tl) { if (!LIST_ISEMPTY(&tl->list)) { + LIST_DEL(&tl->list); task_per_thread[tid].task_list_size--; _HA_ATOMIC_SUB(&tasks_run_queue, 1); } - LIST_DEL(&tl->list); pool_free(pool_head_tasklet, tl); if (unlikely(stopping))