127462ca1c
There were several flaws in the way the different timeouts were applied on H1 connections. First, the H1C task handling timeouts was not created if no client/server timeout was specified. But there are other timeouts to consider. First, the client-fin/server-fin timeouts. But for frontend connections, http-keey-alive and http-request timeouts may also be used. And finally, on soft-stop, the close-spread-time value must be considered too. So at the end, it is probably easier to always create a task to manage H1C timeouts. Especially since the client/server timeouts are most often set. Then, when the expiration date of the H1C's task must only be updated if the considered timeout is set. So tick_add_ifset() must be used instead of tick_add(). Otherwise, if a timeout is undefined, the taks may expire immediately while it should in fact never expire. Finally, the idle expiration date must only be considered for idle connections. This patch should be backported in all stable versions, at least as far as 2.6. On the 2.4, it will have to be slightly adapted for the idle_exp part. On 2.2 and 2.0, the patch will have to be rewrite because h1_refresh_timeout() is quite different. (cherry picked from commit 3c09b34325a073e2c110e046f9705b2fddfa91c5) Signed-off-by: Christopher Faulet <cfaulet@haproxy.com> |
||
---|---|---|
.github | ||
addons | ||
admin | ||
dev | ||
doc | ||
examples | ||
include | ||
reg-tests | ||
scripts | ||
src | ||
tests | ||
.cirrus.yml | ||
.gitattributes | ||
.gitignore | ||
.mailmap | ||
.travis.yml | ||
BRANCHES | ||
BSDmakefile | ||
CHANGELOG | ||
CONTRIBUTING | ||
INSTALL | ||
LICENSE | ||
MAINTAINERS | ||
Makefile | ||
README | ||
SUBVERS | ||
VERDATE | ||
VERSION |
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)