5ab8106639
After emitting a HTTP/3 GOAWAY frame, opening of streams higher than advertised ID was prevented. h3_attach operation would return success but without allocating H3S stream context for QCS. In addition, the stream would be immediately scheduled for RESET_STREAM emission. Despite the immediate stream close, the current is not sufficient enough and can cause crashes. When of this occurence can be found if STOP_SENDING is the first frame received for a stream. A crash would occur under qcc_recv_stop_sending() after h3_attach invokation, when h3_close() is used which try to access to H3S context. To fix this, change h3_attach API. In case of success, H3S stream context is always allocated, even if the stream will be scheduled for immediate close. This renders the code more reliable. This crash should be extremely rare, as it can only happen after GOAWAY emission, which is only used on soft-stop or reload. This should solve the second crash occurence reported on GH #2607. This must be backported up to 2.8. (cherry picked from commit 85838822ba37a92b2dcc43205a07c2b33208b985) Signed-off-by: Christopher Faulet <cfaulet@haproxy.com> |
||
|---|---|---|
| .github | ||
| addons | ||
| admin | ||
| dev | ||
| doc | ||
| examples | ||
| include | ||
| reg-tests | ||
| scripts | ||
| src | ||
| tests | ||
| .cirrus.yml | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .travis.yml | ||
| BRANCHES | ||
| BSDmakefile | ||
| CHANGELOG | ||
| CONTRIBUTING | ||
| INSTALL | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| README | ||
| SUBVERS | ||
| VERDATE | ||
| VERSION | ||
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)