From 1dd2ad3469497468ee4f8552c037dc4a0e1bb8b9 Mon Sep 17 00:00:00 2001
From: Gleb Popov <6yearold@gmail.com>
Date: Mon, 14 Oct 2024 11:27:36 +0300
Subject: [PATCH] Reduce copying by taking a QString by reference

---
 src/admc/connection_options_dialog.cpp        | 2 +-
 src/admc/create_dialogs/create_pso_dialog.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/admc/connection_options_dialog.cpp b/src/admc/connection_options_dialog.cpp
index 9d9e28d4..6e189fe5 100644
--- a/src/admc/connection_options_dialog.cpp
+++ b/src/admc/connection_options_dialog.cpp
@@ -172,7 +172,7 @@ void ConnectionOptionsDialog::accept() {
         return;
     }
 
-    for (const QString setting : settings.keys()) {
+    for (const auto& setting : settings.keys()) {
         settings_set_variant(setting, settings.value(setting));
     }
 
diff --git a/src/admc/create_dialogs/create_pso_dialog.cpp b/src/admc/create_dialogs/create_pso_dialog.cpp
index 2f9bd326..c56f4d17 100644
--- a/src/admc/create_dialogs/create_pso_dialog.cpp
+++ b/src/admc/create_dialogs/create_pso_dialog.cpp
@@ -71,7 +71,7 @@ void CreatePSODialog::accept() {
     QHash<QString, QList<QString>> attrs_map = {
         {ATTRIBUTE_OBJECT_CLASS, {CLASS_PSO}},
     };
-    for (const QString attribute : pso_string_settings.keys()) {
+    for (const auto& attribute : pso_string_settings.keys()) {
         attrs_map[attribute] = pso_string_settings[attribute];
     }