add receivers to all lambda slots

not necessary in all cases, but better to do it everywhere
\ than do it sometimes and forget it where it's needed
reduce size of some captures

src/admc/attribute_dialogs/list_attribute_dialog.cpp

@@ -78,6 +78,7 @@ void ListAttributeDialog::on_add_button() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             const QList<QByteArray> new_values = dialog->get_value_list();
 

src/admc/attribute_edits/account_option_edit.cpp

@@ -74,6 +74,7 @@ void account_option_setup_conflicts(const QHash<AccountOption, QCheckBox *> &che
 
         QObject::connect(
             subject, &QCheckBox::clicked,
+            blocker,
             [subject, blocker, subject_option, blocker_option]() {
                 const bool conflict = (subject->isChecked() && blocker->isChecked());
                 if (conflict) {

src/admc/attribute_edits/attribute_edit.cpp

@@ -38,6 +38,7 @@ AttributeEdit::AttributeEdit(QList<AttributeEdit *> *edits_out, QObject *parent)
     m_modified = false;
     connect(
         this, &AttributeEdit::edited,
+        this,
         [this]() {
             m_modified = true;
         });

src/admc/attribute_edits/logon_computers_edit.cpp

@@ -58,6 +58,7 @@ void LogonComputersEdit::open_dialog() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             current_value = dialog->get();
 

src/admc/attribute_edits/logon_hours_edit.cpp

@@ -57,6 +57,7 @@ void LogonHoursEdit::open_dialog() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             current_value = dialog->get();
 

src/admc/attribute_edits/manager_widget.cpp

@@ -77,6 +77,7 @@ void ManagerWidget::on_change() {
 
     connect(
         dialog, &SelectObjectDialog::accepted,
+        this,
         [this, dialog]() {
             const QList<QString> selected = dialog->get_selected();
 

src/admc/attribute_edits/string_other_edit.cpp

@@ -67,6 +67,7 @@ void StringOtherEdit::on_other_button() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             other_values = dialog->get_value_list();
 

src/admc/console_filter_dialog.cpp

@@ -132,6 +132,7 @@ void ConsoleFilterDialog::open_custom_dialog() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             filter_dialog_state = dialog->save_state();
 

src/admc/console_impls/object_impl.cpp

@@ -419,6 +419,7 @@ void ObjectImpl::rename(const QList<QModelIndex> &index_list) {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog, old_dn]() {
             AdInterface ad_inner;
             if (ad_failed(ad_inner, console)) {
@@ -606,6 +607,7 @@ void ObjectImpl::open_console_filter_dialog() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             object_filter = dialog->get_filter();
             object_filter_enabled = dialog->get_filter_enabled();
@@ -651,6 +653,7 @@ void ObjectImpl::on_move() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             AdInterface ad2;
             if (ad_failed(ad2, console)) {
@@ -702,7 +705,8 @@ void ObjectImpl::on_add_to_group() {
 
     connect(
         dialog, &SelectObjectDialog::accepted,
-        [=]() {
+        this,
+        [this, dialog]() {
             AdInterface ad;
             if (ad_failed(ad, console)) {
                 return;
@@ -769,6 +773,7 @@ void ObjectImpl::on_edit_upn_suffixes() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog, partitions_dn]() {
             AdInterface ad_inner;
             if (ad_failed(ad_inner, console)) {
@@ -803,6 +808,7 @@ void ObjectImpl::new_object(CreateObjectDialog *dialog) {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog, parent_dn]() {
             AdInterface ad;
             if (ad_failed(ad, console)) {

src/admc/console_impls/policy_impl.cpp

@@ -164,6 +164,7 @@ void PolicyImpl::rename(const QList<QModelIndex> &index_list) {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, index, dn]() {
             AdInterface ad_inner;
             if (ad_failed(ad_inner, console)) {
@@ -286,7 +287,8 @@ void PolicyImpl::on_add_link() {
 
     connect(
         dialog, &SelectObjectDialog::accepted,
-        [=]() {
+        this,
+        [this, dialog]() {
             const QList<QString> gpos = get_selected_dn_list(console, ItemType_Policy, PolicyRole_DN);
 
             const QList<QString> ou_list = dialog->get_selected();

src/admc/console_impls/policy_root_impl.cpp

@@ -128,6 +128,7 @@ void PolicyRootImpl::create_policy() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             AdInterface ad2;
             if (ad_failed(ad2, console)) {

src/admc/console_impls/query_folder_impl.cpp

@@ -88,6 +88,7 @@ void QueryFolderImpl::on_create_query_folder() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog, parent_index]() {
             const QString name = dialog->name();
             const QString description = dialog->description();
@@ -107,6 +108,7 @@ void QueryFolderImpl::on_create_query_item() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog, parent_index]() {
             const QString name = dialog->name();
             const QString description = dialog->description();
@@ -139,6 +141,7 @@ void QueryFolderImpl::on_edit_query_folder() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog, index]() {
             const QString name = dialog->name();
             const QString description = dialog->description();

src/admc/console_impls/query_item_impl.cpp

@@ -269,6 +269,7 @@ void QueryItemImpl::on_edit_query_item() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog, index]() {
             const QString name = dialog->name();
             const QString description = dialog->description();

src/admc/console_widget/console_widget.cpp

@@ -165,6 +165,7 @@ ConsoleWidget::ConsoleWidget(QWidget *parent)
 
         connect(
             action, &QAction::triggered,
+            this,
             [this, action_enum]() {
                 d->on_standard_action(action_enum);
             });

src/admc/edit_query_item_widget.cpp

@@ -96,6 +96,7 @@ void EditQueryItemWidget::open_filter_dialog() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             filter_dialog_state = dialog->save_state();
 

src/admc/filter_widget/select_base_widget.cpp

@@ -71,6 +71,7 @@ void SelectBaseWidget::open_browse_dialog() {
 
     connect(
         browse_dialog, &QDialog::accepted,
+        this,
         [this, browse_dialog]() {
             const QString selected = browse_dialog->get_selected();
             const QString name = dn_get_name(selected);

src/admc/filter_widget/select_classes_widget.cpp

@@ -76,6 +76,7 @@ void SelectClassesWidget::open_dialog() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             const QList<QString> new_selected_list = dialog->get_selected_classes();
             m_selected_list = new_selected_list;

src/admc/find_widget.cpp

@@ -113,6 +113,7 @@ FindWidget::FindWidget(QWidget *parent)
     // indicator stays on.
     connect(
         this, &QObject::destroyed,
+        this,
         []() {
             hide_busy_indicator();
         });

src/admc/main_window.cpp

@@ -202,6 +202,7 @@ MainWindow::MainWindow(AdInterface &ad, QWidget *parent)
 
         connect(
             action, &QAction::triggered,
+            this,
             [this, language](bool checked) {
                 if (checked) {
                     settings_set_variant(SETTING_locale, QLocale(language));
@@ -272,6 +273,7 @@ MainWindow::MainWindow(AdInterface &ad, QWidget *parent)
 
         connect(
             action, &QAction::toggled,
+            this,
             [setting](bool checked) {
                 settings_set_bool(setting, checked);
             });
@@ -292,6 +294,7 @@ MainWindow::MainWindow(AdInterface &ad, QWidget *parent)
 
         connect(
             action, &QAction::toggled,
+            this,
             [setting, object_impl](bool checked) {
                 settings_set_bool(setting, checked);
 

src/admc/policy_results_widget.cpp

@@ -152,6 +152,7 @@ void PolicyResultsWidget::update(const QString &new_gpo) {
 
         connect(
             sync_warning_dialog, &QDialog::accepted,
+            this,
             [this]() {
                 AdInterface ad_inner;
                 if (ad_failed(ad_inner, this)) {

src/admc/properties_dialog.cpp

@@ -95,6 +95,7 @@ PropertiesDialog *PropertiesDialog::open_for_target(AdInterface &ad, const QStri
 void PropertiesDialog::open_when_view_item_activated(QAbstractItemView *view, const int dn_role) {
     connect(
         view, &QAbstractItemView::doubleClicked,
+        view,
         [view, dn_role](const QModelIndex &index) {
             AdInterface ad;
             if (ad_failed(ad, view)) {
@@ -270,6 +271,7 @@ void PropertiesDialog::on_current_tab_changed(QWidget *prev_tab, QWidget *new_ta
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this]() {
             AdInterface ad;
             if (ad_failed(ad, this)) {
@@ -285,9 +287,7 @@ void PropertiesDialog::on_current_tab_changed(QWidget *prev_tab, QWidget *new_ta
 
     connect(
         dialog, &QDialog::rejected,
-        [this]() {
-            reset();
-        });
+        this, &PropertiesDialog::reset);
 }
 
 void PropertiesDialog::accept() {

src/admc/select_object_dialog.cpp

@@ -156,6 +156,7 @@ void SelectObjectDialog::on_add_button() {
 
         connect(
             dialog, &QDialog::accepted,
+            this,
             [this, dialog]() {
                 const QList<QString> selected_matches = dialog->get_selected();
 
@@ -181,6 +182,7 @@ void SelectObjectDialog::open_advanced_dialog() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             const QList<QString> selected = dialog->get_selected_dns();
 

src/admc/settings.cpp

@@ -70,7 +70,8 @@ void settings_setup_dialog_geometry(const QString setting, QDialog *dialog) {
 
     QObject::connect(
         dialog, &QDialog::finished,
-        [=]() {
+        dialog,
+        [setting, dialog]() {
             const QByteArray geometry = dialog->saveGeometry();
             settings_set_variant(setting, geometry);
         });

src/admc/tabs/attributes_tab.cpp

@@ -184,6 +184,7 @@ void AttributesTab::edit_attribute() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             const QList<QStandardItem *> row = get_selected_row();
 

src/admc/tabs/group_policy_tab.cpp

@@ -171,6 +171,7 @@ void GroupPolicyTab::on_add_button() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             const QList<QString> selected = dialog->get_selected_dns();
 

src/admc/tabs/membership_tab.cpp

@@ -318,6 +318,7 @@ void MembershipTab::on_add_button() {
 
     connect(
         dialog, &SelectObjectDialog::accepted,
+        this,
         [this, dialog]() {
             const QList<QString> selected = dialog->get_selected();
 

src/admc/tabs/security_tab.cpp

@@ -309,7 +309,8 @@ void SecurityTab::on_add_trustee_button() {
 
     connect(
         dialog, &SelectObjectDialog::accepted,
-        [=]() {
+        this,
+        [this, dialog]() {
             AdInterface ad;
             if (ad_failed(ad, this)) {
                 return;
@@ -442,6 +443,7 @@ void SecurityTab::on_add_well_known_trustee() {
 
     connect(
         dialog, &QDialog::accepted,
+        this,
         [this, dialog]() {
             AdInterface ad;
             if (ad_failed(ad, this)) {

tests/admc_test_account_option_edit.cpp

@@ -66,6 +66,7 @@ void ADMCTestAccountOptionEdit::test_emit_edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_country_edit.cpp

@@ -55,6 +55,7 @@ void ADMCTestCountryEdit::emit_edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_delegation_edit.cpp

@@ -60,6 +60,7 @@ void ADMCTestDelegationEdit::emit_edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_expiry_edit.cpp

@@ -66,6 +66,7 @@ void ADMCTestExpiryEdit::edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_group_scope_edit.cpp

@@ -42,6 +42,7 @@ void ADMCTestGroupScopeEdit::edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_group_type_edit.cpp

@@ -42,6 +42,7 @@ void ADMCTestGroupTypeEdit::edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_logon_computers_edit.cpp

@@ -69,6 +69,7 @@ void ADMCTestLogonComputersEdit::emit_edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_password_edit.cpp

@@ -48,6 +48,7 @@ void ADMCTestPasswordEdit::edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_protect_deletion_edit.cpp

@@ -48,6 +48,7 @@ void ADMCTestProtectDeletionEdit::emit_edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_string_edit.cpp

@@ -46,6 +46,7 @@ void ADMCTestStringEdit::test_emit_edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_string_large_edit.cpp

@@ -46,6 +46,7 @@ void ADMCTestStringLargeEdit::test_emit_edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_string_other_edit.cpp

@@ -71,6 +71,7 @@ void ADMCTestStringOtherEdit::test_emit_edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_unlock_edit.cpp

@@ -50,6 +50,7 @@ void ADMCTestUnlockEdit::test_emit_edited_signal() {
     bool edited_signal_emitted = false;
     connect(
         unlock_edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });

tests/admc_test_upn_edit.cpp

@@ -65,6 +65,7 @@ void ADMCTestUpnEdit::test_emit_edited() {
     bool edited_signal_emitted = false;
     connect(
         upn_edit, &AttributeEdit::edited,
+        this,
         [&edited_signal_emitted]() {
             edited_signal_emitted = true;
         });