add string other edit tests

.gear/admc.spec

@@ -91,6 +91,7 @@ Tests for ADMC
 %_bindir/admc_test_datetime_edit
 %_bindir/admc_test_manager_edit
 %_bindir/admc_test_delegation_edit
+%_bindir/admc_test_string_other_edit
 %_bindir/admc_test_octet_editor
 %_bindir/admc_test_bool_editor
 %_bindir/admc_test_string_editor

tests/CMakeLists.txt

@@ -55,6 +55,7 @@ set(TEST_TARGETS
     admc_test_datetime_edit
     admc_test_manager_edit
     admc_test_delegation_edit
+    admc_test_string_other_edit
     admc_test_octet_editor
     admc_test_bool_editor
     admc_test_datetime_editor

tests/admc_test_string_other_edit.cpp

@@ -0,0 +1,180 @@
+/*
+ * ADMC - AD Management Center
+ *
+ * Copyright (C) 2020-2021 BaseALT Ltd.
+ * Copyright (C) 2020-2021 Dmitry Degtyarev
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "admc_test_string_other_edit.h"
+
+#include "edits/string_other_edit.h"
+#include "editors/multi_editor.h"
+#include "editors/string_editor.h"
+
+#include <QFormLayout>
+#include <QLineEdit>
+#include <QListWidget>
+#include <QPushButton>
+
+#define TEST_ATTRIBUTE_MAIN ATTRIBUTE_WWW_HOMEPAGE
+#define TEST_ATTRIBUTE_OTHER ATTRIBUTE_WWW_HOMEPAGE_OTHER
+
+const QString main_value = "main_value";
+const QList<QByteArray> other_value_list = {
+    "first",
+    "second",
+    "third",
+};
+
+#define new_value "new_value"
+
+void ADMCTestStringOtherEdit::init() {
+    ADMCTest::init();
+
+    edit = new StringOtherEdit(TEST_ATTRIBUTE_MAIN, ATTRIBUTE_WWW_HOMEPAGE_OTHER, CLASS_USER, &edits, parent_widget);
+    add_attribute_edit(edit);
+
+    line_edit = parent_widget->findChild<QLineEdit *>();
+    QVERIFY(line_edit != nullptr);
+
+    other_button = parent_widget->findChild<QPushButton *>();
+    QVERIFY(other_button != nullptr);
+
+    // Create test user
+    const QString name = TEST_USER;
+    dn = test_object_dn(name, CLASS_USER);
+    const bool create_success = ad.object_add(dn, CLASS_USER);
+    QVERIFY(create_success);
+
+    // Set values
+    ad.attribute_replace_string(dn, TEST_ATTRIBUTE_MAIN, main_value);
+    ad.attribute_replace_values(dn, TEST_ATTRIBUTE_OTHER, other_value_list);
+
+    // Load user into edit
+    const AdObject object = ad.search_object(dn);
+    edit->load(ad, object);
+}
+
+// edited() signal should be emitted when lineedit is edited
+// and when other values are added
+void ADMCTestStringOtherEdit::test_emit_edited_signal() {
+    bool edited_signal_emitted = false;
+    connect(
+        edit, &AttributeEdit::edited,
+        [&edited_signal_emitted]() {
+            edited_signal_emitted = true;
+        });
+
+    line_edit->setText("test");
+    QVERIFY(edited_signal_emitted);
+
+    edited_signal_emitted = false;
+
+    add_new_other_value();
+
+    QVERIFY(edited_signal_emitted);
+}
+
+// Edit should contain current attribute value after load()
+// call
+void ADMCTestStringOtherEdit::load() {
+    QVERIFY(line_edit->text() == main_value);
+
+    other_button->click();
+
+    auto multi_editor = parent_widget->findChild<MultiEditor *>();
+    QVERIFY(multi_editor != nullptr);
+
+    auto list_widget = multi_editor->findChild<QListWidget *>();
+    QVERIFY(list_widget != nullptr);
+
+    QVERIFY(line_edit->text() == main_value);
+    for (int i = 0; i < 3; i++) {
+        QVERIFY(list_widget->item(i)->text() == other_value_list[i]);
+    }
+}
+
+// Edit should do nothing if value wasn't modified
+void ADMCTestStringOtherEdit::apply_unmodified() {
+    const AdObject object_before_apply = ad.search_object(dn);
+
+    const bool apply_success = edit->apply(ad, dn);
+    QVERIFY(apply_success);
+
+    const AdObject object_after_apply = ad.search_object(dn);
+
+    QVERIFY(object_before_apply.get_attributes_data() == object_after_apply.get_attributes_data());
+}
+
+void ADMCTestStringOtherEdit::apply_modified_main_value() {
+    line_edit->setText(new_value);
+
+    const bool apply_success = edit->apply(ad, dn);
+    QVERIFY(apply_success);
+
+    const AdObject object = ad.search_object(dn);
+    const QString current_value_main = object.get_string(TEST_ATTRIBUTE_MAIN);
+
+    QVERIFY(current_value_main == new_value);
+
+    const QList<QByteArray> current_value_other = object.get_values(TEST_ATTRIBUTE_OTHER);
+
+    QVERIFY(current_value_other == other_value_list);
+}
+
+void ADMCTestStringOtherEdit::apply_modified_other_value() {
+    add_new_other_value();
+
+    const bool apply_success = edit->apply(ad, dn);
+    QVERIFY(apply_success);
+
+    const AdObject object = ad.search_object(dn);
+    const QString current_value_main = object.get_string(TEST_ATTRIBUTE_MAIN);
+
+    QVERIFY(current_value_main == main_value);
+
+    const QList<QByteArray> current_value_other = object.get_values(TEST_ATTRIBUTE_OTHER);
+    QList<QByteArray> correct_value_other = other_value_list; 
+    correct_value_other.append(new_value);
+
+    QVERIFY(current_value_other == correct_value_other);
+}
+
+void ADMCTestStringOtherEdit::add_new_other_value() {
+    other_button->click();
+
+    auto multi_editor = parent_widget->findChild<MultiEditor *>();
+    QVERIFY(multi_editor != nullptr);
+
+    auto add_button = multi_editor->findChild<QPushButton *>();
+    QVERIFY(add_button != nullptr);
+
+    add_button->click();
+
+    auto string_editor = multi_editor->findChild<StringEditor *>();
+    QVERIFY(string_editor != nullptr);
+
+    auto string_editor_line_edit = string_editor->findChild<QLineEdit *>();
+    QVERIFY(string_editor_line_edit != nullptr);
+
+    string_editor_line_edit->setText(new_value);
+
+    string_editor->accept();
+
+    multi_editor->accept();
+}
+
+QTEST_MAIN(ADMCTestStringOtherEdit)

tests/admc_test_string_other_edit.h

@@ -0,0 +1,51 @@
+/*
+ * ADMC - AD Management Center
+ *
+ * Copyright (C) 2020-2021 BaseALT Ltd.
+ * Copyright (C) 2020-2021 Dmitry Degtyarev
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef ADMC_TEST_STRING_OTHER_EDIT_H
+#define ADMC_TEST_STRING_OTHER_EDIT_H
+
+#include "admc_test.h"
+
+class StringOtherEdit;
+class QLineEdit;
+class QPushButton;
+
+class ADMCTestStringOtherEdit : public ADMCTest {
+    Q_OBJECT
+
+private slots:
+    void init() override;
+
+    void test_emit_edited_signal();
+    void load();
+    void apply_unmodified();
+    void apply_modified_main_value();
+    void apply_modified_other_value();
+
+private:
+    StringOtherEdit *edit;
+    QLineEdit *line_edit;
+    QPushButton *other_button;
+    QString dn;
+
+    void add_new_other_value();
+};
+
+#endif /* ADMC_TEST_STRING_OTHER_EDIT_H */