public/admc
1
0
Fork 0
mirror of https://github.com/altlinux/admc.git synced 2025-03-17 02:50:12 +03:00
Code Issues Projects Releases Wiki Activity

don't add duplicate links in gplink::add()

Browse Source
This commit is contained in:
Dmitry Degtyarev 2021-04-07 13:37:14 +04:00
parent 0590c92c1e
commit a0c4f48abd
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/admc/gplink.cpp
View File

@ -82,7 +82,12 @@ QList<QString> Gplink::get_gpos() const {
void Gplink::add(const QString &gpo_case) {
const QString gpo = gpo_case.toLower();
const bool gpo_already_in_link = gpo_case_map.contains(gpo);
if (gpo_already_in_link) {
return;
}
gpos_in_order.append(gpo);
options[gpo] = 0;
gpo_case_map[gpo] = gpo_case;

6
tests/admc_test_gplink.cpp
View File

@ -60,9 +60,15 @@ void ADMCTestGplink::test_add() {
const QString gplink_string = "[LDAP://a;0][LDAP://b;0][LDAP://c;0][LDAP://UPPER;0]";
Gplink gplink(gplink_string);
// Simple add
gplink.add("added gpo");
// Test that case is preserved
gplink.add("added gpo UPPERCASE");
// Test that duplicates are ignored
gplink.add("a");
const QString correct_gplink_string = "[LDAP://a;0][LDAP://b;0][LDAP://c;0][LDAP://UPPER;0][LDAP://added gpo;0][LDAP://added gpo UPPERCASE;0]";
test_gplink_equality(gplink, correct_gplink_string);