1
0
mirror of https://github.com/ansible/awx.git synced 2024-11-02 09:51:09 +03:00

Inventory file suggestion adjustments from user feedback

- ditch yaml files as suggestions
 - automatically greenlight any hosts or inventory titled file
This commit is contained in:
AlanCoding 2017-09-18 14:28:29 -04:00
parent 50d6981695
commit 120b5297e3
No known key found for this signature in database
GPG Key ID: FD2C3C012A72926B

View File

@ -61,10 +61,14 @@ def could_be_playbook(project_path, dir_path, filename):
def could_be_inventory(project_path, dir_path, filename):
# Decisions based exclusively on filename
inventory_path = os.path.join(dir_path, filename)
inventory_rel_path = os.path.relpath(inventory_path, smart_str(project_path))
suspected_ext = os.path.splitext(filename)[-1]
if suspected_ext in ['.yml', '.yaml', '.ini'] or os.access(inventory_path, os.X_OK):
if filename in ['inventory', 'hosts']:
# Users commonly name their inventory files these names
return inventory_rel_path
elif suspected_ext == '.ini' or os.access(inventory_path, os.X_OK):
# Files with any of these extensions are always included
return os.path.relpath(inventory_path, smart_str(project_path))
return inventory_rel_path
elif '.' in suspected_ext:
# If not using those extensions, inventory must have _no_ extension
return None
@ -79,4 +83,4 @@ def could_be_inventory(project_path, dir_path, filename):
return None
except IOError:
return None
return os.path.relpath(inventory_path, smart_str(project_path))
return inventory_rel_path