Merge pull request #1534 from chrismeyersfsu/fix-config_performance

fixes config endpoint performance issue

awx/main/tests/unit/settings/test_development.py

@@ -0,0 +1,5 @@
+
+def test_ANSIBLE_VERSION(mocker):
+    from django.conf import settings
+    assert hasattr(settings, 'ANSIBLE_VERSION')
+

awx/main/tests/unit/test_utils.py

@@ -0,0 +1,19 @@
+import subprocess
+
+from awx.main.utils import get_ansible_version
+
+def test_dev(mocker, settings):
+    settings.ANSIBLE_VERSION = mocker.Mock()
+
+    res = get_ansible_version()
+
+    assert res == settings.ANSIBLE_VERSION
+
+def test_production(mocker, settings):
+    mock_Popen = mocker.MagicMock()
+    mocker.patch.object(subprocess, 'Popen', mock_Popen)
+    del settings.ANSIBLE_VERSION
+
+    get_ansible_version()
+
+    mock_Popen.assert_called_with(['ansible', '--version'], stdout=subprocess.PIPE)

awx/main/utils.py

@@ -97,6 +97,9 @@ def get_ansible_version():
     '''
     Return Ansible version installed.
     '''
+    from django.conf import settings
+    if hasattr(settings, 'ANSIBLE_VERSION'):
+        return settings.ANSIBLE_VERSION
     try:
         proc = subprocess.Popen(['ansible', '--version'],
                                 stdout=subprocess.PIPE)

awx/settings/development.py

@@ -10,6 +10,8 @@ import traceback
 # Django Split Settings
 from split_settings.tools import optional, include
 
+from awx.main.utils import get_ansible_version
+
 # Load default settings.
 from defaults import *  # NOQA
 
@@ -33,6 +35,8 @@ AWX_PROOT_ENABLED = True
 
 PENDO_TRACKING_STATE = "off"
 
+ANSIBLE_VERSION = get_ansible_version()
+
 # Use Django-Jenkins if installed. Only run tests for awx.main app.
 try:
     import django_jenkins