shaba/awx
1
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2024-11-01 16:51:11 +03:00
Code Releases Activity

Fix an issue where a well timed cancel could try to cancel a job right

Browse Source 
after it has finished causing an error.
This commit is contained in:
Matthew Jones 2015-05-18 10:18:36 -04:00
parent d46d9bb7f4
commit 472f086862
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
awx/main/tasks.py
View File

@ -393,11 +393,12 @@ class BaseTask(Task):
# Refresh model instance from the database (to check cancel flag). # Refresh model instance from the database (to check cancel flag).
instance = self.update_model(instance.pk) instance = self.update_model(instance.pk)
if instance.cancel_flag: if instance.cancel_flag:
try:
os.kill(child.pid, signal.SIGINT) os.kill(child.pid, signal.SIGINT)
time.sleep(3) time.sleep(3)
# The following line causes orphaned ansible processes
# child.terminate(canceled)
canceled = True canceled = True
except OSError:
logger.warn("Attempted to cancel already finished job, ignoring")
if idle_timeout and (time.time() - last_stdout_update) > idle_timeout: if idle_timeout and (time.time() - last_stdout_update) > idle_timeout:
child.close(True) child.close(True)
canceled = True canceled = True