shaba/awx
1
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2024-11-02 09:51:09 +03:00
Code Releases Activity

Only assign name property if response has value

Browse Source
This commit is contained in:
Joe Fiorini 2015-08-13 11:14:56 -04:00
parent ac232fcff0
commit a171bd7cee
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
awx/ui/client/src/shared/directives.js
View File

@ -413,7 +413,22 @@ angular.module('AWDirectives', ['RestServices', 'Utilities', 'AuthService', 'Job
var results = data.data.results; var results = data.data.results;
if (results.length > 0) { if (results.length > 0) {
scope[elm.attr('data-source')] = results[0].id; scope[elm.attr('data-source')] = results[0].id;
// For user lookups the API endpoint doesn't
// have a `name` property, so this is `undefined`
// which causes the input to clear after typing
// a valid value O_o
//
// Only assign if there is a value, so that we avoid
// this situation.
//
// TODO: Evaluate if assigning name on the scope is
// even necessary at all.
//
if (!_.isEmpty(results[0].name)) {
scope[elm.attr('name')] = results[0].name; scope[elm.attr('name')] = results[0].name;
}
ctrl.$setValidity('required', true); ctrl.$setValidity('required', true);
ctrl.$setValidity('awlookup', true); ctrl.$setValidity('awlookup', true);
return viewValue; return viewValue;