Merge pull request #3665 from cchurch/prevent-removing-license-via-system-settings

Prevent removing license via settings

awx/conf/views.py

@@ -97,6 +97,8 @@ class SettingSingletonDetail(RetrieveUpdateDestroyAPIView):
         settings_qs = self.get_queryset()
         user = self.request.user if self.category_slug == 'user' else None
         for key, value in serializer.validated_data.items():
+            if key == 'LICENSE':
+                continue
             setattr(serializer.instance, key, value)
             # Always encode "raw" strings as JSON.
             if isinstance(value, basestring):
@@ -114,7 +116,7 @@ class SettingSingletonDetail(RetrieveUpdateDestroyAPIView):
         return Response(status=status.HTTP_204_NO_CONTENT)
 
     def perform_destroy(self, instance):
-        for setting in self.get_queryset():
+        for setting in self.get_queryset().exclude(key='LICENSE'):
             setting.delete()
 
 

awx/main/tests/conftest.py

@@ -1,5 +1,6 @@
 
 # Python
+import time
 import pytest
 
 from awx.main.tests.factories import (
@@ -52,3 +53,15 @@ def get_ssh_version(mocker):
 @pytest.fixture
 def job_template_with_survey_passwords_unit(job_template_with_survey_passwords_factory):
     return job_template_with_survey_passwords_factory(persisted=False)
+
+@pytest.fixture
+def enterprise_license():
+    from awx.main.task_engine import TaskEnhancer
+    return TaskEnhancer(
+        company_name='AWX',
+        contact_name='AWX Admin',
+        contact_email='awx@example.com',
+        license_date=int(time.time() + 3600),
+        instance_count=10000,
+        license_type='enterprise',
+    ).enhance()

awx/main/tests/functional/api/test_settings.py

@@ -0,0 +1,31 @@
+# Copyright (c) 2016 Ansible, Inc.
+# All Rights Reserved.
+
+# Python
+import pytest
+import mock
+
+# Django
+from django.core.urlresolvers import reverse
+
+# AWX
+from awx.conf.models import Setting
+
+
+@pytest.mark.django_db
+def test_license_cannot_be_removed_via_system_settings(get, put, patch, delete, admin, enterprise_license):
+    url = reverse('api:setting_singleton_detail', args=('system',))
+    response = get(url, user=admin, expect=200)
+    assert not response.data['LICENSE']
+    Setting.objects.create(key='LICENSE', value=enterprise_license)
+    response = get(url, user=admin, expect=200)
+    assert response.data['LICENSE']
+    put(url, user=admin, data=response.data, expect=200)
+    response = get(url, user=admin, expect=200)
+    assert response.data['LICENSE']
+    patch(url, user=admin, data={}, expect=200)
+    response = get(url, user=admin, expect=200)
+    assert response.data['LICENSE']
+    delete(url, user=admin, expect=204)
+    response = get(url, user=admin, expect=200)
+    assert response.data['LICENSE']