shaba/awx
1
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2024-11-01 16:51:11 +03:00
Code Releases Activity

Mitigated race condition issues with limit-panel directive by removing dependency on the state transition event

Browse Source
This commit is contained in:
mabashian 2018-05-14 14:28:52 -04:00
parent a74b8fa744
commit ef514fb3c0
1 changed files with 21 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
awx/ui/client/src/shared/limit-panels/limit-panels.directive.js
View File

@ -1,4 +1,4 @@
export default ['$rootScope', '$transitions', function($rootScope, $transitions) { export default [function() {
return { return {
restrict: 'E', restrict: 'E',
scope: { scope: {
@ -7,27 +7,28 @@ export default ['$rootScope', '$transitions', function($rootScope, $transitions)
}, },
link: function(scope) { link: function(scope) {
scope.maxPanels = parseInt(scope.maxPanels); const maxPanels = parseInt(scope.maxPanels);
$transitions.onSuccess({}, function() { scope.$watch(
let panels = angular.element('#' + scope.panelContainer).find('.Panel'); () => angular.element('#' + scope.panelContainer).find('.Panel').length,
() => {
if(panels.length > scope.maxPanels) { const panels = angular.element('#' + scope.panelContainer).find('.Panel');
// hide the excess panels if(panels.length > maxPanels) {
$(panels).each(function( index ) { // hide the excess panels
if(index+1 > scope.maxPanels) { $(panels).each(function( index ) {
$(this).addClass('Panel-hidden'); if(index+1 > maxPanels) {
} $(this).addClass('Panel-hidden');
else { }
$(this).removeClass('Panel-hidden'); else {
} $(this).removeClass('Panel-hidden');
}); }
});
} else {
// show all the panels
$(panels).removeClass('Panel-hidden');
}
} }
else { );
// show all the panels
$(panels).removeClass('Panel-hidden');
}
});
} }
}; };
}]; }];