mirror of
https://github.com/ansible/awx.git
synced 2024-10-31 23:51:09 +03:00
Ensure hosts list properly when given read access to a smart inventory
This commit is contained in:
parent
53581b1c5b
commit
fe36ed94b8
@ -1959,6 +1959,13 @@ class InventoryHostsList(SubListCreateAttachDetachAPIView):
|
||||
parent_key = 'inventory'
|
||||
capabilities_prefetch = ['inventory.admin']
|
||||
|
||||
def get_queryset(self):
|
||||
inventory = self.get_parent_object()
|
||||
if inventory.kind == 'smart':
|
||||
filter_qs = SmartFilter.query_from_string(inventory.host_filter)
|
||||
return filter_qs.distinct()
|
||||
return super(InventoryHostsList, self).get_queryset()
|
||||
|
||||
|
||||
class HostGroupsList(ControlledByScmMixin, SubListCreateAttachDetachAPIView):
|
||||
''' the list of groups a host is directly a member of '''
|
||||
|
@ -9,6 +9,7 @@ from awx.api.views import (
|
||||
JobTemplateLabelList,
|
||||
JobTemplateSurveySpec,
|
||||
InventoryInventorySourcesUpdate,
|
||||
InventoryHostsList,
|
||||
HostInsights,
|
||||
)
|
||||
|
||||
@ -204,3 +205,15 @@ class TestHostInsights():
|
||||
|
||||
assert resp.data['error'] == 'The Insights Credential for "inventory_name_here" was not found.'
|
||||
assert resp.status_code == 404
|
||||
|
||||
|
||||
class TestInventoryHostsList(object):
|
||||
|
||||
def test_host_list_smart_inventory(self, mocker):
|
||||
Inventory = namedtuple('Inventory', ['kind', 'host_filter'])
|
||||
obj = Inventory(kind='smart', host_filter='localhost')
|
||||
with mock.patch.object(InventoryHostsList, 'get_parent_object', return_value=obj):
|
||||
with mock.patch('awx.api.views.SmartFilter.query_from_string') as mock_query:
|
||||
view = InventoryHostsList()
|
||||
view.get_queryset()
|
||||
mock_query.assert_called_once_with('localhost')
|
||||
|
Loading…
Reference in New Issue
Block a user