softwarefactory-project-zuul[bot]
b53621e74c
Merge pull request #3152 from ryanpetrello/jsonb_prevent_field_lookups
...
prevent field lookups on Host.ansible_facts keys (it doesn't work)
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-02-05 17:24:06 +00:00
Elyézer Rezende
925c6543c4
Add users CRUD e2e tests
2019-02-05 14:59:59 -02:00
Ryan Petrello
bb5312f4fc
prevent field lookups on Host.ansible_facts keys (it doesn't work)
...
under the hood, Host.ansible_facts is a postgres jsonb field which
performs match operations using the JSON containment operator (@>)
this operator _only_ works on exact matches on containment (i.e.,
"does the `ansible_distribution` jsonb value contain _this exact_ JSON
structure"):
SELECT ...
FROM main_host
WHERE ansible_facts @> '{"ansible_distribution": "centos"}'
SELECT ...
FROM main_host
WHERE ansible_facts @> '{"packages": {"dnsmasq": [{"version": 2}]}}'
postgres does _not_ expose any operator for fuzzy or lookup-based
matches with this operator, so host filter values like these don't
really make sense (postgres can't _filter_ in the way intended in these
examples):
ansible_distribution__startswith=\"Cent\"
ansible_distribution__icontains=\"CentOS\"
ansible_facts__packages__dnsmasq[]__version__startswith=\"2\"
2019-02-05 10:43:51 -05:00
softwarefactory-project-zuul[bot]
7333e55748
Merge pull request #3156 from Spredzy/schedule_max_jobs_conditiion
...
jt, wfjt: Ensure SCHEDULE_MAX_JOBS is accurately respect
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-02-05 13:35:35 +00:00
Yanis Guenane
5e20dcb6ca
jt, wfjt: Ensure SCHEDULE_MAX_JOBS is accurately respect
...
Currently SCHEDULE_MAX_JOBS+1 can be scheduled rather than
SCHEDULE_MAX_JOBS. This is due to the fact that we using strictly
greater rather than greater or equal.
Imagine we set SCHEDULE_MAX_JOBS=1, current logic:
* First time (count = 0), count < 1 -> proceed
* Second time (count = 1), count =< 1 -> proceed
* Third time (count = 2), count > 1 -> prevented
Imagine we set SCHEDULE_MAX_JOBS=1, new logic:
* First time (count = 0), count < 1 -> proceed
* Second time (count = 1), count =< 1 -> prevented
Signed-off-by: Yanis Guenane <yguenane@redhat.com>
2019-02-05 13:44:39 +01:00
softwarefactory-project-zuul[bot]
cab6b8b333
Merge pull request #3147 from jbradberry/become_method_list
...
Expose the known privilege escalation methods in the API config view
Reviewed-by: Ryan Petrello
https://github.com/ryanpetrello
2019-02-04 17:12:28 +00:00
Jeff Bradberry
46020379aa
Expose the known privilege escalation methods in the API config view
...
so that the UI can obtain them and make use of them for an autocomplete widget.
2019-02-04 11:45:27 -05:00
softwarefactory-project-zuul[bot]
e23fb31a4a
Merge pull request #3140 from AlanCoding/isolate_venv
...
Use custom venv in inventory proot-ing
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-02-02 12:17:25 +00:00
Marliana Lara
17c95f200a
Merge pull request #3136 from marshmalien/fix-inv-host-tab
...
Disable hosts toggle in smart inventory hosts tab
2019-02-01 16:36:02 -05:00
AlanCoding
7676ccdbac
use custom venv in inventory prooting
2019-02-01 13:29:45 -05:00
softwarefactory-project-zuul[bot]
4626aa0144
Merge pull request #3093 from jbradberry/become_plugins
...
Support become plugins
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-02-01 17:48:09 +00:00
Marliana Lara
fb7596929f
Disable hosts toggle in smart inventory hosts tab
2019-02-01 11:28:00 -05:00
softwarefactory-project-zuul[bot]
d63518d789
Merge pull request #3005 from b0urn3/devel
...
Add SCHEDULE_MAX_JOBS implementation for WFJTs for #2975
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-02-01 13:54:21 +00:00
Robert Zahradníček
6f1cbac324
Add SCHEDULE_MAX_JOBS implementation for WFJTs for #2975
2019-01-31 21:52:36 +01:00
softwarefactory-project-zuul[bot]
2b80f0f7b6
Merge pull request #3121 from ryanpetrello/busted-isolated
...
properly detect ansible-playbook vs ansible runs in bwrap arg building
Reviewed-by: Elijah DeLee <kdelee@redhat.com>
https://github.com/kdelee
2019-01-31 16:27:06 +00:00
Ryan Petrello
10945faba1
properly detect ansible-playbook vs ansible runs in bwrap arg building
...
a recent change (65641c7
2019-01-31 11:06:50 -05:00
softwarefactory-project-zuul[bot]
d4ccb00338
Merge pull request #3118 from ryanpetrello/fix-3108
...
work around a bug in Django that breaks the stdout HTML view in py3
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-31 14:43:42 +00:00
Ryan Petrello
d10d5f1539
work around a bug in Django that breaks the stdout HTML view in py3
...
see: https://github.com/ansible/awx/issues/3108
2019-01-31 01:01:40 -05:00
Hideki Saito
3e5f328b52
Fix chrome can not be started with unit-tests due to missing shared libraries
...
- Added installation packages conforming to the unit-tests/Dockerfile
Signed-off-by: Hideki Saito <saito@fgrep.org>
2019-01-31 13:02:23 +09:00
Hideki Saito
d558ffd699
Fix chrome can not be started with unit-tests due to missing shared libraries
...
- Modify Dockerfile to install necesarry shared libraries for chrome
Signed-off-by: Hideki Saito <saito@fgrep.org>
2019-01-31 09:54:55 +09:00
softwarefactory-project-zuul[bot]
b64d401e74
Merge pull request #3086 from kialam/fix-3081-duplicate-template-expanded
...
Fix expanded view not persisting when a user copies a JT/WF.
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-30 18:46:24 +00:00
softwarefactory-project-zuul[bot]
0a3f131adc
Merge pull request #3100 from ryanpetrello/die_settings_migration_die
...
remove awx-manage migrate_to_database_settings
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-30 18:33:14 +00:00
Kia Lam
6f9cf6a649
Fix expanded view not persisting when a user copies a JT/WF.
2019-01-30 13:23:21 -05:00
softwarefactory-project-zuul[bot]
5db43b8283
Merge pull request #3101 from jakemcdermott/bump-prompt-credential-type-page-size
...
increase request page size for credential types in launch prompts
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-30 18:05:53 +00:00
softwarefactory-project-zuul[bot]
aa9e60c508
Merge pull request #3087 from kialam/fix-3082-sidenav-on-resize
...
Some sidebar nav fixes.
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-30 17:40:46 +00:00
softwarefactory-project-zuul[bot]
2162e8e0cc
Merge pull request #3109 from ryanpetrello/overindent
...
fix overindent lint failures
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-30 17:36:52 +00:00
Ryan Petrello
1eeffe4ae2
remove awx-manage migrate_to_database_settings
2019-01-30 12:23:36 -05:00
Ryan Petrello
2927803a82
fix overindent lint failures
2019-01-30 12:12:39 -05:00
Jake McDermott
1b50b26901
support up to 200 credential types in launch prompts
2019-01-29 20:10:13 -05:00
softwarefactory-project-zuul[bot]
44819987f7
Merge pull request #3097 from ansible/jakemcdermott-sanitize-jdetails
...
sanitize reflected user input on job details page
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-29 21:34:32 +00:00
softwarefactory-project-zuul[bot]
9bf0d052ab
Merge pull request #3089 from marshmalien/2330-execution-node
...
Add execution node field to job details panel
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-29 21:17:37 +00:00
Marliana Lara
5c98d04e09
Update execution node field from job status subscriber
2019-01-29 15:48:18 -05:00
Jeff Bradberry
6560ab0fab
Migrated the inputs schema on existing CredentialTypes
...
to convert the custom become_method into a plain string.
related #2630
Signed-off-by: Jeff Bradberry <jeff.bradberry@gmail.com>
2019-01-29 15:04:35 -05:00
softwarefactory-project-zuul[bot]
efb7a729c7
Merge pull request #3091 from beeankha/dupe_logout_msg
...
Remove error message for regular logout
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-29 19:51:52 +00:00
Jeff Bradberry
6e1deed79e
Removed the special-case logic for maintaining the schema of the become_method field
...
related #2630
Signed-off-by: Jeff Bradberry <jeff.bradberry@gmail.com>
2019-01-29 14:06:26 -05:00
beeankha
ad3721bdb2
Ensure all other error messages don't double up with the logout message
2019-01-29 13:09:28 -05:00
Jake McDermott
ca64630740
sanitize reflected user input on job details page
...
This makes sure we're applying the 'sanitize' filter to reflected user input for some of the new information we're displaying on the job details page.
2019-01-29 09:35:57 -05:00
softwarefactory-project-zuul[bot]
8686575311
Merge pull request #3092 from ansible/jakemcdermott-patch-1
...
Install dependencies for Chromium in unit test image
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-28 22:26:59 +00:00
Jeff Bradberry
0ecd6542bf
Changed the become_method field into one that takes arbitrary input
...
related #2630
Signed-off-by: Jeff Bradberry <jeff.bradberry@gmail.com>
2019-01-28 16:53:54 -05:00
beeankha
5e3d47683d
Ensure error messages are showing up, but not doubled
2019-01-28 16:12:20 -05:00
Jake McDermott
73f617d811
Install dependencies for Chromium in unit test image
2019-01-28 15:57:17 -05:00
beeankha
ea7e15bfc4
Remove error message for regular logout
2019-01-28 15:16:28 -05:00
Marliana Lara
eca530c788
Add execution node field to job details panel
2019-01-28 13:48:50 -05:00
Kia Lam
c1b48e2c9c
Some sidebar nav fixes.
...
- Set isExpanded state to false when window width is < 700px.
- Set `pointer-events` to `none` for logo to allow users to easily click on hamburger icon.
2019-01-28 13:25:44 -05:00
softwarefactory-project-zuul[bot]
9d501327fc
Merge pull request #3078 from shawnmolnar/fixtypos
...
Fixed role download typo in help text
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-28 17:53:23 +00:00
Molnar, Shawn
31b3bad658
Fixed role download typo in help text
2019-01-25 16:37:51 -08:00
softwarefactory-project-zuul[bot]
155c214df0
Merge pull request #3077 from mabashian/i18n-sweep
...
Mark strings for translation
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-25 21:11:30 +00:00
mabashian
5931c13b04
Mark strings for translation
2019-01-25 14:21:35 -05:00
softwarefactory-project-zuul[bot]
5d7b7d5888
Merge pull request #3074 from kialam/projects-expand-collapse
...
Add expand/collapse toolbar to Projects List.
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-25 17:41:01 +00:00
softwarefactory-project-zuul[bot]
53ad819d65
Merge pull request #3068 from kialam/job-template-expand-collapse
...
Add expand/collapse toolbar for Job Templates list.
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2019-01-25 17:40:54 +00:00
