2019-05-08 22:17:32 +03:00
// Copyright 2019 The Gitea Authors. All rights reserved.
2022-11-27 21:20:29 +03:00
// SPDX-License-Identifier: MIT
2019-05-08 22:17:32 +03:00
2022-09-02 22:18:23 +03:00
package integration
2019-05-08 22:17:32 +03:00
import (
"net/http"
"testing"
Redesign Scoped Access Tokens (#24767)
## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
- `activitypub`
- `admin` (hidden if user is not a site admin)
- `misc`
- `notification`
- `organization`
- `package`
- `issue`
- `repository`
- `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
- `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
- `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
- _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
- _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
- _This should be addressed in this PR_
- For example:
```go
m.Group("/users/{username}/orgs", func() {
m.Get("", reqToken(), org.ListUserOrgs)
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-04 21:57:16 +03:00
auth_model "code.gitea.io/gitea/models/auth"
2021-11-16 11:53:21 +03:00
"code.gitea.io/gitea/models/unittest"
2021-11-24 12:49:20 +03:00
user_model "code.gitea.io/gitea/models/user"
2019-05-11 13:21:34 +03:00
api "code.gitea.io/gitea/modules/structs"
2022-09-02 22:18:23 +03:00
"code.gitea.io/gitea/tests"
2019-05-08 22:17:32 +03:00
"github.com/stretchr/testify/assert"
)
type SearchResults struct {
OK bool ` json:"ok" `
Data [ ] * api . User ` json:"data" `
}
func TestAPIUserSearchLoggedIn ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2019-05-08 22:17:32 +03:00
adminUsername := "user1"
session := loginUser ( t , adminUsername )
Redesign Scoped Access Tokens (#24767)
## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
- `activitypub`
- `admin` (hidden if user is not a site admin)
- `misc`
- `notification`
- `organization`
- `package`
- `issue`
- `repository`
- `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
- `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
- `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
- _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
- _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
- _This should be addressed in this PR_
- For example:
```go
m.Group("/users/{username}/orgs", func() {
m.Get("", reqToken(), org.ListUserOrgs)
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-04 21:57:16 +03:00
token := getTokenForLoggedInUser ( t , session , auth_model . AccessTokenScopeReadUser )
2019-05-08 22:17:32 +03:00
query := "user2"
2023-12-22 02:59:59 +03:00
req := NewRequestf ( t , "GET" , "/api/v1/users/search?q=%s" , query ) .
AddTokenAuth ( token )
2022-12-02 06:39:42 +03:00
resp := MakeRequest ( t , req , http . StatusOK )
2019-05-08 22:17:32 +03:00
var results SearchResults
DecodeJSON ( t , resp , & results )
assert . NotEmpty ( t , results . Data )
for _ , user := range results . Data {
assert . Contains ( t , user . UserName , query )
assert . NotEmpty ( t , user . Email )
}
2024-10-08 12:51:09 +03:00
publicToken := getTokenForLoggedInUser ( t , session , auth_model . AccessTokenScopeReadUser , auth_model . AccessTokenScopePublicOnly )
req = NewRequestf ( t , "GET" , "/api/v1/users/search?q=%s" , query ) .
AddTokenAuth ( publicToken )
resp = MakeRequest ( t , req , http . StatusOK )
results = SearchResults { }
DecodeJSON ( t , resp , & results )
assert . NotEmpty ( t , results . Data )
for _ , user := range results . Data {
assert . Contains ( t , user . UserName , query )
assert . NotEmpty ( t , user . Email )
assert . True ( t , user . Visibility == "public" )
}
2019-05-08 22:17:32 +03:00
}
func TestAPIUserSearchNotLoggedIn ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2019-05-08 22:17:32 +03:00
query := "user2"
req := NewRequestf ( t , "GET" , "/api/v1/users/search?q=%s" , query )
resp := MakeRequest ( t , req , http . StatusOK )
var results SearchResults
DecodeJSON ( t , resp , & results )
assert . NotEmpty ( t , results . Data )
2021-11-24 12:49:20 +03:00
var modelUser * user_model . User
2019-05-08 22:17:32 +03:00
for _ , user := range results . Data {
assert . Contains ( t , user . UserName , query )
2022-08-16 05:22:25 +03:00
modelUser = unittest . AssertExistsAndLoadBean ( t , & user_model . User { ID : user . ID } )
2023-07-31 04:18:38 +03:00
assert . EqualValues ( t , modelUser . GetPlaceholderEmail ( ) , user . Email )
2019-05-08 22:17:32 +03:00
}
}
2021-06-26 22:53:14 +03:00
2023-11-13 17:31:38 +03:00
func TestAPIUserSearchSystemUsers ( t * testing . T ) {
defer tests . PrepareTestEnv ( t ) ( )
for _ , systemUser := range [ ] * user_model . User {
user_model . NewGhostUser ( ) ,
user_model . NewActionsUser ( ) ,
} {
t . Run ( systemUser . Name , func ( t * testing . T ) {
req := NewRequestf ( t , "GET" , "/api/v1/users/search?uid=%d" , systemUser . ID )
resp := MakeRequest ( t , req , http . StatusOK )
var results SearchResults
DecodeJSON ( t , resp , & results )
assert . NotEmpty ( t , results . Data )
if assert . EqualValues ( t , 1 , len ( results . Data ) ) {
user := results . Data [ 0 ]
assert . EqualValues ( t , user . UserName , systemUser . Name )
assert . EqualValues ( t , user . ID , systemUser . ID )
}
} )
}
}
2021-06-26 22:53:14 +03:00
func TestAPIUserSearchAdminLoggedInUserHidden ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2021-06-26 22:53:14 +03:00
adminUsername := "user1"
session := loginUser ( t , adminUsername )
Redesign Scoped Access Tokens (#24767)
## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
- `activitypub`
- `admin` (hidden if user is not a site admin)
- `misc`
- `notification`
- `organization`
- `package`
- `issue`
- `repository`
- `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
- `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
- `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
- _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
- _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
- _This should be addressed in this PR_
- For example:
```go
m.Group("/users/{username}/orgs", func() {
m.Get("", reqToken(), org.ListUserOrgs)
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-04 21:57:16 +03:00
token := getTokenForLoggedInUser ( t , session , auth_model . AccessTokenScopeReadUser )
2021-06-26 22:53:14 +03:00
query := "user31"
2023-12-22 02:59:59 +03:00
req := NewRequestf ( t , "GET" , "/api/v1/users/search?q=%s" , query ) .
AddTokenAuth ( token )
2022-12-02 06:39:42 +03:00
resp := MakeRequest ( t , req , http . StatusOK )
2021-06-26 22:53:14 +03:00
var results SearchResults
DecodeJSON ( t , resp , & results )
assert . NotEmpty ( t , results . Data )
for _ , user := range results . Data {
assert . Contains ( t , user . UserName , query )
assert . NotEmpty ( t , user . Email )
assert . EqualValues ( t , "private" , user . Visibility )
}
}
func TestAPIUserSearchNotLoggedInUserHidden ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2021-06-26 22:53:14 +03:00
query := "user31"
req := NewRequestf ( t , "GET" , "/api/v1/users/search?q=%s" , query )
resp := MakeRequest ( t , req , http . StatusOK )
var results SearchResults
DecodeJSON ( t , resp , & results )
assert . Empty ( t , results . Data )
}
2024-10-04 20:45:06 +03:00
func TestAPIUserSearchByEmail ( t * testing . T ) {
defer tests . PrepareTestEnv ( t ) ( )
// admin can search user with private email
adminUsername := "user1"
session := loginUser ( t , adminUsername )
token := getTokenForLoggedInUser ( t , session , auth_model . AccessTokenScopeReadUser )
query := "user2@example.com"
req := NewRequestf ( t , "GET" , "/api/v1/users/search?q=%s" , query ) .
AddTokenAuth ( token )
resp := MakeRequest ( t , req , http . StatusOK )
var results SearchResults
DecodeJSON ( t , resp , & results )
assert . Equal ( t , 1 , len ( results . Data ) )
assert . Equal ( t , query , results . Data [ 0 ] . Email )
// no login user can not search user with private email
req = NewRequestf ( t , "GET" , "/api/v1/users/search?q=%s" , query )
resp = MakeRequest ( t , req , http . StatusOK )
DecodeJSON ( t , resp , & results )
assert . Empty ( t , results . Data )
// user can search self with private email
user2 := "user2"
session = loginUser ( t , user2 )
token = getTokenForLoggedInUser ( t , session , auth_model . AccessTokenScopeReadUser )
req = NewRequestf ( t , "GET" , "/api/v1/users/search?q=%s" , query ) .
AddTokenAuth ( token )
resp = MakeRequest ( t , req , http . StatusOK )
DecodeJSON ( t , resp , & results )
assert . Equal ( t , 1 , len ( results . Data ) )
assert . Equal ( t , query , results . Data [ 0 ] . Email )
}