2017-03-17 08:57:43 +03:00
<div class="four wide column">
<div class="ui segment metas">
2017-08-24 15:30:27 +03:00
{{ template "repo/issue/branch_selector_field" . }}
2022-08-31 18:58:54 +03:00
{{ if .Issue .IsPull }}
2020-04-06 19:33:34 +03:00
2021-02-28 17:05:55 +03:00
<input id="reviewer_id" name="reviewer_id" type="hidden" value=" {{ .reviewer_id }} ">
<div class="ui {{ if or ( not .Reviewers ) ( not .CanChooseReviewer ) .Repository .IsArchived }} disabled {{ end }} floating jump select-reviewers-modify dropdown">
2023-02-13 20:59:59 +03:00
<a class="text gt-df gt-ac muted">
2022-06-27 23:58:46 +03:00
<strong> {{ .locale .Tr "repo.issues.review.reviewers" }} </strong>
2021-02-28 17:05:55 +03:00
{{ if and .CanChooseReviewer ( not .Repository .IsArchived ) }}
2023-02-13 20:59:59 +03:00
{{ svg "octicon-gear" 1 6 "gt-ml-2" }}
2021-02-28 17:05:55 +03:00
{{ end }}
2021-05-16 23:18:18 +03:00
</a>
2021-02-28 17:05:55 +03:00
<div class="filter menu" data-action="update" data-issue-id=" {{ $ .Issue .ID }} " data-update-url=" {{ $ .RepoLink }} /issues/request_review">
2022-06-27 23:58:46 +03:00
<div class="header" style="text-transform: none;font-size:16px;"> {{ .locale .Tr "repo.issues.new.add_reviewer_title" }} </div>
2021-02-28 17:05:55 +03:00
{{ if .Reviewers }}
<div class="ui icon search input">
2023-02-13 20:59:59 +03:00
<i class="icon gt-df gt-ac gt-jc"> {{ svg "octicon-search" 1 6 }} </i>
2022-06-27 23:58:46 +03:00
<input type="text" placeholder=" {{ .locale .Tr "repo.issues.filter_reviewers" }} ">
2021-02-28 17:05:55 +03:00
</div>
{{ end }}
{{ if .Reviewers }}
{{ range .Reviewers }}
{{ if .User }}
2023-03-24 13:35:38 +03:00
<a class=" {{ if not .CanChange }} ui {{ end }} item {{ if .Checked }} checked {{ end }} {{ if not .CanChange }} ban-change {{ end }} " href="#" data-id=" {{ .ItemID }} " data-id-selector="#review_request_ {{ .ItemID }} " {{ if not .CanChange }} data-tooltip-content=" {{ $ .locale .Tr "repo.issues.remove_request_review_block" }} " {{ end }} >
2021-02-28 17:05:55 +03:00
<span class="octicon-check {{ if not .Checked }} invisible {{ end }} "> {{ svg "octicon-check" }} </span>
<span class="text">
2023-03-16 19:32:25 +03:00
{{ avatar $ .Context .User 2 8 "gt-mr-3" }} {{ template "repo/search_name" .User }}
2021-02-28 17:05:55 +03:00
</span>
</a>
{{ end }}
2020-04-06 19:33:34 +03:00
{{ end }}
{{ end }}
2021-02-28 17:05:55 +03:00
{{ if .TeamReviewers }}
<div class="ui divider"></div>
{{ range .TeamReviewers }}
{{ if .Team }}
2023-03-24 13:35:38 +03:00
<a class=" {{ if not .CanChange }} ui {{ end }} item {{ if .Checked }} checked {{ end }} {{ if not .CanChange }} ban-change {{ end }} " href="#" data-id=" {{ .ItemID }} " data-id-selector="#review_request_team_ {{ .Team .ID }} " {{ if not .CanChange }} data-tooltip-content=" {{ $ .locale .Tr "repo.issues.remove_request_review_block" }} " {{ end }} >
2021-02-28 17:05:55 +03:00
<span class="octicon-check {{ if not .Checked }} invisible {{ end }} "> {{ svg "octicon-check" 1 6 }} </span>
<span class="text">
2023-02-13 20:59:59 +03:00
{{ svg "octicon-people" 1 6 "gt-ml-4 gt-mr-2" }} {{ $ .Issue .Repo .OwnerName }} / {{ .Team .Name }}
2021-02-28 17:05:55 +03:00
</span>
</a>
{{ end }}
2020-10-12 22:55:13 +03:00
{{ end }}
2020-04-06 19:33:34 +03:00
{{ end }}
2021-02-28 17:05:55 +03:00
</div>
2020-04-06 19:33:34 +03:00
</div>
2021-02-28 17:05:55 +03:00
<div class="ui assignees list">
2023-02-19 07:06:14 +03:00
<span class="no-select item {{ if or .OriginalReviews .PullReviewers }} gt-hidden {{ end }} "> {{ .locale .Tr "repo.issues.new.no_reviewers" }} </span>
2021-02-28 17:05:55 +03:00
<div class="selected">
{{ range .PullReviewers }}
2023-02-13 20:59:59 +03:00
<div class="item gt-mb-2">
2021-02-28 17:05:55 +03:00
{{ if .User }}
<a class="muted sidebar-item-link" href=" {{ .User .HomeLink }} ">
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 16:37:34 +03:00
{{ avatar $ .Context .User 2 8 "gt-mr-3" }}
2021-02-28 17:05:55 +03:00
{{ .User .GetDisplayName }}
2020-04-06 19:33:34 +03:00
</a>
2021-02-28 17:05:55 +03:00
{{ else if .Team }}
<span class="text"> {{ svg "octicon-people" 1 6 "teamavatar" }} {{ $ .Issue .Repo .OwnerName }} / {{ .Team .Name }} </span>
2020-04-06 19:33:34 +03:00
{{ end }}
2021-02-28 17:05:55 +03:00
<span class="ui right type-icon text {{ if eq .Review .Type 1 }} green
{{ - else if eq .Review .Type 2 }} grey
{{ - else if eq .Review .Type 3 }} red
{{ - else if eq .Review .Type 4 }} yellow
{{ - else }} grey {{ end }} right ">
{{ if .CanChange }}
2023-03-24 13:35:38 +03:00
<a href="#" class="ui icon re-request-review {{ if .Checked }} checked {{ end }} " data-tooltip-content=" {{ if .Checked }} {{ $ .locale .Tr "repo.issues.remove_request_review" }} {{ else }} {{ $ .locale .Tr "repo.issues.re_request_review" }} {{ end }} " data-issue-id=" {{ $ .Issue .ID }} " data-id=" {{ .ItemID }} " data-update-url=" {{ $ .RepoLink }} /issues/request_review">
2021-03-22 07:04:19 +03:00
{{ if .Checked }} {{ svg "octicon-trash" }} {{ else }} {{ svg "octicon-sync" }} {{ end }}
2021-02-28 17:05:55 +03:00
</a>
{{ end }}
{{ svg ( printf "octicon-%s" .Review .Type .Icon ) }}
</span>
</div>
{{ end }}
{{ range .OriginalReviews }}
<div class="item" style="margin-bottom: 10px;">
2023-03-24 13:35:38 +03:00
<a href=" {{ $ .Repository .OriginalURL }} " data-tooltip-content=" {{ $ .locale .Tr "repo.migrated_from_fake" ( $ .Repository .GetOriginalURLHostname | Escape ) | Safe }} ">
2021-09-18 19:22:51 +03:00
<span class="text black">
{{ svg ( MigrationIcon $ .Repository .GetOriginalURLHostname ) }}
2022-08-31 18:58:54 +03:00
{{ .OriginalAuthor }}
2021-09-18 19:22:51 +03:00
</span>
</a>
2021-02-28 17:05:55 +03:00
<span class="ui right type-icon text {{ if eq .Type 1 }} green
{{ - else if eq .Type 2 }} grey
{{ - else if eq .Type 3 }} red
{{ - else if eq .Type 4 }} yellow
{{ - else }} grey {{ end }} right ">
{{ svg ( printf "octicon-%s" .Type .Icon ) }}
</span>
</div>
{{ end }}
</div>
2020-04-06 19:33:34 +03:00
</div>
2021-05-27 23:02:04 +03:00
{{ if and ( or .HasIssuesOrPullsWritePermission .IsIssuePoster ) ( not .HasMerged ) ( not .Issue .IsClosed ) ( not .IsPullWorkInProgress ) }}
2021-11-16 21:18:25 +03:00
<div class="toggle-wip" data-title=" {{ .Issue .Title }} " data-wip-prefix=" {{ ( in dex .PullRequestWorkInProgressPrefixes 0 | Escape ) }} " data-update-url=" {{ .Issue .Link }} /title">
2021-05-27 23:02:04 +03:00
<a class="muted">
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.pulls.still_in_progress" }} {{ .locale .Tr "repo.pulls.add_prefix" ( in dex .PullRequestWorkInProgressPrefixes 0 | Escape ) | Safe }}
2021-05-27 23:02:04 +03:00
</a>
</div>
{{ end }}
2021-02-28 17:05:55 +03:00
<div class="ui divider"></div>
2020-06-17 17:12:06 +03:00
{{ end }}
2020-04-06 19:33:34 +03:00
2023-03-12 23:39:56 +03:00
{{ template "repo/issue/labels/labels_selector_field" . }}
2023-03-02 20:44:06 +03:00
{{ template "repo/issue/labels/labels_sidebar" dict "root" $ }}
2017-03-17 08:57:43 +03:00
<div class="ui divider"></div>
2020-04-04 08:39:48 +03:00
<div class="ui {{ if or ( not .HasIssuesOrPullsWritePermission ) .Repository .IsArchived }} disabled {{ end }} floating jump select-milestone dropdown">
2023-02-13 20:59:59 +03:00
<a class="text gt-df gt-ac muted">
2022-06-27 23:58:46 +03:00
<strong> {{ .locale .Tr "repo.issues.new.milestone" }} </strong>
2020-04-04 08:39:48 +03:00
{{ if and .HasIssuesOrPullsWritePermission ( not .Repository .IsArchived ) }}
2023-02-13 20:59:59 +03:00
{{ svg "octicon-gear" 1 6 "gt-ml-2" }}
2020-03-17 19:19:03 +03:00
{{ end }}
2021-05-16 23:18:18 +03:00
</a>
2017-03-17 08:57:43 +03:00
<div class="menu" data-action="update" data-issue-id=" {{ $ .Issue .ID }} " data-update-url=" {{ $ .RepoLink }} /issues/milestone">
2022-06-27 23:58:46 +03:00
<div class="header" style="text-transform: none;font-size:16px;"> {{ .locale .Tr "repo.issues.new.add_milestone_title" }} </div>
2020-04-04 08:39:48 +03:00
{{ if or .OpenMilestones .ClosedMilestones }}
<div class="ui icon search input">
2023-02-13 20:59:59 +03:00
<i class="icon gt-df gt-ac gt-jc"> {{ svg "octicon-search" 1 6 }} </i>
2022-06-27 23:58:46 +03:00
<input type="text" placeholder=" {{ .locale .Tr "repo.issues.filter_milestones" }} ">
2020-04-04 08:39:48 +03:00
</div>
{{ end }}
2022-06-27 23:58:46 +03:00
<div class="no-select item"> {{ .locale .Tr "repo.issues.new.clear_milestone" }} </div>
2020-04-04 08:39:48 +03:00
{{ if and ( not .OpenMilestones ) ( not .ClosedMilestones ) }}
<div class="header" style="text-transform: none;font-size:14px;">
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.new.no_items" }}
2017-03-17 08:57:43 +03:00
</div>
2020-04-04 08:39:48 +03:00
{{ else }}
{{ if .OpenMilestones }}
<div class="divider"></div>
<div class="header">
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.new.open_milestone" }}
2020-04-04 08:39:48 +03:00
</div>
{{ range .OpenMilestones }}
2020-11-29 09:22:04 +03:00
<a class="item" data-id=" {{ .ID }} " data-href=" {{ $ .RepoLink }} /issues?milestone= {{ .ID }} ">
2023-02-13 20:59:59 +03:00
{{ svg "octicon-milestone" 1 6 "gt-mr-2" }}
2020-11-29 09:22:04 +03:00
{{ .Name }}
</a>
2020-04-04 08:39:48 +03:00
{{ end }}
2017-03-17 08:57:43 +03:00
{{ end }}
2020-04-04 08:39:48 +03:00
{{ if .ClosedMilestones }}
<div class="divider"></div>
<div class="header">
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.new.closed_milestone" }}
2020-04-04 08:39:48 +03:00
</div>
{{ range .ClosedMilestones }}
2020-11-29 09:22:04 +03:00
<a class="item" data-id=" {{ .ID }} " data-href=" {{ $ .RepoLink }} /issues?milestone= {{ .ID }} ">
2023-02-13 20:59:59 +03:00
{{ svg "octicon-milestone" 1 6 "gt-mr-2" }}
2020-11-29 09:22:04 +03:00
{{ .Name }}
</a>
2020-04-04 08:39:48 +03:00
{{ end }}
2017-03-17 08:57:43 +03:00
{{ end }}
{{ end }}
</div>
</div>
<div class="ui select-milestone list">
2023-02-19 07:06:14 +03:00
<span class="no-select item {{ if .Issue .Milestone }} gt-hidden {{ end }} "> {{ .locale .Tr "repo.issues.new.no_milestone" }} </span>
2017-03-17 08:57:43 +03:00
<div class="selected">
{{ if .Issue .Milestone }}
2020-11-29 09:22:04 +03:00
<a class="item muted sidebar-item-link" href=" {{ .RepoLink }} /milestone/ {{ .Issue .Milestone .ID }} ">
2023-02-13 20:59:59 +03:00
{{ svg "octicon-milestone" 1 8 "gt-mr-3" }}
2020-11-29 09:22:04 +03:00
{{ .Issue .Milestone .Name }}
</a>
2017-03-17 08:57:43 +03:00
{{ end }}
</div>
</div>
2020-08-17 06:07:38 +03:00
{{ if .IsProjectsEnabled }}
2021-02-28 17:05:55 +03:00
<div class="ui divider"></div>
2020-11-29 09:22:04 +03:00
2021-02-28 17:05:55 +03:00
<div class="ui {{ if or ( not .HasIssuesOrPullsWritePermission ) .Repository .IsArchived }} disabled {{ end }} floating jump select-project dropdown">
2023-02-13 20:59:59 +03:00
<a class="text gt-df gt-ac muted">
2022-06-27 23:58:46 +03:00
<strong> {{ .locale .Tr "repo.issues.new.projects" }} </strong>
2021-03-12 18:14:02 +03:00
{{ if and .HasIssuesOrPullsWritePermission ( not .Repository .IsArchived ) }}
2023-02-13 20:59:59 +03:00
{{ svg "octicon-gear" 1 6 "gt-ml-2" }}
2021-03-12 18:14:02 +03:00
{{ end }}
2021-05-16 23:18:18 +03:00
</a>
2021-02-28 17:05:55 +03:00
<div class="menu" data-action="update" data-issue-id=" {{ $ .Issue .ID }} " data-update-url=" {{ $ .RepoLink }} /issues/projects">
2023-02-01 01:40:38 +03:00
<div class="header" style="text-transform: none;font-size:16px;"> {{ .locale .Tr "repo.issues.new.add_project_title" }} </div>
{{ if or .OpenProjects .ClosedProjects }}
<div class="ui icon search input">
2023-02-13 20:59:59 +03:00
<i class="icon gt-df gt-ac gt-jc"> {{ svg "octicon-search" 1 6 }} </i>
2023-02-01 01:40:38 +03:00
<input type="text" placeholder=" {{ .locale .Tr "repo.issues.filter_projects" }} ">
</div>
{{ end }}
2022-06-27 23:58:46 +03:00
<div class="no-select item"> {{ .locale .Tr "repo.issues.new.clear_projects" }} </div>
2021-02-28 17:05:55 +03:00
{{ if .OpenProjects }}
<div class="divider"></div>
<div class="header">
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.new.open_projects" }}
2021-02-28 17:05:55 +03:00
</div>
{{ range .OpenProjects }}
2023-01-20 14:42:33 +03:00
<a class="item muted sidebar-item-link" data-id=" {{ .ID }} " data-href=" {{ .Link }} ">
2023-03-19 15:44:48 +03:00
{{ svg .IconName 1 8 "gt-mr-3" }} {{ .Title }}
2021-02-28 17:05:55 +03:00
</a>
{{ end }}
2020-08-17 06:07:38 +03:00
{{ end }}
2021-02-28 17:05:55 +03:00
{{ if .ClosedProjects }}
<div class="divider"></div>
<div class="header">
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.new.closed_projects" }}
2021-02-28 17:05:55 +03:00
</div>
{{ range .ClosedProjects }}
2023-01-20 14:42:33 +03:00
<a class="item muted sidebar-item-link" data-id=" {{ .ID }} " data-href=" {{ .Link }} ">
2023-03-19 15:44:48 +03:00
{{ svg .IconName 1 8 "gt-mr-3" }} {{ .Title }}
2021-02-28 17:05:55 +03:00
</a>
{{ end }}
{{ end }}
</div>
</div>
<div class="ui select-project list">
2023-02-19 07:06:14 +03:00
<span class="no-select item {{ if .Issue .ProjectID }} gt-hidden {{ end }} "> {{ .locale .Tr "repo.issues.new.no_projects" }} </span>
2021-02-28 17:05:55 +03:00
<div class="selected">
{{ if .Issue .ProjectID }}
2023-01-20 14:42:33 +03:00
<a class="item muted sidebar-item-link" href=" {{ .Issue .Project .Link }} ">
2023-03-19 15:44:48 +03:00
{{ svg .Issue .Project .IconName 1 8 "gt-mr-3" }} {{ .Issue .Project .Title }}
2020-11-29 09:22:04 +03:00
</a>
2020-08-17 06:07:38 +03:00
{{ end }}
2021-02-28 17:05:55 +03:00
</div>
2020-08-17 06:07:38 +03:00
</div>
{{ end }}
2017-03-17 08:57:43 +03:00
<div class="ui divider"></div>
<input id="assignee_id" name="assignee_id" type="hidden" value=" {{ .assignee_id }} ">
2020-04-04 08:39:48 +03:00
<div class="ui {{ if or ( not .HasIssuesOrPullsWritePermission ) .Repository .IsArchived }} disabled {{ end }} floating jump select-assignees-modify dropdown">
2023-02-13 20:59:59 +03:00
<a class="text gt-df gt-ac muted">
2022-06-27 23:58:46 +03:00
<strong> {{ .locale .Tr "repo.issues.new.assignees" }} </strong>
2020-04-04 08:39:48 +03:00
{{ if and .HasIssuesOrPullsWritePermission ( not .Repository .IsArchived ) }}
2023-02-13 20:59:59 +03:00
{{ svg "octicon-gear" 1 6 "gt-ml-2" }}
2020-03-17 19:19:03 +03:00
{{ end }}
2021-05-16 23:18:18 +03:00
</a>
2020-09-02 19:55:13 +03:00
<div class="filter menu" data-action="update" data-issue-id=" {{ $ .Issue .ID }} " data-update-url=" {{ $ .RepoLink }} /issues/assignee">
2022-06-27 23:58:46 +03:00
<div class="header" style="text-transform: none;font-size:16px;"> {{ .locale .Tr "repo.issues.new.add_assignees_title" }} </div>
2020-04-04 08:39:48 +03:00
<div class="ui icon search input">
2023-02-13 20:59:59 +03:00
<i class="icon gt-df gt-ac gt-jc"> {{ svg "octicon-search" 1 6 }} </i>
2022-06-27 23:58:46 +03:00
<input type="text" placeholder=" {{ .locale .Tr "repo.issues.filter_assignees" }} ">
2020-04-04 08:39:48 +03:00
</div>
2022-06-27 23:58:46 +03:00
<div class="no-select item"> {{ .locale .Tr "repo.issues.new.clear_assignees" }} </div>
2017-03-17 08:57:43 +03:00
{{ range .Assignees }}
2018-05-09 19:29:04 +03:00
{{ $ AssigneeID : = .ID }}
2020-11-12 08:55:34 +03:00
<a class="item {{ range $ .Issue .Assignees }} {{ if eq .ID $ AssigneeID }} checked {{ end }} {{ end }} " href="#" data-id=" {{ .ID }} " data-id-selector="#assignee_ {{ .ID }} ">
2020-02-11 20:02:41 +03:00
{{ $ checked : = false }}
{{ range $ .Issue .Assignees }}
{{ if eq .ID $ AssigneeID }}
{{ $ checked = true }}
{{ end }}
2018-05-09 19:29:04 +03:00
{{ end }}
2020-09-11 23:19:00 +03:00
<span class="octicon-check {{ if not $ checked }} invisible {{ end }} "> {{ svg "octicon-check" }} </span>
2018-05-09 19:29:04 +03:00
<span class="text">
2023-04-07 03:11:02 +03:00
{{ avatar $ .Context . 2 0 "gt-mr-3" }} {{ template "repo/search_name" . }}
2018-05-09 19:29:04 +03:00
</span>
</a>
2017-03-17 08:57:43 +03:00
{{ end }}
</div>
</div>
2018-05-09 19:29:04 +03:00
<div class="ui assignees list">
2023-02-19 07:06:14 +03:00
<span class="no-select item {{ if .Issue .Assignees }} gt-hidden {{ end }} "> {{ .locale .Tr "repo.issues.new.no_assignees" }} </span>
2017-03-17 08:57:43 +03:00
<div class="selected">
2018-05-09 19:29:04 +03:00
{{ range .Issue .Assignees }}
2020-11-29 09:22:04 +03:00
<div class="item">
<a class="muted sidebar-item-link" href=" {{ $ .RepoLink }} / {{ if $ .Issue .IsPull }} pulls {{ else }} issues {{ end }} ?assignee= {{ .ID }} ">
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 16:37:34 +03:00
{{ avatar $ .Context . 2 8 "gt-mr-3" }}
2020-11-12 08:55:34 +03:00
{{ .GetDisplayName }}
</a>
2018-05-09 19:29:04 +03:00
</div>
2017-03-17 08:57:43 +03:00
{{ end }}
</div>
</div>
<div class="ui divider"></div>
2020-12-08 06:20:12 +03:00
{{ if .Participants }}
2022-06-27 23:58:46 +03:00
<span class="text"><strong> {{ .locale .Tr "repo.issues.num_participants" .NumParticipants }} </strong></span>
2023-02-13 20:59:59 +03:00
<div class="ui list gt-df gt-fw">
2017-03-17 08:57:43 +03:00
{{ range .Participants }}
2023-03-24 13:35:38 +03:00
<a {{ if gt .ID 0 }} href=" {{ .HomeLink }} " {{ end }} data-tooltip-content=" {{ .GetDisplayName }} ">
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 16:37:34 +03:00
{{ avatar $ .Context . 2 8 "gt-my-1 gt-mr-2" }}
2017-03-17 08:57:43 +03:00
</a>
{{ end }}
</div>
2020-12-08 06:20:12 +03:00
{{ end }}
2017-03-30 02:31:47 +03:00
2019-01-23 21:58:38 +03:00
{{ if and $ .IssueWatch ( not .Repository .IsArchived ) }}
2017-09-12 09:48:13 +03:00
<div class="ui divider"></div>
2017-03-30 02:31:47 +03:00
2017-09-12 09:48:13 +03:00
<div class="ui watching">
2022-06-27 23:58:46 +03:00
<span class="text"><strong> {{ .locale .Tr "notification.notifications" }} </strong></span>
2023-02-13 20:59:59 +03:00
<div class="gt-mt-3">
2021-11-16 21:18:25 +03:00
<form method="POST" action=" {{ .Issue .Link }} /watch">
2023-03-27 19:05:51 +03:00
<input type="hidden" name="watch" value=" {{ if $ .IssueWatch .IsWatching }} 0 {{ else }} 1 {{ end }} ">
2017-09-12 09:48:13 +03:00
{{ $ .CsrfTokenHtml }}
2023-02-13 20:59:59 +03:00
<button class="fluid ui button gt-df gt-jc">
2017-09-12 09:48:13 +03:00
{{ if $ .IssueWatch .IsWatching }}
2023-02-13 20:59:59 +03:00
{{ svg "octicon-mute" 1 6 "gt-mr-3" }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.unsubscribe" }}
2017-09-12 09:48:13 +03:00
{{ else }}
2023-02-13 20:59:59 +03:00
{{ svg "octicon-unmute" 1 6 "gt-mr-3" }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.subscribe" }}
2017-09-12 09:48:13 +03:00
{{ end }}
</button>
</form>
</div>
</div>
{{ end }}
2022-12-10 05:46:31 +03:00
{{ if .Repository .IsTimetrackerEnabled $ .Context }}
2019-01-23 21:58:38 +03:00
{{ if and .CanUseTimetracker ( not .Repository .IsArchived ) }}
2017-09-12 09:48:13 +03:00
<div class="ui divider"></div>
<div class="ui timetrack">
2022-06-27 23:58:46 +03:00
<span class="text"><strong> {{ .locale .Tr "repo.issues.tracker" }} </strong></span>
2023-02-13 20:59:59 +03:00
<div class="gt-mt-3">
2021-11-16 21:18:25 +03:00
<form method="POST" action=" {{ .Issue .Link }} /times/stopwatch/toggle" id="toggle_stopwatch_form">
2017-09-12 09:48:13 +03:00
{{ $ .CsrfTokenHtml }}
</form>
2021-11-16 21:18:25 +03:00
<form method="POST" action=" {{ .Issue .Link }} /times/stopwatch/cancel" id="cancel_stopwatch_form">
2017-09-12 09:48:13 +03:00
{{ $ .CsrfTokenHtml }}
</form>
{{ if $ .IsStopwatchRunning }}
2022-06-27 23:58:46 +03:00
<button class="ui fluid button issue-stop-time"> {{ .locale .Tr "repo.issues.stop_tracking" }} </button>
2023-02-13 20:59:59 +03:00
<button class="ui fluid negative button issue-cancel-time gt-mt-3"> {{ .locale .Tr "repo.issues.cancel_tracking" }} </button>
2017-03-30 02:31:47 +03:00
{{ else }}
2017-09-12 09:48:13 +03:00
{{ if .HasUserStopwatch }}
<div class="ui warning message">
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.tracking_already_started" ( .OtherStopwatchURL | Escape ) | Safe }}
2017-09-12 09:48:13 +03:00
</div>
{{ end }}
2023-03-24 13:35:38 +03:00
<button class="ui fluid button issue-start-time" data-tooltip-content=' {{ .locale .Tr "repo.issues.start_tracking" }} '> {{ .locale .Tr "repo.issues.start_tracking_short" }} </button>
2021-05-16 23:18:18 +03:00
<div class="ui mini modal issue-start-time-modal">
2022-06-27 23:58:46 +03:00
<div class="header"> {{ .locale .Tr "repo.issues.add_time" }} </div>
2021-05-16 23:18:18 +03:00
<div class="content">
2021-11-16 21:18:25 +03:00
<form method="POST" id="add_time_manual_form" action=" {{ .Issue .Link }} /times/add" class="ui action input fluid">
2021-05-16 23:18:18 +03:00
{{ $ .CsrfTokenHtml }}
2022-06-27 23:58:46 +03:00
<input placeholder=' {{ .locale .Tr "repo.issues.add_time_hours" }} ' type="number" name="hours">
<input placeholder=' {{ .locale .Tr "repo.issues.add_time_minutes" }} ' type="number" name="minutes" class="ui compact">
2021-05-16 23:18:18 +03:00
</form>
</div>
<div class="actions">
2023-03-14 06:34:09 +03:00
<button class="ui green approve button"> {{ .locale .Tr "repo.issues.add_time_short" }} </button>
<button class="ui red cancel button"> {{ .locale .Tr "repo.issues.add_time_cancel" }} </button>
2017-09-12 09:48:13 +03:00
</div>
</div>
2023-03-24 13:35:38 +03:00
<button class="ui fluid button green issue-add-time gt-mt-3" data-tooltip-content=' {{ .locale .Tr "repo.issues.add_time" }} '> {{ .locale .Tr "repo.issues.add_time_short" }} </button>
2017-03-30 02:31:47 +03:00
{{ end }}
2017-09-12 09:48:13 +03:00
</div>
</div>
{{ end }}
{{ if gt ( len .WorkingUsers ) 0 }}
<div class="ui divider"></div>
2020-12-08 06:20:12 +03:00
<div class="ui comments">
2022-06-27 23:58:46 +03:00
<span class="text"><strong> {{ .locale .Tr "repo.issues.time_spent_from_all_authors" ( $ .Issue .TotalTrackedTime | Sec2Time ) | Safe }} </strong></span>
2017-09-12 09:48:13 +03:00
<div>
{{ range $ user , $ trackedtime : = .WorkingUsers }}
2023-02-13 20:59:59 +03:00
<div class="comment gt-mt-3">
2017-09-12 09:48:13 +03:00
<a class="avatar">
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 16:37:34 +03:00
{{ avatar $ .Context $ user }}
2017-09-12 09:48:13 +03:00
</a>
<div class="content">
2022-11-19 07:02:30 +03:00
{{ template "shared/user/authorlink" $ user }}
2017-09-12 09:48:13 +03:00
<div class="text">
{{ $ trackedtime }}
</div>
</div>
</div>
{{ end }}
</div>
</div>
{{ end }}
2017-04-29 08:52:25 +03:00
{{ end }}
2018-05-01 22:05:28 +03:00
<div class="ui divider"></div>
2022-06-27 23:58:46 +03:00
<span class="text"><strong> {{ .locale .Tr "repo.issues.due_date" }} </strong></span>
2018-07-16 15:43:00 +03:00
<div class="ui form" id="deadline-loader">
2023-02-19 07:06:14 +03:00
<div class="ui negative message gt-hidden" id="deadline-err-invalid-date">
2021-05-16 23:18:18 +03:00
{{ svg "octicon-x" 1 6 "close icon" }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.due_date_invalid" }}
2018-07-16 15:43:00 +03:00
</div>
{{ if ne .Issue .DeadlineUnix 0 }}
<p>
2023-02-13 20:59:59 +03:00
<div class="gt-df gt-sb gt-ac">
2023-03-24 13:35:38 +03:00
<div class="due-date {{ if .Issue .IsOverdue }} text red {{ end }} " {{ if .Issue .IsOverdue }} data-tooltip-content=" {{ .locale .Tr "repo.issues.due_date_overdue" }} " {{ end }} >
2023-02-13 20:59:59 +03:00
{{ svg "octicon-calendar" 1 6 "gt-mr-3" }}
2023-04-11 02:01:20 +03:00
{{ template "shared/datetime/long" ( dict "Datetime" .Issue .DeadlineUnix .FormatDate "Fallback" .Issue .DeadlineUnix .FormatDate ) }}
2021-05-16 23:18:18 +03:00
</div>
<div>
{{ if and .HasIssuesOrPullsWritePermission ( not .Repository .IsArchived ) }}
2023-03-24 13:35:38 +03:00
<a class="issue-due-edit muted" data-tooltip-content=" {{ $ .locale .Tr "repo.issues.due_date_form_edit" }} "> {{ svg "octicon-pencil" 1 6 "gt-mr-2" }} </a>
<a class="issue-due-remove muted" data-tooltip-content=" {{ $ .locale .Tr "repo.issues.due_date_form_remove" }} "> {{ svg "octicon-trash" }} </a>
2021-05-16 23:18:18 +03:00
{{ end }}
</div>
</div>
2018-07-16 15:43:00 +03:00
</p>
{{ else }}
2022-06-27 23:58:46 +03:00
<p> {{ .locale .Tr "repo.issues.due_date_not_set" }} </p>
2018-07-16 15:43:00 +03:00
{{ end }}
2018-05-01 22:05:28 +03:00
2020-04-04 08:39:48 +03:00
{{ if and .HasIssuesOrPullsWritePermission ( not .Repository .IsArchived ) }}
2023-02-19 07:06:14 +03:00
<div {{ if ne .Issue .DeadlineUnix 0 }} class="gt-hidden" {{ end }} id="deadlineForm">
2022-04-07 21:59:56 +03:00
<form class="ui fluid action input issue-due-form" action=" {{ AppSubUrl }} / {{ PathEscape .Repository .Owner .Name }} / {{ PathEscape .Repository .Name }} /issues/ {{ .Issue .Index }} /deadline" method="post" id="update-issue-deadline-form">
2018-07-16 15:43:00 +03:00
{{ $ .CsrfTokenHtml }}
2022-06-27 23:58:46 +03:00
<input required placeholder=" {{ .locale .Tr "repo.issues.due_date_form" }} " {{ if gt .Issue .DeadlineUnix 0 }} value=" {{ .Issue .DeadlineUnix .Format "2006-01-02" }} " {{ end }} type="date" name="deadlineDate" id="deadlineDate">
2018-07-16 15:43:00 +03:00
<button class="ui green icon button">
{{ if ne .Issue .DeadlineUnix 0 }}
2021-05-16 23:18:18 +03:00
{{ svg "octicon-pencil" }}
2018-07-16 15:43:00 +03:00
{{ else }}
2021-05-16 23:18:18 +03:00
{{ svg "octicon-plus" }}
2018-07-16 15:43:00 +03:00
{{ end }}
</button>
</form>
</div>
{{ end }}
</div>
2018-07-18 00:23:58 +03:00
2022-12-10 05:46:31 +03:00
{{ if .Repository .IsDependenciesEnabled $ .Context }}
2018-07-18 00:23:58 +03:00
<div class="ui divider"></div>
<div class="ui depending">
2023-03-28 20:23:25 +03:00
{{ if ( and ( not .BlockedByDependencies ) ( not .BlockedByDependenciesNotPermitted ) ( not .BlockingDependencies ) ( not .BlockingDependenciesNotPermitted ) ) }}
2022-06-27 23:58:46 +03:00
<span class="text"><strong> {{ .locale .Tr "repo.issues.dependency.title" }} </strong></span>
2018-09-07 05:32:46 +03:00
<br>
2020-11-10 21:28:07 +03:00
<p>
{{ if .Issue .IsPull }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.dependency.pr_no_dependencies" }}
2018-09-07 05:32:46 +03:00
{{ else }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.dependency.issue_no_dependencies" }}
2020-11-10 21:28:07 +03:00
{{ end }}
</p>
2018-09-07 05:32:46 +03:00
{{ end }}
2023-03-28 20:23:25 +03:00
{{ if or .BlockingDependencies .BlockingDependenciesNotPermitted }}
2023-03-24 13:35:38 +03:00
<span class="text" data-tooltip-content=" {{ if .Issue .IsPull }} {{ .locale .Tr "repo.issues.dependency.pr_close_blocks" }} {{ else }} {{ .locale .Tr "repo.issues.dependency.issue_close_blocks" }} {{ end }} ">
2022-06-27 23:58:46 +03:00
<strong> {{ .locale .Tr "repo.issues.dependency.blocks_short" }} </strong>
2018-07-18 00:23:58 +03:00
</span>
<div class="ui relaxed divided list">
2018-09-07 05:32:46 +03:00
{{ range .BlockingDependencies }}
2023-02-13 20:59:59 +03:00
<div class="item dependency {{ if .Issue .IsClosed }} is-closed {{ end }} gt-df gt-ac gt-sb">
<div class="item-left gt-df gt-jc gt-fc gt-f1">
2023-03-24 13:35:38 +03:00
<a class="title" href=" {{ .Issue .Link }} " data-tooltip-content="# {{ .Issue .Index }} {{ .Issue .Title | RenderEmoji $ .Context }} ">
2023-03-06 00:59:05 +03:00
# {{ .Issue .Index }} {{ .Issue .Title | RenderEmoji $ .Context }}
2020-11-10 21:28:07 +03:00
</a>
<div class="text small">
{{ .Repository .OwnerName }} / {{ .Repository .Name }}
</div>
</div>
2023-02-13 20:59:59 +03:00
<div class="item-right gt-df gt-ac">
2019-01-23 21:58:38 +03:00
{{ if and $ .CanCreateIssueDependencies ( not $ .Repository .IsArchived ) }}
2023-03-24 13:35:38 +03:00
<a class="delete-dependency-button ci muted" data-id=" {{ .Issue .ID }} " data-type="blocking" data-tooltip-content=" {{ $ .locale .Tr "repo.issues.dependency.remove_info" }} ">
2021-03-22 07:04:19 +03:00
{{ svg "octicon-trash" 1 6 }}
2018-07-18 00:23:58 +03:00
</a>
{{ end }}
</div>
</div>
{{ end }}
2023-03-28 20:23:25 +03:00
{{ if .BlockingDependenciesNotPermitted }}
<div class="item gt-df gt-ac gt-sb">
<span> {{ $ .locale .TrN ( len .BlockingDependenciesNotPermitted ) "repo.issues.dependency.no_permission_1" "repo.issues.dependency.no_permission_n" ( len .BlockingDependenciesNotPermitted ) }} </span>
</div>
{{ end }}
2018-07-18 00:23:58 +03:00
</div>
{{ end }}
2023-03-28 20:23:25 +03:00
{{ if or .BlockedByDependencies .BlockedByDependenciesNotPermitted }}
2023-03-24 13:35:38 +03:00
<span class="text" data-tooltip-content=" {{ if .Issue .IsPull }} {{ .locale .Tr "repo.issues.dependency.pr_closing_blockedby" }} {{ else }} {{ .locale .Tr "repo.issues.dependency.issue_closing_blockedby" }} {{ end }} ">
2022-06-27 23:58:46 +03:00
<strong> {{ .locale .Tr "repo.issues.dependency.blocked_by_short" }} </strong>
2018-07-18 00:23:58 +03:00
</span>
<div class="ui relaxed divided list">
2018-09-07 05:32:46 +03:00
{{ range .BlockedByDependencies }}
2023-02-13 20:59:59 +03:00
<div class="item dependency {{ if .Issue .IsClosed }} is-closed {{ end }} gt-df gt-ac gt-sb">
<div class="item-left gt-df gt-jc gt-fc gt-f1">
2023-03-24 13:35:38 +03:00
<a class="title" href=" {{ .Issue .Link }} " data-tooltip-content="# {{ .Issue .Index }} {{ .Issue .Title | RenderEmoji $ .Context }} ">
2023-03-06 00:59:05 +03:00
# {{ .Issue .Index }} {{ .Issue .Title | RenderEmoji $ .Context }}
2020-11-10 21:28:07 +03:00
</a>
<div class="text small">
{{ .Repository .OwnerName }} / {{ .Repository .Name }}
</div>
</div>
2023-02-13 20:59:59 +03:00
<div class="item-right gt-df gt-ac">
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 08:06:10 +03:00
{{ if and $ .CanCreateIssueDependencies ( not $ .Repository .IsArchived ) }}
2023-03-24 13:35:38 +03:00
<a class="delete-dependency-button ci muted" data-id=" {{ .Issue .ID }} " data-type="blockedBy" data-tooltip-content=" {{ $ .locale .Tr "repo.issues.dependency.remove_info" }} ">
2021-03-22 07:04:19 +03:00
{{ svg "octicon-trash" 1 6 }}
2018-07-18 00:23:58 +03:00
</a>
{{ end }}
</div>
</div>
{{ end }}
2023-03-28 20:23:25 +03:00
{{ if $ .CanCreateIssueDependencies }}
{{ range .BlockedByDependenciesNotPermitted }}
<div class="item dependency {{ if .Issue .IsClosed }} is-closed {{ end }} gt-df gt-ac gt-sb">
<div class="item-left gt-df gt-jc gt-fc gt-f1">
<div>
<span data-tooltip-content=" {{ $ .locale .Tr "repo.issues.dependency.no_permission.can_remove" }} "> {{ svg "octicon-lock" 1 6 }} </span>
<span class="title" data-tooltip-content="# {{ .Issue .Index }} {{ .Issue .Title | RenderEmoji $ .Context }} ">
# {{ .Issue .Index }} {{ .Issue .Title | RenderEmoji $ .Context }}
</span>
</div>
<div class="text small">
{{ .Repository .OwnerName }} / {{ .Repository .Name }}
</div>
</div>
<div class="item-right gt-df gt-ac">
{{ if and $ .CanCreateIssueDependencies ( not $ .Repository .IsArchived ) }}
<a class="delete-dependency-button ci muted" data-id=" {{ .Issue .ID }} " data-type="blocking" data-tooltip-content=" {{ $ .locale .Tr "repo.issues.dependency.remove_info" }} ">
{{ svg "octicon-trash" 1 6 }}
</a>
{{ end }}
</div>
</div>
{{ end }}
{{ else if .BlockedByDependenciesNotPermitted }}
<div class="item gt-df gt-ac gt-sb">
<span> {{ $ .locale .TrN ( len .BlockedByDependenciesNotPermitted ) "repo.issues.dependency.no_permission_1" "repo.issues.dependency.no_permission_n" ( len .BlockedByDependenciesNotPermitted ) }} </span>
</div>
{{ end }}
2018-07-18 00:23:58 +03:00
</div>
{{ end }}
2019-01-23 21:58:38 +03:00
{{ if and .CanCreateIssueDependencies ( not .Repository .IsArchived ) }}
2018-07-18 00:23:58 +03:00
<div>
2021-11-16 21:18:25 +03:00
<form method="POST" action=" {{ .Issue .Link }} /dependency/add" id="addDependencyForm">
2018-07-18 00:23:58 +03:00
{{ $ .CsrfTokenHtml }}
<div class="ui fluid action input">
2019-05-12 14:10:12 +03:00
<div class="ui search selection dropdown" id="new-dependency-drop-list" data-issue-id=" {{ .Issue .ID }} ">
2018-07-18 00:23:58 +03:00
<input name="newDependency" type="hidden">
2020-11-01 01:15:11 +03:00
{{ svg "octicon-triangle-down" 1 4 "dropdown icon" }}
2018-07-18 00:23:58 +03:00
<input type="text" class="search">
2022-06-27 23:58:46 +03:00
<div class="default text"> {{ .locale .Tr "repo.issues.dependency.add" }} </div>
2018-07-18 00:23:58 +03:00
</div>
<button class="ui green icon button">
2021-05-16 23:18:18 +03:00
{{ svg "octicon-plus" }}
2018-07-18 00:23:58 +03:00
</button>
</div>
</form>
</div>
{{ end }}
</div>
2019-02-18 23:55:04 +03:00
2021-02-28 17:05:55 +03:00
{{ if and .CanCreateIssueDependencies ( not .Repository .IsArchived ) }}
<input type="hidden" id="crossRepoSearch" value=" {{ .AllowCrossRepositoryDependencies }} ">
<div class="ui basic modal remove-dependency">
<div class="ui icon header">
2021-03-22 07:04:19 +03:00
{{ svg "octicon-trash" }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.dependency.remove_header" }}
2021-02-28 17:05:55 +03:00
</div>
<div class="content">
2021-11-16 21:18:25 +03:00
<form method="POST" action=" {{ .Issue .Link }} /dependency/delete" id="removeDependencyForm">
2021-02-28 17:05:55 +03:00
{{ $ .CsrfTokenHtml }}
2023-03-27 19:05:51 +03:00
<input type="hidden" value="" name="removeDependencyID" id="removeDependencyID">
<input type="hidden" value="" name="dependencyType" id="dependencyType">
2021-02-28 17:05:55 +03:00
</form>
<p> {{ if .Issue .IsPull }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.dependency.pr_remove_text" }}
2021-02-28 17:05:55 +03:00
{{ else }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.dependency.issue_remove_text" }}
2021-02-28 17:05:55 +03:00
{{ end }} </p>
</div>
<div class="actions">
2023-03-14 06:34:09 +03:00
<button class="ui red cancel inverted button">
2021-05-16 23:18:18 +03:00
{{ svg "octicon-x" }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.dependency.cancel" }}
2023-03-14 06:34:09 +03:00
</button>
<button class="ui green ok inverted button">
2021-05-16 23:18:18 +03:00
{{ svg "octicon-check" }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.dependency.remove" }}
2023-03-14 06:34:09 +03:00
</button>
2021-02-28 17:05:55 +03:00
</div>
</div>
{{ end }}
{{ end }}
2022-05-05 21:58:37 +03:00
<div class="ui divider"></div>
<div class="ui equal width compact grid">
2023-02-15 14:34:10 +03:00
{{ $ issueReferenceLink : = printf "%s#%d" .Issue .Repo .FullName .Issue .Index }}
2023-03-24 13:35:38 +03:00
<div class="row gt-ac" data-tooltip-content=" {{ $ issueReferenceLink }} ">
2022-06-27 23:58:46 +03:00
<span class="text column truncate"> {{ .locale .Tr "repo.issues.reference_link" $ issueReferenceLink }} </span>
2023-02-13 20:59:59 +03:00
<button class="ui two wide button column gt-p-3" data-clipboard-text=" {{ $ issueReferenceLink }} "> {{ svg "octicon-copy" 1 4 }} </button>
2022-05-05 21:58:37 +03:00
</div>
</div>
2021-02-28 17:05:55 +03:00
{{ if and .IsRepoAdmin ( not .Repository .IsArchived ) }}
2019-02-18 23:55:04 +03:00
<div class="ui divider"></div>
<div class="ui watching">
2022-08-31 18:58:54 +03:00
<button class="fluid ui show-modal button {{ if .Issue .IsLocked }} negative {{ end }} " data-modal="#lock">
2021-01-19 06:02:47 +03:00
{{ if .Issue .IsLocked }}
{{ svg "octicon-key" }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.unlock" }}
2021-01-19 06:02:47 +03:00
{{ else }}
{{ svg "octicon-lock" }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.lock" }}
2021-01-19 06:02:47 +03:00
{{ end }}
</button>
2019-02-18 23:55:04 +03:00
</div>
<div class="ui tiny modal" id="lock">
<div class="header">
2022-08-31 18:58:54 +03:00
{{ if .Issue .IsLocked }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.unlock.title" }}
2021-02-28 17:05:55 +03:00
{{ else }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.lock.title" }}
2021-02-28 17:05:55 +03:00
{{ end }}
2019-02-18 23:55:04 +03:00
</div>
2021-03-21 21:58:28 +03:00
<div class="content">
<div class="ui warning message text left">
2022-08-31 18:58:54 +03:00
{{ if .Issue .IsLocked }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.unlock.notice_1" }} <br>
{{ .locale .Tr "repo.issues.unlock.notice_2" }} <br>
2021-03-21 21:58:28 +03:00
{{ else }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.lock.notice_1" }} <br>
{{ .locale .Tr "repo.issues.lock.notice_2" }} <br>
{{ .locale .Tr "repo.issues.lock.notice_3" }} <br>
2021-03-21 21:58:28 +03:00
{{ end }}
</div>
2019-02-18 23:55:04 +03:00
2022-08-31 18:58:54 +03:00
<form class="ui form" action=" {{ .Issue .Link }} {{ if .Issue .IsLocked }} /unlock {{ else }} /lock {{ end }} "
2021-03-21 21:58:28 +03:00
method="post">
{{ .CsrfTokenHtml }}
2019-02-18 23:55:04 +03:00
2022-08-31 18:58:54 +03:00
{{ if not .Issue .IsLocked }}
2021-03-21 21:58:28 +03:00
<div class="field">
2022-08-31 18:58:54 +03:00
<strong> {{ .locale .Tr "repo.issues.lock.reason" }} </strong>
2021-03-21 21:58:28 +03:00
</div>
2019-02-18 23:55:04 +03:00
2021-03-21 21:58:28 +03:00
<div class="field">
<div class="ui fluid dropdown selection" tabindex="0">
2019-02-18 23:55:04 +03:00
2021-03-21 21:58:28 +03:00
<select name="reason">
<option value=""> </option>
{{ range .LockReasons }}
<option value=" {{ . }} "> {{ . }} </option>
{{ end }}
</select>
{{ svg "octicon-triangle-down" 1 4 "dropdown icon" }}
2019-02-18 23:55:04 +03:00
2021-03-21 21:58:28 +03:00
<div class="default text"> </div>
2019-02-18 23:55:04 +03:00
2023-02-14 14:53:54 +03:00
<div class="menu">
2021-03-21 21:58:28 +03:00
{{ range .LockReasons }}
<div class="item" data-value=" {{ . }} "> {{ . }} </div>
{{ end }}
</div>
2021-02-28 17:05:55 +03:00
</div>
2019-02-18 23:55:04 +03:00
</div>
2021-03-21 21:58:28 +03:00
{{ end }}
2019-02-18 23:55:04 +03:00
2021-03-21 21:58:28 +03:00
<div class="text right actions">
2023-03-14 06:34:09 +03:00
<button class="ui cancel button"> {{ .locale .Tr "settings.cancel" }} </button>
2021-03-21 21:58:28 +03:00
<button class="ui red button">
2022-08-31 18:58:54 +03:00
{{ if .Issue .IsLocked }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.unlock_confirm" }}
2021-03-21 21:58:28 +03:00
{{ else }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.lock_confirm" }}
2021-03-21 21:58:28 +03:00
{{ end }}
</button>
</div>
</form>
</div>
2018-07-18 00:23:58 +03:00
</div>
2023-02-13 20:59:59 +03:00
<button class="fluid ui show-modal button negative gt-mt-3" data-modal="#delete">
2022-03-09 03:38:11 +03:00
{{ svg "octicon-trash" }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.delete" }}
2022-03-09 03:38:11 +03:00
</button>
<div class="ui basic modal" id="delete">
<div class="ui icon header">
2022-06-19 13:05:15 +03:00
{{ if .Issue .IsPull }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.pulls.delete.title" }}
2022-06-19 13:05:15 +03:00
{{ else }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.delete.title" }}
2022-06-19 13:05:15 +03:00
{{ end }}
2022-03-09 03:38:11 +03:00
</div>
<div class="content center">
<p>
2022-06-19 13:05:15 +03:00
{{ if .Issue .IsPull }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.pulls.delete.text" }}
2022-06-19 13:05:15 +03:00
{{ else }}
2022-06-27 23:58:46 +03:00
{{ .locale .Tr "repo.issues.delete.text" }}
2022-06-19 13:05:15 +03:00
{{ end }}
2022-03-09 03:38:11 +03:00
</p>
</div>
<form action=" {{ .Issue .Link }} /delete" method="post">
{{ .CsrfTokenHtml }}
<div class="center actions">
2023-03-14 06:34:09 +03:00
<button class="ui basic cancel inverted button"> {{ .locale .Tr "settings.cancel" }} </button>
2022-06-27 23:58:46 +03:00
<button class="ui basic red inverted button"> {{ .locale .Tr "modal.yes" }} </button>
2022-03-09 03:38:11 +03:00
</div>
</form>
</div>
2018-07-18 00:23:58 +03:00
{{ end }}
2022-04-28 18:45:33 +03:00
{{ if and .Issue .IsPull .IsIssuePoster ( not .Issue .IsClosed ) }}
{{ if and ( not ( eq .Issue .PullRequest .HeadRepo .FullName .Issue .PullRequest .BaseRepo .FullName ) ) .CanWriteToHeadRepo }}
<div class="ui divider"></div>
<div class="inline field">
2023-03-24 13:35:38 +03:00
<div class="ui checkbox" id="allow-edits-from-maintainers"
2022-04-28 18:45:33 +03:00
data-url=" {{ .Issue .Link }} "
Use a general approach to show tooltip, fix temporary tooltip bug (#23574)
## TLDR
* Improve performance: lazy creating the tippy instances.
* Transparently support all "tooltip" elements, no need to call
`initTooltip` again and again.
* Fix a temporary tooltip re-entrance bug, which causes showing temp
content forever.
* Upgrade vue3-calendar-heatmap to 2.0.2 with lazy tippy init
(initHeatmap time decreases from 100ms to 50ms)
## Details
### The performance
Creating a lot of tippy tooltip instances is expensive. This PR doesn't
create all tippy tooltip instances, instead, it only adds "mouseover"
event listener to necessary elements, and then switches to the tippy
tooltip
### The general approach for all tooltips
Before, dynamically generated tooltips need to be called with
`initTooltip`.
After, use MutationObserver to:
* Attach the event listeners to newly created tooltip elements, work for
Vue (easier than before)
* Catch changed attributes and update the tooltip content (better than
before)
It does help a lot, eg:
https://github.com/go-gitea/gitea/blob/1a4efa0ee9a49d48549be7479a46be133b9bc260/web_src/js/components/PullRequestMergeForm.vue#L33-L36
### Temporary tooltip re-entrance bug
To reproduce, on try.gitea.io, click the "copy clone url" quickly, then
the tooltip will be "Copied!" forever.
After this PR, with the help of `attachTippyTooltip`, the tooltip
content could be reset to the default correctly.
### Other changes
* `data-tooltip-content` is preferred from now on, the old
`data-content` may cause conflicts with other modules.
* `data-placement` was only used for tooltip, so it's renamed to
`data-tooltip-placement`, and removed from `createTippy`.
2023-03-23 12:56:15 +03:00
data-tooltip-content=" {{ .locale .Tr "repo.pulls.allow_edits_from_maintainers_desc" }} "
2022-06-27 23:58:46 +03:00
data-prompt-error=" {{ .locale .Tr "repo.pulls.allow_edits_from_maintainers_err" }} "
2022-04-28 18:45:33 +03:00
>
2022-06-27 23:58:46 +03:00
<label><strong> {{ .locale .Tr "repo.pulls.allow_edits_from_maintainers" }} </strong></label>
2022-04-28 18:45:33 +03:00
<input type="checkbox" {{ if .Issue .PullRequest .AllowMaintainerEdit }} checked {{ end }} >
</div>
</div>
{{ end }}
{{ end }}
2021-02-28 17:05:55 +03:00
</div>
</div>
