2017-07-12 04:23:41 +03:00
// Copyright 2017 The Gogs Authors. All rights reserved.
2022-11-27 21:20:29 +03:00
// SPDX-License-Identifier: MIT
2017-07-12 04:23:41 +03:00
2022-09-02 22:18:23 +03:00
package integration
2017-07-12 04:23:41 +03:00
import (
2018-01-07 01:55:53 +03:00
"fmt"
2017-07-12 04:23:41 +03:00
"net/http"
2018-11-01 06:40:49 +03:00
"net/url"
2017-07-12 04:23:41 +03:00
"testing"
2021-12-10 11:14:24 +03:00
asymkey_model "code.gitea.io/gitea/models/asymkey"
2023-01-18 00:46:03 +03:00
auth_model "code.gitea.io/gitea/models/auth"
2021-11-28 14:58:28 +03:00
"code.gitea.io/gitea/models/perm"
2021-12-10 04:27:50 +03:00
repo_model "code.gitea.io/gitea/models/repo"
2021-11-16 11:53:21 +03:00
"code.gitea.io/gitea/models/unittest"
2021-11-24 12:49:20 +03:00
user_model "code.gitea.io/gitea/models/user"
2019-05-11 13:21:34 +03:00
api "code.gitea.io/gitea/modules/structs"
2022-09-02 22:18:23 +03:00
"code.gitea.io/gitea/tests"
2019-08-23 19:40:30 +03:00
"github.com/stretchr/testify/assert"
2017-07-12 04:23:41 +03:00
)
func TestViewDeployKeysNoLogin ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2017-07-12 04:23:41 +03:00
req := NewRequest ( t , "GET" , "/api/v1/repos/user2/repo1/keys" )
MakeRequest ( t , req , http . StatusUnauthorized )
}
func TestCreateDeployKeyNoLogin ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2017-07-12 04:23:41 +03:00
req := NewRequestWithJSON ( t , "POST" , "/api/v1/repos/user2/repo1/keys" , api . CreateKeyOption {
Title : "title" ,
Key : "key" ,
} )
MakeRequest ( t , req , http . StatusUnauthorized )
}
func TestGetDeployKeyNoLogin ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2017-07-12 04:23:41 +03:00
req := NewRequest ( t , "GET" , "/api/v1/repos/user2/repo1/keys/1" )
MakeRequest ( t , req , http . StatusUnauthorized )
}
func TestDeleteDeployKeyNoLogin ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2017-07-12 04:23:41 +03:00
req := NewRequest ( t , "DELETE" , "/api/v1/repos/user2/repo1/keys/1" )
MakeRequest ( t , req , http . StatusUnauthorized )
}
2018-01-07 01:55:53 +03:00
func TestCreateReadOnlyDeployKey ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2022-08-16 05:22:25 +03:00
repo := unittest . AssertExistsAndLoadBean ( t , & repo_model . Repository { Name : "repo1" } )
repoOwner := unittest . AssertExistsAndLoadBean ( t , & user_model . User { ID : repo . OwnerID } )
2018-01-07 01:55:53 +03:00
session := loginUser ( t , repoOwner . Name )
Redesign Scoped Access Tokens (#24767)
## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
- `activitypub`
- `admin` (hidden if user is not a site admin)
- `misc`
- `notification`
- `organization`
- `package`
- `issue`
- `repository`
- `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
- `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
- `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
- _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
- _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
- _This should be addressed in this PR_
- For example:
```go
m.Group("/users/{username}/orgs", func() {
m.Get("", reqToken(), org.ListUserOrgs)
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-04 21:57:16 +03:00
token := getTokenForLoggedInUser ( t , session , auth_model . AccessTokenScopeWriteRepository )
2023-12-22 02:59:59 +03:00
keysURL := fmt . Sprintf ( "/api/v1/repos/%s/%s/keys" , repoOwner . Name , repo . Name )
2018-01-07 01:55:53 +03:00
rawKeyBody := api . CreateKeyOption {
Title : "read-only" ,
2020-10-09 09:52:57 +03:00
Key : "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQC4cn+iXnA4KvcQYSV88vGn0Yi91vG47t1P7okprVmhNTkipNRIHWr6WdCO4VDr/cvsRkuVJAsLO2enwjGWWueOO6BodiBgyAOZ/5t5nJNMCNuLGT5UIo/RI1b0WRQwxEZTRjt6mFNw6lH14wRd8ulsr9toSWBPMOGWoYs1PDeDL0JuTjL+tr1SZi/EyxCngpYszKdXllJEHyI79KQgeD0Vt3pTrkbNVTOEcCNqZePSVmUH8X8Vhugz3bnE0/iE9Pb5fkWO9c4AnM1FgI/8Bvp27Fw2ShryIXuR6kKvUqhVMTuOSDHwu6A8jLE5Owt3GAYugDpDYuwTVNGrHLXKpPzrGGPE/jPmaLCMZcsdkec95dYeU3zKODEm8UQZFhmJmDeWVJ36nGrGZHL4J5aTTaeFUJmmXDaJYiJ+K2/ioKgXqnXvltu0A9R8/LGy4nrTJRr4JMLuJFoUXvGm1gXQ70w2LSpk6yl71RNC0hCtsBe8BP8IhYCM0EP5jh7eCMQZNvM= nocomment\n" ,
2018-01-07 01:55:53 +03:00
ReadOnly : true ,
}
2023-12-22 02:59:59 +03:00
req := NewRequestWithJSON ( t , "POST" , keysURL , rawKeyBody ) .
AddTokenAuth ( token )
2022-12-02 06:39:42 +03:00
resp := MakeRequest ( t , req , http . StatusCreated )
2018-01-07 01:55:53 +03:00
var newDeployKey api . DeployKey
DecodeJSON ( t , resp , & newDeployKey )
2021-12-10 11:14:24 +03:00
unittest . AssertExistsAndLoadBean ( t , & asymkey_model . DeployKey {
2018-01-07 01:55:53 +03:00
ID : newDeployKey . ID ,
Name : rawKeyBody . Title ,
Content : rawKeyBody . Key ,
2021-11-28 14:58:28 +03:00
Mode : perm . AccessModeRead ,
2018-01-07 01:55:53 +03:00
} )
2023-11-25 20:21:21 +03:00
// Using the ID of a key that does not belong to the repository must fail
{
2023-12-22 02:59:59 +03:00
req := NewRequest ( t , "GET" , fmt . Sprintf ( "/api/v1/repos/%s/%s/keys/%d" , repoOwner . Name , repo . Name , newDeployKey . ID ) ) .
AddTokenAuth ( token )
2023-11-25 20:21:21 +03:00
MakeRequest ( t , req , http . StatusOK )
session5 := loginUser ( t , "user5" )
token5 := getTokenForLoggedInUser ( t , session5 , auth_model . AccessTokenScopeWriteRepository )
2023-12-22 02:59:59 +03:00
req = NewRequest ( t , "GET" , fmt . Sprintf ( "/api/v1/repos/user5/repo4/keys/%d" , newDeployKey . ID ) ) .
AddTokenAuth ( token5 )
2023-11-25 20:21:21 +03:00
MakeRequest ( t , req , http . StatusNotFound )
}
2018-01-07 01:55:53 +03:00
}
func TestCreateReadWriteDeployKey ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2022-08-16 05:22:25 +03:00
repo := unittest . AssertExistsAndLoadBean ( t , & repo_model . Repository { Name : "repo1" } )
repoOwner := unittest . AssertExistsAndLoadBean ( t , & user_model . User { ID : repo . OwnerID } )
2018-01-07 01:55:53 +03:00
session := loginUser ( t , repoOwner . Name )
Redesign Scoped Access Tokens (#24767)
## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
- `activitypub`
- `admin` (hidden if user is not a site admin)
- `misc`
- `notification`
- `organization`
- `package`
- `issue`
- `repository`
- `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
- `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
- `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
- _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
- _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
- _This should be addressed in this PR_
- For example:
```go
m.Group("/users/{username}/orgs", func() {
m.Get("", reqToken(), org.ListUserOrgs)
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-04 21:57:16 +03:00
token := getTokenForLoggedInUser ( t , session , auth_model . AccessTokenScopeWriteRepository )
2023-12-22 02:59:59 +03:00
keysURL := fmt . Sprintf ( "/api/v1/repos/%s/%s/keys" , repoOwner . Name , repo . Name )
2018-01-07 01:55:53 +03:00
rawKeyBody := api . CreateKeyOption {
Title : "read-write" ,
2020-10-09 09:52:57 +03:00
Key : "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQC4cn+iXnA4KvcQYSV88vGn0Yi91vG47t1P7okprVmhNTkipNRIHWr6WdCO4VDr/cvsRkuVJAsLO2enwjGWWueOO6BodiBgyAOZ/5t5nJNMCNuLGT5UIo/RI1b0WRQwxEZTRjt6mFNw6lH14wRd8ulsr9toSWBPMOGWoYs1PDeDL0JuTjL+tr1SZi/EyxCngpYszKdXllJEHyI79KQgeD0Vt3pTrkbNVTOEcCNqZePSVmUH8X8Vhugz3bnE0/iE9Pb5fkWO9c4AnM1FgI/8Bvp27Fw2ShryIXuR6kKvUqhVMTuOSDHwu6A8jLE5Owt3GAYugDpDYuwTVNGrHLXKpPzrGGPE/jPmaLCMZcsdkec95dYeU3zKODEm8UQZFhmJmDeWVJ36nGrGZHL4J5aTTaeFUJmmXDaJYiJ+K2/ioKgXqnXvltu0A9R8/LGy4nrTJRr4JMLuJFoUXvGm1gXQ70w2LSpk6yl71RNC0hCtsBe8BP8IhYCM0EP5jh7eCMQZNvM= nocomment\n" ,
2018-01-07 01:55:53 +03:00
}
2023-12-22 02:59:59 +03:00
req := NewRequestWithJSON ( t , "POST" , keysURL , rawKeyBody ) .
AddTokenAuth ( token )
2022-12-02 06:39:42 +03:00
resp := MakeRequest ( t , req , http . StatusCreated )
2018-01-07 01:55:53 +03:00
var newDeployKey api . DeployKey
DecodeJSON ( t , resp , & newDeployKey )
2021-12-10 11:14:24 +03:00
unittest . AssertExistsAndLoadBean ( t , & asymkey_model . DeployKey {
2018-01-07 01:55:53 +03:00
ID : newDeployKey . ID ,
Name : rawKeyBody . Title ,
Content : rawKeyBody . Key ,
2021-11-28 14:58:28 +03:00
Mode : perm . AccessModeWrite ,
2018-01-07 01:55:53 +03:00
} )
}
2018-11-01 06:40:49 +03:00
func TestCreateUserKey ( t * testing . T ) {
2022-09-02 22:18:23 +03:00
defer tests . PrepareTestEnv ( t ) ( )
2022-08-16 05:22:25 +03:00
user := unittest . AssertExistsAndLoadBean ( t , & user_model . User { Name : "user1" } )
2018-11-01 06:40:49 +03:00
session := loginUser ( t , "user1" )
Redesign Scoped Access Tokens (#24767)
## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
- `activitypub`
- `admin` (hidden if user is not a site admin)
- `misc`
- `notification`
- `organization`
- `package`
- `issue`
- `repository`
- `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
- `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
- `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
- _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
- _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
- _This should be addressed in this PR_
- For example:
```go
m.Group("/users/{username}/orgs", func() {
m.Get("", reqToken(), org.ListUserOrgs)
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-04 21:57:16 +03:00
token := url . QueryEscape ( getTokenForLoggedInUser ( t , session , auth_model . AccessTokenScopeWriteUser ) )
2018-11-01 06:40:49 +03:00
keyType := "ssh-rsa"
2020-10-09 09:52:57 +03:00
keyContent := "AAAAB3NzaC1yc2EAAAADAQABAAABgQC4cn+iXnA4KvcQYSV88vGn0Yi91vG47t1P7okprVmhNTkipNRIHWr6WdCO4VDr/cvsRkuVJAsLO2enwjGWWueOO6BodiBgyAOZ/5t5nJNMCNuLGT5UIo/RI1b0WRQwxEZTRjt6mFNw6lH14wRd8ulsr9toSWBPMOGWoYs1PDeDL0JuTjL+tr1SZi/EyxCngpYszKdXllJEHyI79KQgeD0Vt3pTrkbNVTOEcCNqZePSVmUH8X8Vhugz3bnE0/iE9Pb5fkWO9c4AnM1FgI/8Bvp27Fw2ShryIXuR6kKvUqhVMTuOSDHwu6A8jLE5Owt3GAYugDpDYuwTVNGrHLXKpPzrGGPE/jPmaLCMZcsdkec95dYeU3zKODEm8UQZFhmJmDeWVJ36nGrGZHL4J5aTTaeFUJmmXDaJYiJ+K2/ioKgXqnXvltu0A9R8/LGy4nrTJRr4JMLuJFoUXvGm1gXQ70w2LSpk6yl71RNC0hCtsBe8BP8IhYCM0EP5jh7eCMQZNvM="
2018-11-01 06:40:49 +03:00
rawKeyBody := api . CreateKeyOption {
Title : "test-key" ,
Key : keyType + " " + keyContent ,
}
2023-12-22 02:59:59 +03:00
req := NewRequestWithJSON ( t , "POST" , "/api/v1/user/keys" , rawKeyBody ) .
AddTokenAuth ( token )
2022-12-02 06:39:42 +03:00
resp := MakeRequest ( t , req , http . StatusCreated )
2018-11-01 06:40:49 +03:00
var newPublicKey api . PublicKey
DecodeJSON ( t , resp , & newPublicKey )
2022-06-04 22:18:50 +03:00
fingerprint , err := asymkey_model . CalcFingerprint ( rawKeyBody . Key )
assert . NoError ( t , err )
2021-12-10 11:14:24 +03:00
unittest . AssertExistsAndLoadBean ( t , & asymkey_model . PublicKey {
2022-06-04 22:18:50 +03:00
ID : newPublicKey . ID ,
OwnerID : user . ID ,
Name : rawKeyBody . Title ,
Fingerprint : fingerprint ,
Mode : perm . AccessModeWrite ,
2018-11-01 06:40:49 +03:00
} )
// Search by fingerprint
2023-12-22 02:59:59 +03:00
req = NewRequest ( t , "GET" , fmt . Sprintf ( "/api/v1/user/keys?fingerprint=%s" , newPublicKey . Fingerprint ) ) .
AddTokenAuth ( token )
2022-12-02 06:39:42 +03:00
resp = MakeRequest ( t , req , http . StatusOK )
2018-11-01 06:40:49 +03:00
var fingerprintPublicKeys [ ] api . PublicKey
DecodeJSON ( t , resp , & fingerprintPublicKeys )
assert . Equal ( t , newPublicKey . Fingerprint , fingerprintPublicKeys [ 0 ] . Fingerprint )
assert . Equal ( t , newPublicKey . ID , fingerprintPublicKeys [ 0 ] . ID )
assert . Equal ( t , user . ID , fingerprintPublicKeys [ 0 ] . Owner . ID )
2023-12-22 02:59:59 +03:00
req = NewRequest ( t , "GET" , fmt . Sprintf ( "/api/v1/users/%s/keys?fingerprint=%s" , user . Name , newPublicKey . Fingerprint ) ) .
AddTokenAuth ( token )
2022-12-02 06:39:42 +03:00
resp = MakeRequest ( t , req , http . StatusOK )
2018-11-01 06:40:49 +03:00
DecodeJSON ( t , resp , & fingerprintPublicKeys )
assert . Equal ( t , newPublicKey . Fingerprint , fingerprintPublicKeys [ 0 ] . Fingerprint )
assert . Equal ( t , newPublicKey . ID , fingerprintPublicKeys [ 0 ] . ID )
assert . Equal ( t , user . ID , fingerprintPublicKeys [ 0 ] . Owner . ID )
// Fail search by fingerprint
2023-12-22 02:59:59 +03:00
req = NewRequest ( t , "GET" , fmt . Sprintf ( "/api/v1/user/keys?fingerprint=%sA" , newPublicKey . Fingerprint ) ) .
AddTokenAuth ( token )
2022-12-02 06:39:42 +03:00
resp = MakeRequest ( t , req , http . StatusOK )
2018-11-01 06:40:49 +03:00
DecodeJSON ( t , resp , & fingerprintPublicKeys )
assert . Len ( t , fingerprintPublicKeys , 0 )
// Fail searching for wrong users key
2023-12-22 02:59:59 +03:00
req = NewRequest ( t , "GET" , fmt . Sprintf ( "/api/v1/users/%s/keys?fingerprint=%s" , "user2" , newPublicKey . Fingerprint ) ) .
AddTokenAuth ( token )
2022-12-02 06:39:42 +03:00
resp = MakeRequest ( t , req , http . StatusOK )
2018-11-01 06:40:49 +03:00
DecodeJSON ( t , resp , & fingerprintPublicKeys )
assert . Len ( t , fingerprintPublicKeys , 0 )
// Now login as user 2
session2 := loginUser ( t , "user2" )
2023-12-22 02:59:59 +03:00
token2 := getTokenForLoggedInUser ( t , session2 , auth_model . AccessTokenScopeWriteUser )
2018-11-01 06:40:49 +03:00
// Should find key even though not ours, but we shouldn't know whose it is
2023-12-22 02:59:59 +03:00
req = NewRequest ( t , "GET" , fmt . Sprintf ( "/api/v1/user/keys?fingerprint=%s" , newPublicKey . Fingerprint ) ) .
AddTokenAuth ( token2 )
2022-12-02 06:39:42 +03:00
resp = MakeRequest ( t , req , http . StatusOK )
2018-11-01 06:40:49 +03:00
DecodeJSON ( t , resp , & fingerprintPublicKeys )
assert . Equal ( t , newPublicKey . Fingerprint , fingerprintPublicKeys [ 0 ] . Fingerprint )
assert . Equal ( t , newPublicKey . ID , fingerprintPublicKeys [ 0 ] . ID )
assert . Nil ( t , fingerprintPublicKeys [ 0 ] . Owner )
// Should find key even though not ours, but we shouldn't know whose it is
2023-12-22 02:59:59 +03:00
req = NewRequest ( t , "GET" , fmt . Sprintf ( "/api/v1/users/%s/keys?fingerprint=%s" , user . Name , newPublicKey . Fingerprint ) ) .
AddTokenAuth ( token2 )
2022-12-02 06:39:42 +03:00
resp = MakeRequest ( t , req , http . StatusOK )
2018-11-01 06:40:49 +03:00
DecodeJSON ( t , resp , & fingerprintPublicKeys )
assert . Equal ( t , newPublicKey . Fingerprint , fingerprintPublicKeys [ 0 ] . Fingerprint )
assert . Equal ( t , newPublicKey . ID , fingerprintPublicKeys [ 0 ] . ID )
assert . Nil ( t , fingerprintPublicKeys [ 0 ] . Owner )
// Fail when searching for key if it is not ours
2023-12-22 02:59:59 +03:00
req = NewRequest ( t , "GET" , fmt . Sprintf ( "/api/v1/users/%s/keys?fingerprint=%s" , "user2" , newPublicKey . Fingerprint ) ) .
AddTokenAuth ( token2 )
2022-12-02 06:39:42 +03:00
resp = MakeRequest ( t , req , http . StatusOK )
2018-11-01 06:40:49 +03:00
DecodeJSON ( t , resp , & fingerprintPublicKeys )
assert . Len ( t , fingerprintPublicKeys , 0 )
}