mirror of
https://github.com/go-gitea/gitea.git
synced 2024-12-23 21:34:43 +03:00
36887ed392
1. The previous color contrast calculation function was incorrect at least for the `#84b6eb` where it output low-contrast white instead of black. I've rewritten these functions now to accept hex colors and to match GitHub's calculation and to output pure white/black for maximum contrast. Before and after: <img width="94" alt="Screenshot 2024-04-02 at 01 53 46" src="https://github.com/go-gitea/gitea/assets/115237/00b39e15-a377-4458-95cf-ceec74b78228"><img width="90" alt="Screenshot 2024-04-02 at 01 51 30" src="https://github.com/go-gitea/gitea/assets/115237/1677067a-8d8f-47eb-82c0-76330deeb775"> 2. Fix project-related issues: - Expose the new `ContrastColor` function as template helper and use it for project cards, replacing the previous JS solution which eliminates a flash of wrong color on page load. - Fix a bug where if editing a project title, the counter would get lost. - Move `rgbToHex` function to color utils. @HesterG fyi --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io>
64 lines
1.6 KiB
Go
64 lines
1.6 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
package util
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_HexToRBGColor(t *testing.T) {
|
|
cases := []struct {
|
|
colorString string
|
|
expectedR float64
|
|
expectedG float64
|
|
expectedB float64
|
|
}{
|
|
{"2b8685", 43, 134, 133},
|
|
{"1e1", 17, 238, 17},
|
|
{"#1e1", 17, 238, 17},
|
|
{"1e16", 17, 238, 17},
|
|
{"3bb6b3", 59, 182, 179},
|
|
{"#3bb6b399", 59, 182, 179},
|
|
{"#0", 0, 0, 0},
|
|
{"#00000", 0, 0, 0},
|
|
{"#1234567", 0, 0, 0},
|
|
}
|
|
for n, c := range cases {
|
|
r, g, b := HexToRBGColor(c.colorString)
|
|
assert.Equal(t, c.expectedR, r, "case %d: error R should match: expected %f, but get %f", n, c.expectedR, r)
|
|
assert.Equal(t, c.expectedG, g, "case %d: error G should match: expected %f, but get %f", n, c.expectedG, g)
|
|
assert.Equal(t, c.expectedB, b, "case %d: error B should match: expected %f, but get %f", n, c.expectedB, b)
|
|
}
|
|
}
|
|
|
|
func Test_UseLightText(t *testing.T) {
|
|
cases := []struct {
|
|
color string
|
|
expected string
|
|
}{
|
|
{"#d73a4a", "#fff"},
|
|
{"#0075ca", "#fff"},
|
|
{"#cfd3d7", "#000"},
|
|
{"#a2eeef", "#000"},
|
|
{"#7057ff", "#fff"},
|
|
{"#008672", "#fff"},
|
|
{"#e4e669", "#000"},
|
|
{"#d876e3", "#000"},
|
|
{"#ffffff", "#000"},
|
|
{"#2b8684", "#fff"},
|
|
{"#2b8786", "#fff"},
|
|
{"#2c8786", "#000"},
|
|
{"#3bb6b3", "#000"},
|
|
{"#7c7268", "#fff"},
|
|
{"#7e716c", "#fff"},
|
|
{"#81706d", "#fff"},
|
|
{"#807070", "#fff"},
|
|
{"#84b6eb", "#000"},
|
|
}
|
|
for n, c := range cases {
|
|
assert.Equal(t, c.expected, ContrastColor(c.color), "case %d: error should match", n)
|
|
}
|
|
}
|