1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-22 17:34:03 +03:00
gitea/routers/common
wxiaoguang 580e21dd2e
Refactor LFS SSH and internal routers (#32473)
Gitea instance keeps reporting a lot of errors like "LFS SSH transfer connection denied, pure SSH protocol is disabled". When starting debugging the problem, there are more problems found. Try to address most of them:

* avoid unnecessary server side error logs (change `fail()` to not log them)
* figure out the broken tests/user2/lfs.git (added comments)
* avoid `migratePushMirrors` failure when a repository doesn't exist (ignore them)
* avoid "Authorization" (internal&lfs) header conflicts, remove the tricky "swapAuth" and use "X-Gitea-Internal-Auth"
* make internal token comparing constant time (it wasn't a serous problem because in a real world it's nearly impossible to timing-attack the token, but good to fix and backport)
* avoid duplicate routers (introduce AddOwnerRepoGitLFSRoutes)
* avoid "internal (private)" routes using session/web context (they should use private context)
* fix incorrect "path" usages (use "filepath")
* fix incorrect mocked route point handling (need to check func nil correctly)
* split some tests from "git general tests" to "git misc tests" (to keep "git_general_test.go" simple)

Still no correct result for Git LFS SSH tests. So the code is kept there
(`tests/integration/git_lfs_ssh_test.go`) and a FIXME explains the details.
2024-11-12 02:38:22 +00:00
..
auth.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
compare.go feat(api): implement branch/commit comparison API (#30349) 2024-04-16 11:45:04 +08:00
db.go Refactor the DB migration system slightly (#32344) 2024-10-27 19:54:35 +08:00
deadline.go Fix milestone deadline and date related problems (#32339) 2024-11-05 07:46:40 +00:00
errpage_test.go Clean up template locale usage (#27856) 2023-10-31 22:11:48 +08:00
errpage.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
lfs.go Refactor LFS SSH and internal routers (#32473) 2024-11-12 02:38:22 +00:00
markup.go Fix missing images in editor preview due to wrong links (#31299) 2024-06-17 14:16:14 +08:00
middleware.go Refactor route path normalization (#31381) 2024-06-17 23:28:47 +00:00
redirect.go Refactor AppURL usage (#30885) 2024-05-07 08:26:13 +00:00
serve.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00