shaba/libvirt-python
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt-python.git synced 2025-08-02 04:21:59 +03:00
Code Issues Projects Releases Activity

don't overrun buffer when converting cpumap

Browse Source 
If we pass large(more than cpunum) cpu mask to any libvirt_virDomainPin*
function, it could leads to crash. So we have to check tuple size in
virPyCpumapConvert and ignore extra tuple members.

Since we allocate a zeroed buffer, we don't need to bother with setting
the bits to zero.

Signed-off-by: Konstantin Neumoin <kneumoin@virtuozzo.com>
This commit is contained in:
Konstantin Neumoin
2016-11-03 20:05:52 +03:00
committed by Peter Krempa
parent a03d782b3e
commit 4a77ad764b
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libvirt-utils.c
View File

@ -623,7 +623,7 @@ virPyCpumapConvert(int cpunum,
return -1; return -1;
} }
for (i = 0; i < tuple_size; i++) { for (i = 0; i < cpunum && i < tuple_size; i++) {
PyObject *flag = PyTuple_GetItem(pycpumap, i); PyObject *flag = PyTuple_GetItem(pycpumap, i);
bool b; bool b;
@ -634,12 +634,7 @@ virPyCpumapConvert(int cpunum,
if (b) if (b)
VIR_USE_CPU(*cpumapptr, i); VIR_USE_CPU(*cpumapptr, i);
else
VIR_UNUSE_CPU(*cpumapptr, i);
} }
for (; i < cpunum; i++)
VIR_UNUSE_CPU(*cpumapptr, i);
return 0; return 0;
} }