mirror of
https://gitlab.com/libvirt/libvirt-python.git
synced 2025-12-16 12:23:50 +03:00
python: Fix bindings for virDomainSnapshotGet{Domain,Connect}
https://bugzilla.redhat.com/show_bug.cgi?id=895882 virDomainSnapshot.getDomain() and virDomainSnapshot.getConnect() wrappers around virDomainSnapshotGet{Domain,Connect} were not supposed to be ever implemented. The class should contain proper domain() and connect() accessors that fetch python objects stored internally within the class. While domain() was already provided, connect() was missing. This patch adds connect() method to virDomainSnapshot class and reimplements getDomain() and getConnect() methods as aliases to domain() and connect() for backward compatibility. (cherry picked from commit 7b35fd718d2156224797ace08f752dfbb9884520) Conflicts: python/generator.py -- context
This commit is contained in:
@@ -497,6 +497,8 @@ skip_function = (
|
||||
"virNWFilterGetConnect",
|
||||
"virStoragePoolGetConnect",
|
||||
"virStorageVolGetConnect",
|
||||
"virDomainSnapshotGetConnect",
|
||||
"virDomainSnapshotGetDomain",
|
||||
)
|
||||
|
||||
qemu_skip_function = (
|
||||
@@ -877,7 +879,6 @@ classes_destructors = {
|
||||
|
||||
class_skip_connect_impl = {
|
||||
"virConnect" : True,
|
||||
"virDomainSnapshot": True,
|
||||
}
|
||||
|
||||
class_domain_impl = {
|
||||
@@ -1358,6 +1359,7 @@ def buildWrappers(module):
|
||||
" self._conn = conn._conn\n")
|
||||
elif classname in [ "virDomainSnapshot" ]:
|
||||
classes.write(" self._dom = dom\n")
|
||||
classes.write(" self._conn = dom.connect()\n")
|
||||
classes.write(" if _obj != None:self._o = _obj;return\n")
|
||||
classes.write(" self._o = None\n\n");
|
||||
destruct=None
|
||||
|
||||
@@ -1,3 +1,11 @@
|
||||
def getConnect(self):
|
||||
"""Get the connection that owns the domain that a snapshot was created for"""
|
||||
return self.connect()
|
||||
|
||||
def getDomain(self):
|
||||
"""Get the domain that a snapshot was created for"""
|
||||
return self.domain()
|
||||
|
||||
def listAllChildren(self, flags):
|
||||
"""List all child snapshots and returns a list of snapshot objects"""
|
||||
ret = libvirtmod.virDomainSnapshotListAllChildren(self._o, flags)
|
||||
|
||||
Reference in New Issue
Block a user