shaba/libvirt-python
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt-python.git synced 2025-12-20 00:23:49 +03:00
Code Issues Projects Releases Activity

sanitytest: move python to C API mapping check into a helper method

Browse Source 
This is a step towards turning the sanitytest.py file into a normal
python unittest.

Best viewed with the '-b' flag to diff.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé
2022-03-22 17:52:55 +00:00
parent 45fa54ab67
commit 87e62db6d3
1 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
sanitytest.py
View File

@@ -330,24 +330,24 @@ for name, (klass, func, cname) in sorted(finalklassmap.items()):
fail = True
# Phase 6: Validate that every python API has a corresponding C API
for klass in gotfunctions:
if klass == "libvirtError":
continue
for func in sorted(gotfunctions[klass]):
# These are pure python methods with no C APi
if func in ["connect", "getConnect", "domain", "getDomain",
"virEventInvokeFreeCallback", "network",
"sparseRecvAll", "sparseSendAll"]:
# Validate that every python API has a corresponding C API
def validate_python_to_c_api_mappings(gotfunctions, usedfunctions):
for klass in gotfunctions:
if klass == "libvirtError":
continue
for func in sorted(gotfunctions[klass]):
# These are pure python methods with no C APi
if func in ["connect", "getConnect", "domain", "getDomain",
"virEventInvokeFreeCallback", "network",
"sparseRecvAll", "sparseSendAll"]:
continue
key = "%s.%s" % (klass, func)
if key not in usedfunctions:
print("FAIL %s.%s (Python API not mapped to C)" % (klass, func))
fail = True
else:
if verbose:
print("PASS %s.%s" % (klass, func))
key = "%s.%s" % (klass, func)
if key not in usedfunctions:
raise Exception("%s.%s (Python API not mapped to C)" % (klass, func))
else:
if verbose:
print("PASS %s.%s" % (klass, func))
# Validate that all the low level C APIs have binding
@@ -372,6 +372,7 @@ def validate_c_api_bindings_present(finalklassmap):
try:
validate_python_to_c_api_mappings(gotfunctions, usedfunctions)
validate_c_api_bindings_present(finalklassmap)
except Exception as e:
print("FAIL: %s" % e)